From nobody Sun May 19 14:32:50 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601642499; cv=none; d=zohomail.com; s=zohoarc; b=D9hjK2hUSn8cZne9CjJQ8SvONSuB1Z9FyJmcw4NP1Hvz5to+GO7k83JaZHwLW9xb/fFjf5xihchY6t5N24HnfKURS06su2ctXta6M+I4QYm8McF+eAJmdxdBrKuCc2eCStaqMOl3O8WU35EErF/rCfsUqdsqJyGCJy8sEooPtTQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601642499; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=wBHth+zBdENXWz8dYgWbeheAt9El7VbwKvgpqtJu8UE=; b=Y7Vk7V2BFR4zDsj1/qLz3EeLHON9NgNYg3d3yMU83V0qUMd2M33Y0Jd6IvYFGA0zkxR3kOndXDx5ZLwIApUjFe2WwdXQ6P870aT3QcE6YBxfPn/6FfSGjwvy4QY31BwrLOPJug9b8gSNECNSgWrqfRo2FH2c8eqC0I4fGQelrMY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160164249976794.9739555959826; Fri, 2 Oct 2020 05:41:39 -0700 (PDT) Received: from localhost ([::1]:57918 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOKNW-0007Rq-Jf for importer@patchew.org; Fri, 02 Oct 2020 08:41:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOKMP-0006le-JY for qemu-devel@nongnu.org; Fri, 02 Oct 2020 08:40:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34656) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kOKMN-000730-Mc for qemu-devel@nongnu.org; Fri, 02 Oct 2020 08:40:29 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-107-NlRPNz8YNCGGJgAdw--t8Q-1; Fri, 02 Oct 2020 08:40:23 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5D0D81084C85; Fri, 2 Oct 2020 12:40:22 +0000 (UTC) Received: from dgilbert-t580.localhost (ovpn-114-192.ams2.redhat.com [10.36.114.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id B67C078806; Fri, 2 Oct 2020 12:40:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601642426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wBHth+zBdENXWz8dYgWbeheAt9El7VbwKvgpqtJu8UE=; b=T0dCy0+XuXuFoFIpn0SI9T5VWrJbi3AA3v6X99WO26ePADzZcVNY2iRdQxmwj2S8AQULrk ABBJTQJ853TUqka6VGCs6zdtC9GHW03XJ6a95t41rQAqTTpo7qTWUPlbooMpL5RqAZ8H8w 9bv7Vh1YhtV1Lmpm3o5MXUF7BFtgQIw= X-MC-Unique: NlRPNz8YNCGGJgAdw--t8Q-1 From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, alex.bennee@linaro.org, stefanha@redhat.com Subject: [PATCH] virtiofsd: Call qemu_init_exec_dir Date: Fri, 2 Oct 2020 13:40:15 +0100 Message-Id: <20201002124015.44820-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/02 01:13:31 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: "Dr. David Alan Gilbert" Since fcb4f59c879 qemu_get_local_state_pathname relies on the init_exec_dir, and virtiofsd asserts because we never set it. Set it. Reported-by: Alex Benn=C3=A9e Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Stefan Hajnoczi Tested-by: Alex Benn=C3=A9e --- tools/virtiofsd/passthrough_ll.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough= _ll.c index 0b229ebd57..cce983ca63 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -2839,6 +2839,8 @@ int main(int argc, char *argv[]) /* Don't mask creation mode, kernel already did that */ umask(0); =20 + qemu_init_exec_dir(argv[0]); + pthread_mutex_init(&lo.mutex, NULL); lo.inodes =3D g_hash_table_new(lo_key_hash, lo_key_equal); lo.root.fd =3D -1; --=20 2.26.2