From nobody Sat May 4 00:42:59 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601638487; cv=none; d=zohomail.com; s=zohoarc; b=Y0WvTyr/XLQsxudIvop72w1glAhbATQ4fz+shdYuazXpcUALhs1CryuhRY101V0A0p4rQTf9Cu50HjA6C1YgaTyjH976KyeiWpUncn4jcPpTAV5M039rsmqJy/eJ8Au7zkPKwSMAuaC4iQUuw9GltBbM5fQMRPvQi5bC6jKrCj0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601638487; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=T0C33xk27iwHi2CyJPAmpAvPjfZEjt9O5EboSui9wPk=; b=bUFUxrtXYTSCfaemPgJGgzxq+VfQgS4WIJ2zghyqlhyfz0qHXyIGX3XyjkMWmiEuf5sl8XSCEdaCrKEWdiaelAwKgnEemEzywkROZqzIMX3i/WWudYhQyiGclHVQf6hvZYMSzlUXygM4/ZqPCc/aLbbBFMWgatF6GagoAD9f0FA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1601638487859539.4165439989206; Fri, 2 Oct 2020 04:34:47 -0700 (PDT) Received: from localhost ([::1]:48986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOJKo-00045U-LM for importer@patchew.org; Fri, 02 Oct 2020 07:34:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOJJ8-0002h0-Mj for qemu-devel@nongnu.org; Fri, 02 Oct 2020 07:33:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47000) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kOJJ4-00076D-Fp for qemu-devel@nongnu.org; Fri, 02 Oct 2020 07:33:02 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-367-yk2ji8_1Obu78NO3dcwczQ-1; Fri, 02 Oct 2020 07:32:55 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5784C425DB; Fri, 2 Oct 2020 11:32:54 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-114-9.ams2.redhat.com [10.36.114.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id A1F9A60C05; Fri, 2 Oct 2020 11:32:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601638377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T0C33xk27iwHi2CyJPAmpAvPjfZEjt9O5EboSui9wPk=; b=JDrbwjZoIDq3HwQcaun69y3/Uh5h13dWm51fVz14F75kESVmzsgR8MWq5TO/nvfRr+X8E+ Vg89+W5tJ2R+nsMAgS5QanDgRnV4WcnLwI6MMw5obClkf0Hs5tWAb862l+Kw1Ddhjq0EaV pYZKH53ESJ2aLubZGTGi2xtSbdDlMyQ= X-MC-Unique: yk2ji8_1Obu78NO3dcwczQ-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 1/2] block: drop moderated sheepdog mailing list from MAINTAINERS file Date: Fri, 2 Oct 2020 12:32:42 +0100 Message-Id: <20201002113243.2347710-2-berrange@redhat.com> In-Reply-To: <20201002113243.2347710-1-berrange@redhat.com> References: <20201002113243.2347710-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/02 01:13:31 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Thomas Huth , Vladimir Sementsov-Ogievskiy , sheepdog@lists.wpkg.org, qemu-block@nongnu.org, libvir-list@redhat.com, Markus Armbruster , Max Reitz , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Liu Yuan , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The sheepdog mailing list is setup to stop and queue messages from non-subscribers, pending moderator approval. Unfortunately it seems that the moderation queue is not actively dealt with. Even when messages are approved, the sender is never added to the whitelist, so every future mail from the same sender continues to get stopped for moderation. MAINTAINERS entries should be responsive and not unneccessarily block mails from QEMU contributors, so drop the sheepdog mailing list. Reviewed-by: Thomas Huth Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Neal Gompa --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b76fb31861..c7d6601adf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2874,7 +2874,6 @@ F: block/rbd.c Sheepdog M: Liu Yuan L: qemu-block@nongnu.org -L: sheepdog@lists.wpkg.org S: Odd Fixes F: block/sheepdog.c =20 --=20 2.26.2 From nobody Sat May 4 00:42:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601638562; cv=none; d=zohomail.com; s=zohoarc; b=nTc9GOUnktbPnXTLmuMGG6U8rwSYNbmNXuPu5TSlQyy+9K5bZAD/JmdjIV7mJAnW0svaaIzBFSoza4Jwlrk/Oxfu/QH/JuS7YwHeXfLhUwUSLuJQnDhplEP2UDNA7K2BM95xSqjSDFYdoYI/a8eZWRV5j1K0Q/WBbDHUBBw/JCk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601638562; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vA9FhMMn/cQZcVsvdoq7mQaQxFyrINk/F97XY+h7nOQ=; b=SmdRhK67TlabG+sAVrr0yTwYnePJm/FR1ub+LlbI5WyUBZUicSHWDt/H/GSuwdnywivmRL86PQIk5WkD17ckdktrZ9hnuKd/ds0opLto4j1RLHVZGtodMJC7qQ6uZ1UHaitvEythIztgY41DjdyWHLXNjklsQEhiS7ZNvJVss5E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1601638562669977.0261395406919; Fri, 2 Oct 2020 04:36:02 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-2-MVVS9iE_PYePFr_0snKkGQ-1; Fri, 02 Oct 2020 07:35:59 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C8AD98735C1; Fri, 2 Oct 2020 11:35:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A66F27881D; Fri, 2 Oct 2020 11:35:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 75B5344A5E; Fri, 2 Oct 2020 11:35:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 092BWvmU001846 for ; Fri, 2 Oct 2020 07:32:57 -0400 Received: by smtp.corp.redhat.com (Postfix) id 64D0560C17; Fri, 2 Oct 2020 11:32:57 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-114-9.ams2.redhat.com [10.36.114.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id A964460C05; Fri, 2 Oct 2020 11:32:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601638561; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=vA9FhMMn/cQZcVsvdoq7mQaQxFyrINk/F97XY+h7nOQ=; b=X1I3TQlRmlG8F7iqk4EsSGIxTFBcQMXX3/fhdeChQw+DH95ETVJ56aYSSaxqkMXlcjs+u6 DNsZn/vI5kisQGiCTP8pM8jRwCKE329LQcGKiCrDVQSzGWvSgnEq5sZNCGaqzS4IJyfmfn NxpYhmOcniRT6r/FEBmfoOxZowYJd3c= X-MC-Unique: MVVS9iE_PYePFr_0snKkGQ-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 2/2] block: deprecate the sheepdog block driver Date: Fri, 2 Oct 2020 12:32:43 +0100 Message-Id: <20201002113243.2347710-3-berrange@redhat.com> In-Reply-To: <20201002113243.2347710-1-berrange@redhat.com> References: <20201002113243.2347710-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: Kevin Wolf , Thomas Huth , Vladimir Sementsov-Ogievskiy , sheepdog@lists.wpkg.org, qemu-block@nongnu.org, libvir-list@redhat.com, Max Reitz , Liu Yuan , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) This thread from a little over a year ago: http://lists.wpkg.org/pipermail/sheepdog/2019-March/thread.html states that sheepdog is no longer actively developed. The only mentioned users are some companies who are said to have it for legacy reasons with plans to replace it by Ceph. There is talk about cutting out existing features to turn it into a simple demo of how to write a distributed block service. There is no evidence of anyone working on that idea: https://github.com/sheepdog/sheepdog/commits/master No real commits to git since Jan 2018, and before then just some minor technical debt cleanup. There is essentially no activity on the mailing list aside from patches to QEMU that get CC'd due to our MAINTAINERS entry. Fedora packages for sheepdog failed to build from upstream source because of the more strict linker that no longer merges duplicate global symbols. Fedora patches it to add the missing "extern" annotations and presumably other distros do to, but upstream source remains broken. There is only basic compile testing, no functional testing of the driver. Since there are no build pre-requisites the sheepdog driver is currently enabled unconditionally. This would result in configure issuing a deprecation warning by default for all users. Thus the configure default is changed to disable it, requiring users to pass --enable-sheepdog to build the driver. Reviewed-by: Markus Armbruster Reviewed-by: Thomas Huth Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Neal Gompa --- block/sheepdog.c | 14 ++++++++++++++ configure | 5 +++-- docs/system/deprecated.rst | 9 +++++++++ 3 files changed, 26 insertions(+), 2 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 2f5c0eb376..e270f2022c 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -242,6 +242,16 @@ typedef struct SheepdogInode { */ #define FNV1A_64_INIT ((uint64_t)0xcbf29ce484222325ULL) =20 +static void deprecation_warning(void) +{ + static bool warned; + + if (!warned) { + warn_report("the sheepdog block driver is deprecated"); + warned =3D true; + } +} + /* * 64 bit Fowler/Noll/Vo FNV-1a hash code */ @@ -1548,6 +1558,8 @@ static int sd_open(BlockDriverState *bs, QDict *optio= ns, int flags, char *buf =3D NULL; QemuOpts *opts; =20 + deprecation_warning(); + s->bs =3D bs; s->aio_context =3D bdrv_get_aio_context(bs); =20 @@ -2007,6 +2019,8 @@ static int sd_co_create(BlockdevCreateOptions *option= s, Error **errp) =20 assert(options->driver =3D=3D BLOCKDEV_DRIVER_SHEEPDOG); =20 + deprecation_warning(); + s =3D g_new0(BDRVSheepdogState, 1); =20 /* Steal SocketAddress from QAPI, set NULL to prevent double free */ diff --git a/configure b/configure index ca9b458ea0..c5971fe560 100755 --- a/configure +++ b/configure @@ -533,7 +533,7 @@ vdi=3D"yes" vvfat=3D"yes" qed=3D"yes" parallels=3D"yes" -sheepdog=3D"yes" +sheepdog=3D"no" libxml2=3D"" debug_mutex=3D"no" libpmem=3D"" @@ -1940,7 +1940,7 @@ disabled with --disable-FEATURE, default is enabled i= f available: vvfat vvfat image format support qed qed image format support parallels parallels image format support - sheepdog sheepdog block driver support + sheepdog sheepdog block driver support (deprecated) crypto-afalg Linux AF_ALG crypto backend driver capstone capstone disassembler support debug-mutex mutex debugging support @@ -7200,6 +7200,7 @@ if test "$parallels" =3D "yes" ; then echo "CONFIG_PARALLELS=3Dy" >> $config_host_mak fi if test "$sheepdog" =3D "yes" ; then + add_to deprecated_features "sheepdog" echo "CONFIG_SHEEPDOG=3Dy" >> $config_host_mak fi if test "$pty_h" =3D "yes" ; then diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index da862201ba..fbc67b189b 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -376,6 +376,15 @@ The above, converted to the current supported format:: =20 json:{"file.driver":"rbd", "file.pool":"rbd", "file.image":"name"} =20 +``sheepdog`` driver (since 5.2.0) +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +The ``sheepdog`` block device driver is deprecated. The corresponding upst= ream +server project is no longer actively maintained. Users are recommended to = switch +to an alternative distributed block device driver such as RBD. The +``qemu-img convert`` command can be used to liberate existing data by movi= ng +it out of sheepdog volumes into an alternative storage backend. + linux-user mode CPUs -------------------- =20 --=20 2.26.2