From nobody Fri Dec 19 17:34:40 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601573133; cv=none; d=zohomail.com; s=zohoarc; b=XISfPZ02nuZqjfWCzyDmO6XWbXwQGLnS4DKUI16NkoYkFi4stjLdjFukU52jxg+eD7T9F80OO+siycRo2FUTaLGKqPHbZMn0BuDfjq+prPE9GskttKhDHpLoBQOsIfyKvOrYT5oZhORXj0t6Mqydyz9oc4+WleHCzJXJuP4wERE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601573133; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=kDqdtq58pQ4zoZVkr3FaloUPfNhxdNZfP/qYUQHcHb8=; b=lU1zHeFMFplhl9Zu+Fi/Ri+aXdcc/cZxwuRZPGGihpjAbQ/dqqz5z9XgSvD4myyfzkDtZn9TPoAjcy1n6MbGSz0FjK5Dxm8LajEl5Yked8BJOWqZZbvmuoE16ExTwJt3+Mxcpy4QG84u1eilNsK3NvT6WKKUXJlxjqbmVDowpbk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1601573133223510.18068149356316; Thu, 1 Oct 2020 10:25:33 -0700 (PDT) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-289-Qa5v5aUaO9iCUGPbQtjsKg-1; Thu, 01 Oct 2020 13:25:27 -0400 Received: by mail-wm1-f72.google.com with SMTP id a25so1119269wmb.2 for ; Thu, 01 Oct 2020 10:25:27 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (74.red-83-53-161.dynamicip.rima-tde.net. [83.53.161.74]) by smtp.gmail.com with ESMTPSA id c4sm911793wme.27.2020.10.01.10.25.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 10:25:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601573131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kDqdtq58pQ4zoZVkr3FaloUPfNhxdNZfP/qYUQHcHb8=; b=iLMOgZ3p7+fxfZNC8pCJvSVfRixYnduzAj1u95TLe2E5LIMdE4ahvYv9msVSyjY2pDxXEi 9I4FVSg/cUqR/AKjwJPMy0fW2mKLfP7mSIaXfuhihS5RUXbIZNjh3dUYjorNVDOxpktf9D dqOmCjOpmeL9HAf76F3lcdY1FK4H4Rw= X-MC-Unique: Qa5v5aUaO9iCUGPbQtjsKg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kDqdtq58pQ4zoZVkr3FaloUPfNhxdNZfP/qYUQHcHb8=; b=kpgwwdUBG1fs6vK7WeOINN2YcYBNgJT1dV4FFK2TZPb4vstTkZu9iCOrteNY0K8rgR r77LCeeS0D8kFRkgI/KBx8hWCaIyPukNowUCcb/F39dgIJYFIMwUBZ/aCKtjexTZu5AJ wBVQk/G+Zs5HBLX4Sn7f1yqmWCw1i53w+Xli7WoA3Nj6i/vFovcyrBz3MXHcxFLl3VjJ dfGm5QssFnWM8UIagn12nQc7nBtxYfJ5pR5DhXX6mf8lW7Q87Ibp0SMrkg9WkdEtwd4x 6t1tJpLm18dIQJPtNQYO83MX2pIkqbEyGsPFDoC3qeJ2HCVhmKkAsnmr41rgORQtZWvS FktQ== X-Gm-Message-State: AOAM530R/A5H4FKt7awfRZvscFcqEb44bep8IlAhOkfTqwr7BzHqGYlp 3FprFlq3PGz3VI7VA2Ltw6Ms1tV879jLVQL926SMhw7tNfmP/ag08a1zd6TScx4fKq38CxvNt3i Yk37g9RJJMRNSkw== X-Received: by 2002:a5d:67d0:: with SMTP id n16mr11075384wrw.198.1601573126594; Thu, 01 Oct 2020 10:25:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySZMM33BbdJ0sR0nGXiOX6FWsXB2b32Yq56EZPV+x7b/7t27gSDw9A3CcKwp1NY4quCUxtNQ== X-Received: by 2002:a5d:67d0:: with SMTP id n16mr11075373wrw.198.1601573126441; Thu, 01 Oct 2020 10:25:26 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini Subject: [PATCH RESEND v2 01/16] pci: pass along the return value of dma_memory_rw Date: Thu, 1 Oct 2020 19:25:04 +0200 Message-Id: <20201001172519.1620782-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201001172519.1620782-1-philmd@redhat.com> References: <20201001172519.1620782-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) From: Klaus Jensen Some might actually care about the return value of dma_memory_rw. So let us pass it along instead of ignoring it. There are no existing users of the return value, so this patch should be safe. Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Michael S. Tsirkin Acked-by: Keith Busch Message-Id: <20191011070141.188713-2-its@irrelevant.dk> Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/pci/pci.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 0a59a06b14..f19ffe6b4f 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -783,8 +783,7 @@ static inline AddressSpace *pci_get_address_space(PCIDe= vice *dev) static inline int pci_dma_rw(PCIDevice *dev, dma_addr_t addr, void *buf, dma_addr_t len, DMADirection dir) { - dma_memory_rw(pci_get_address_space(dev), addr, buf, len, dir); - return 0; + return dma_memory_rw(pci_get_address_space(dev), addr, buf, len, dir); } =20 static inline int pci_dma_read(PCIDevice *dev, dma_addr_t addr, --=20 2.26.2