From nobody Tue Feb 10 02:54:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) client-ip=209.85.221.66; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f66.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1601572927; cv=none; d=zohomail.com; s=zohoarc; b=MFsIKS5hrnmOkMA95q5yfxuiyYwJ15scaAivit/gpNAXJn1TrS1ioFRjJJP8Kk2H8jqmseFaaPJARsHPYLRnBZS/oSYWttdax2AlZulCS3XtfeRLfcM8RLNdm/HE7lv6vsjcJPRoajBR2gc2znYmKeyUquuUB01uIbB/rm6zZM8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601572927; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+6y9SStSTnN9ITmv25hC1Xnc3CSF+ES6LDmfkf2yvN0=; b=RuZpIxbVZaap0MuU79X811ng2UiQf/3rfrgDbNMyPnpfDkSvkGK9ilTcaezuU7wb6bQnzr8dDSSzVjiacHVQOtyl9fcHbHcvMukBH3eWutvKrNtZK0XNxKROZOzulgeLOA5dmPZsFmwaK/0RkAQjsOERDx/Cp8ZwYnZWf8LrGOE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.zohomail.com with SMTPS id 1601572927535593.9666944025082; Thu, 1 Oct 2020 10:22:07 -0700 (PDT) Received: by mail-wr1-f66.google.com with SMTP id z4so6733418wrr.4 for ; Thu, 01 Oct 2020 10:22:06 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (74.red-83-53-161.dynamicip.rima-tde.net. [83.53.161.74]) by smtp.gmail.com with ESMTPSA id h8sm9719625wrw.68.2020.10.01.10.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 10:22:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+6y9SStSTnN9ITmv25hC1Xnc3CSF+ES6LDmfkf2yvN0=; b=B+n7lMB4E+Kh7A3+lIgqPSfaxJb8wpYZcuRGDJKDZObkWjo0BFYJIB2pTpICCvHHJT wxRNm8TuTm2lHbd0r2UiYU80YQ3dlffa1VODm7pSPQY4ptYQ9YTsfqUHmb9Al/VzCgwT XnzZS7PzLBx1KkJr0uRxJ9JbU7SFak5ByMoP6DYXCNJtpOunynoYoKJWxbV+DxhIp8ft L0axCGyQa77eygR7XW+2vxC3aK2A7uGVfGeMb8LBd/e30NQstNCsWQa9uTPc2PBXocFU TuVODKOGQ1ELgvCI8Kl1QHCudrOsUhj5KXLsXv3+7k0TedcjVzrz6AFqRfJ8woB5K2UR 10bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=+6y9SStSTnN9ITmv25hC1Xnc3CSF+ES6LDmfkf2yvN0=; b=AYaYknbL4QjC5f+TfrRrPAqrr1h2/e/QaT0pj06NeZaALFYnLM+a6vXjonmhirD2bq /FjJlzE2z/Z5UCUHqRVX+91Kz2rzhHxQ4Su3/9LEhRVhOHOg20BKA7vaqrbLccnUTQD7 mue6dVRAhjMi3eRon5CX3SWYguzK+vNaZtUYSPfEgeNsjKUdTrXQRTGMIwksNM5tOOO1 nrXtbHGNWoPqp7RGF73ibWAwVk2q9+T09JxXwcQ5UVEYD8KYTMyZ+Cj3lUgDMiNytDvq dNqlo/puHtBsMx/cefYrqhsOpsPwXAmwAwxJnhDlG8SWheWfX4bKmryFv0lT+SG68iaV LWvw== X-Gm-Message-State: AOAM5302JVrywO1ooxDdUYC6p7ypnyL4h1XzCRZ6/6JbSufnig7TfZmS pmMg03PvUi8PyCj9GsVXYxM= X-Google-Smtp-Source: ABdhPJz5v+5FS5wJpM3Gu0TPxIodutB3X1LWsbo99w/oDxaJoIEstqP5lEqxAaGCcN5Ew1rOMhuAIA== X-Received: by 2002:adf:dd0b:: with SMTP id a11mr9964746wrm.422.1601572925659; Thu, 01 Oct 2020 10:22:05 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini Subject: [PATCH v2 04/16] dma: Let dma_memory_set() propagate MemTxResult Date: Thu, 1 Oct 2020 19:21:47 +0200 Message-Id: <20201001172159.1619456-5-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201001172159.1619456-1-f4bug@amsat.org> References: <20201001172159.1619456-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: Philippe Mathieu-Daud=C3=A9 address_space_write() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/sysemu/dma.h | 15 ++++++++++++++- dma-helpers.c | 7 ++++--- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/include/sysemu/dma.h b/include/sysemu/dma.h index c6e12b4c24..37cd9f1121 100644 --- a/include/sysemu/dma.h +++ b/include/sysemu/dma.h @@ -123,7 +123,20 @@ static inline int dma_memory_write(AddressSpace *as, d= ma_addr_t addr, DMA_DIRECTION_FROM_DEVICE); } =20 -int dma_memory_set(AddressSpace *as, dma_addr_t addr, uint8_t c, dma_addr_= t len); +/** + * dma_memory_set: Fill memory with a constant byte from DMA controller. + * + * Return a MemTxResult indicating whether the operation succeeded + * or failed (eg unassigned memory, device rejected the transaction, + * IOMMU fault). + * + * @as: #AddressSpace to be accessed + * @addr: address within that address space + * @c: constant byte to fill the memory + * @len: the number of bytes to fill with the constant byte + */ +MemTxResult dma_memory_set(AddressSpace *as, dma_addr_t addr, + uint8_t c, dma_addr_t len); =20 /** * address_space_map: Map a physical memory region into a host virtual add= ress. diff --git a/dma-helpers.c b/dma-helpers.c index 41ef24a63b..4a9e37d6d0 100644 --- a/dma-helpers.c +++ b/dma-helpers.c @@ -1,7 +1,7 @@ /* * DMA helper functions * - * Copyright (c) 2009 Red Hat + * Copyright (c) 2009,2020 Red Hat * * This work is licensed under the terms of the GNU General Public License * (GNU GPL), version 2 or later. @@ -18,14 +18,15 @@ =20 /* #define DEBUG_IOMMU */ =20 -int dma_memory_set(AddressSpace *as, dma_addr_t addr, uint8_t c, dma_addr_= t len) +MemTxResult dma_memory_set(AddressSpace *as, dma_addr_t addr, + uint8_t c, dma_addr_t len) { dma_barrier(as, DMA_DIRECTION_FROM_DEVICE); =20 #define FILLBUF_SIZE 512 uint8_t fillbuf[FILLBUF_SIZE]; int l; - bool error =3D false; + MemTxResult error =3D MEMTX_OK; =20 memset(fillbuf, c, FILLBUF_SIZE); while (len > 0) { --=20 2.26.2