From nobody Tue Feb 10 05:46:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.68 as permitted sender) client-ip=209.85.128.68; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f68.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1601570610; cv=none; d=zohomail.com; s=zohoarc; b=nPAIeKjZrdR1ChTcJfV/gTA+D6Pt0VzMISPK4lrL9JCHqJ71g5Yj/B3WLDb9RG8SSB4L3asUXKWK10TokOCMxijw0Bbo1m8ldCVlQn6Fob4id4LtmbHM1/EQlNzxdbqXdU+JKWM6JPK9RzdMuowX3DYnLHUO0Mq3U9of7KX+ink= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601570610; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=aalZfwDNGdwdW5/IIKOVPxUHA6XH4oPdaqpcACoVNTg=; b=dZ68YFSqTO0edycKpxY5JJa/R12A+q0bKPqR4DRPIe7u5dx7DVKY6KGsr9NkNGwST5Ant4v/kZPqeuydYz4+dlYbwD7wJeL/ABY25KEx8b+6opgkZz/X2hQnmDmPx4Y/8FtSNvMypY1uVouNrg/zz6sbaik8p8R/r/y72RmuOcM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.zohomail.com with SMTPS id 1601570610369481.1710076033769; Thu, 1 Oct 2020 09:43:30 -0700 (PDT) Received: by mail-wm1-f68.google.com with SMTP id l15so2627720wmh.1 for ; Thu, 01 Oct 2020 09:43:29 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (74.red-83-53-161.dynamicip.rima-tde.net. [83.53.161.74]) by smtp.gmail.com with ESMTPSA id h3sm10733059wrq.0.2020.10.01.09.43.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 09:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aalZfwDNGdwdW5/IIKOVPxUHA6XH4oPdaqpcACoVNTg=; b=fS0+JREyYVjO9EvT+b7+KTBJI63x8Q0fqj88LoSiwFxbXe/5Vhyf2QorziKM1xwo8S qEXXUYpCOaj1FmSZHp9wi0lBCytWSOM9ikLZtOBDl+DhEL8Grwkn/P+EYk87aNpbn7ol wMFQ4jOskhB6UQaauPR0Oa9Ir5ncFoG7/bNfjw1fQ90puX0pd/5HrkUSeo67Z0NB5dsn n61m437iNDueDmXFv4gwCwSJ2oZlCc3BKCr91xqAS5OdlS3iqN/z7A8F8XT1y2KcGUou CVhlGpSAA6MHVKy1lMxSBNQ8E9w944NW0XzVOL0UORVAj4k3+GMyUhlp2UDcivL2NmKH VU0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=aalZfwDNGdwdW5/IIKOVPxUHA6XH4oPdaqpcACoVNTg=; b=VfyjpuIHff+Rbjo5TN1OqPvm4qWpC8ZhuunSgfFGv2lljWlTYyOs0VscV5eNd051dO sEOHwCJB66V01ykgL49vD8nJQsjnta9Vxzlpdkg6XETgPxHz7pwKVFTYRNIqQb3nmdN/ QzF5AiEETYF61ySBU7SWAHER1FoYPAWuIfF7VxNlLT3TAsNQhS30yr6DA3vFF7PcRgbL tQ2elvhY6eIf1lYaIENcAWXDnNN55pY7HuN9+hUY8gLr40NS0HYNQg+5tRp/OkGqrhV9 lCub/2wf0vkwD8yyJSF7XsXIHY5wDaQgblNV+oU5EVhPNQdDbv0fRpF7qs/pVNtHfvR3 ftug== X-Gm-Message-State: AOAM530kZWX3qYTw4JZ2pGTr/sKU9ptPoOcqB8R0jXuPKnp4bs3V5qSJ OhOpwdlVC26VKWaPJKXlu+0= X-Google-Smtp-Source: ABdhPJwRkbwt64+1WsO53KCSGp0gY4jt27b1b4sOgvKPpIWS1rJit2eDmXAgNO3SA82056PUg0K6Sw== X-Received: by 2002:a05:600c:2047:: with SMTP id p7mr979653wmg.168.1601570608415; Thu, 01 Oct 2020 09:43:28 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Luc Michel , Peter Maydell , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost , Havard Skinnemoen , "Edgar E . Iglesias" , Damien Hedde , Alistair Francis , Tyrone Ting , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 2/3] qdev-monitor: Display frequencies scaled to SI unit Date: Thu, 1 Oct 2020 18:43:21 +0200 Message-Id: <20201001164322.1585392-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201001164322.1585392-1-f4bug@amsat.org> References: <20201001164322.1585392-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Since commit 9f2ff99c7f2 ("qdev-monitor: print the device's clock with info qtree") we can display the clock frequencies in the monitor. Use the recently introduced freq_to_str() to display the frequencies using the closest SI unit (human friendlier). Before: (qemu) info qtree [...] dev: xilinx,zynq_slcr, id "" clock-in "ps_clk" freq_hz=3D3.333333e+07 mmio 00000000f8000000/0000000000001000 After: dev: xilinx,zynq_slcr, id "" clock-in "ps_clk" freq_hz=3D33.3 MHz mmio 00000000f8000000/0000000000001000 Reviewed-by: Luc Michel Reviewed-by: Damien Hedde Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- qdev-monitor.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index e9b7228480..a0301cfca8 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -747,11 +747,13 @@ static void qdev_print(Monitor *mon, DeviceState *dev= , int indent) } } QLIST_FOREACH(ncl, &dev->clocks, node) { - qdev_printf("clock-%s%s \"%s\" freq_hz=3D%e\n", + g_autofree char *freq =3D NULL; + + freq =3D freq_to_str(clock_get_hz(ncl->clock)); + qdev_printf("clock-%s%s \"%s\" freq_hz=3D%s\n", ncl->output ? "out" : "in", ncl->alias ? " (alias)" : "", - ncl->name, - CLOCK_PERIOD_TO_HZ(1.0 * clock_get(ncl->clock))); + ncl->name, freq); } class =3D object_get_class(OBJECT(dev)); do { --=20 2.26.2