From nobody Mon Feb 9 11:06:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601484619; cv=none; d=zohomail.com; s=zohoarc; b=XjB7PMODTVG/V5nmU+3Z9sDdsnzEmZBwTV6VD5T97z/sr+kPQR1lG9nVMgj2Nafrw5F2xNCf6q8J9qLvFXJLW+keqogvlhYITiuBBhkQ7sGQXeeK0mcgMzLE0XQ3l9FpN3ojaYj1UbUOsHYxMvmyFNfugH5NxhmpyoIDHZ6eJJo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601484619; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=zXLYVmcZORAN1WI9rIV4a3OMV4bhJ5fCBxobebcKs5M=; b=EbxJiEg9hjGK9s6Y7S45vIs7zgT5wZ6o8rzf0S9S7PF2pN5i2CYxsRctAHPAjcKqxKR2RVje7IRaUEIGo9/j4m1q8spbw6J/xABSc8GZcr8Nec5IqaSHLE0s6h+NpFYJFWubxecH3TruQkl29mvU4cKvc+P8sbg/1ZPjjzszwRY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1601484619807249.04348663052667; Wed, 30 Sep 2020 09:50:19 -0700 (PDT) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-dp6iYjYfNE-tVcLjIcjXwQ-1; Wed, 30 Sep 2020 12:50:14 -0400 Received: by mail-wr1-f72.google.com with SMTP id d13so814356wrr.23 for ; Wed, 30 Sep 2020 09:50:14 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (74.red-83-53-161.dynamicip.rima-tde.net. [83.53.161.74]) by smtp.gmail.com with ESMTPSA id v2sm4040504wme.19.2020.09.30.09.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 09:50:12 -0700 (PDT) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601484618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zXLYVmcZORAN1WI9rIV4a3OMV4bhJ5fCBxobebcKs5M=; b=iNImFuIWJBVGW4OBgj3fotfvOuAQAFCpulStaCWkUmRdcueeyEduSxvYtw8Ru0qNEQEzCz I6LdH1909Rb+eX2nxTGGYJCdhugvUdVhXTX67QdKr/N+xP8gmcZ2mXiCMOSYSNFlenDMgf cQfK4Ftw44p7GBjh+Z/WFvhB+ipm57E= X-MC-Unique: dp6iYjYfNE-tVcLjIcjXwQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zXLYVmcZORAN1WI9rIV4a3OMV4bhJ5fCBxobebcKs5M=; b=DHy50W2rC/5ELkNoWrI67KXYk1xsr5eNCntOBSrwrkRouwE/PKa89A5R0I69nX9VmX swL+n1dnj3jJ981eS9vQomGc+nY88dffrbdSoJU5XjZ81+VQxinuALkyNEKaMT5zHdCi hS0vPGV+ctiaS2uSDDb7RxAFl9IMb0w6J1qysPPBy/nCOA1PMxDMDuBCLAoi7wIk0mXP x7V1KvnNFpeBZqgyCZIhBbxt+uO3QBWsqf3EEO40qIa0TDQP9GEXVP6NBst2Fb4uwvPr YRkjZJ9hM9j8wJPOMvAxZh2OQaZf/nbPIo0clchcGHcg0lRJtUiCkp+/wFy+VeH4W4xD oUEQ== X-Gm-Message-State: AOAM533H6IBv/RDtgp3EOws+X2nGsdENE9C7HEH9oAb1Np0j/gYq3F2Q JuZRtcjlX15zWXuJzL3/8FHQiIq3f7SQlL8bkp/cJ72vtfq8qr45gVYxweGkf+96LDG8H35GU/4 rB1j1Oc5pgqEMEQ== X-Received: by 2002:a1c:59c2:: with SMTP id n185mr3938721wmb.43.1601484613367; Wed, 30 Sep 2020 09:50:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9t/R0crJ5TioAioJD4m7jku3Gfqpg0Q8CECC1TjraYneMkxr7YZqz8+8/jjFJLXK3cxZWUQ== X-Received: by 2002:a1c:59c2:: with SMTP id n185mr3938695wmb.43.1601484613132; Wed, 30 Sep 2020 09:50:13 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Laurent Vivier Cc: Ronnie Sahlberg , Eric Blake , Kevin Wolf , Marcel Apfelbaum , Richard Henderson , Michael Roth , Eduardo Habkost , Peter Lieven , Markus Armbruster , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , qemu-block@nongnu.org, Paolo Bonzini , Max Reitz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v3 04/11] hw/core/qdev-properties: Fix code style Date: Wed, 30 Sep 2020 18:49:42 +0200 Message-Id: <20200930164949.1425294-5-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200930164949.1425294-1-philmd@redhat.com> References: <20200930164949.1425294-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) We will soon move this code, fix its style to avoid checkpatch.pl to complain. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/core/qdev-properties.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index a1190a5db9..071fd5864a 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -543,15 +543,15 @@ static void set_mac(Object *obj, Visitor *v, const ch= ar *name, void *opaque, if (!qemu_isxdigit(str[pos])) { goto inval; } - if (!qemu_isxdigit(str[pos+1])) { + if (!qemu_isxdigit(str[pos + 1])) { goto inval; } if (i =3D=3D 5) { - if (str[pos+2] !=3D '\0') { + if (str[pos + 2] !=3D '\0') { goto inval; } } else { - if (str[pos+2] !=3D ':' && str[pos+2] !=3D '-') { + if (str[pos + 2] !=3D ':' && str[pos + 2] !=3D '-') { goto inval; } } @@ -898,8 +898,8 @@ static void set_blocksize(Object *obj, Visitor *v, cons= t char *name, /* We rely on power-of-2 blocksizes for bitmasks */ if ((value & (value - 1)) !=3D 0) { error_setg(errp, - "Property %s.%s doesn't take value '%" PRId64 "', it's n= ot a power of 2", - dev->id ?: "", name, (int64_t)value); + "Property %s.%s doesn't take value '%" PRId64 "', " + "it's not a power of 2", dev->id ?: "", name, (int64_t)v= alue); return; } =20 --=20 2.26.2