From nobody Mon Feb 9 09:34:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601441881; cv=none; d=zohomail.com; s=zohoarc; b=A8EvV6cTrMX3ur8OC95YTbaOv2nqOsKoyr08A/K2/MPw79Vtp1f79Sl9ib6YgpEV8L3BqRBDhD14uyZALPn6QYqKOc23mPsvG7T8iATSyH5XQvmUS1Qmie8kUb9yxjH18M8gIdk0hv6BEadmiF3kSXr5VemMI5HzbqGbTrMfShI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601441881; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KQYT6d+KW7aKpu5//RYJSYp44P0WlrsHPCEPKgfz9g8=; b=H8Zwa4/cY9FDOzighgX/KJCU24/QjyrChFja60FjBu7mv0yFinmAcG5xkmIIOZSv38Sihx4A1gt6+noxZjd45cg0sjKTN2WDQxZa1ofr6pKWhuvX9dCadnqG1T3+blfRIsslmCK7yLy2r0Pk5P+rIBxu2NOy5j6c9M/BKnHJS0o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1601441881556934.7920979197575; Tue, 29 Sep 2020 21:58:01 -0700 (PDT) Received: from localhost ([::1]:51264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNUBk-0000nO-Cc for importer@patchew.org; Wed, 30 Sep 2020 00:58:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNTna-0001IY-Lt for qemu-devel@nongnu.org; Wed, 30 Sep 2020 00:33:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:41817) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kNTnY-0000c9-CJ for qemu-devel@nongnu.org; Wed, 30 Sep 2020 00:33:02 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-378-wy4jewKNMlCI4rDUAygRtg-1; Wed, 30 Sep 2020 00:32:54 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C705C185A0C0; Wed, 30 Sep 2020 04:32:53 +0000 (UTC) Received: from scv.redhat.com (ovpn-119-140.rdu2.redhat.com [10.10.119.140]) by smtp.corp.redhat.com (Postfix) with ESMTP id 23A8E73678; Wed, 30 Sep 2020 04:32:52 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601440379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KQYT6d+KW7aKpu5//RYJSYp44P0WlrsHPCEPKgfz9g8=; b=Hwqg//YoqlI7H8jqMlHM44rPSn2kgBtfmthmEi10r9f14tzGu7haQxFERcGnf9gtNtFRK/ jR84zCbFSM4xQhwn9AdpqTUyWlJaeWA3ZuyUmfPiHUskNzrqF9nGuIIjaw5/BKPU3mCOQe kSSXxAGIxyT///VyQshiFcURJPsY2Xw= X-MC-Unique: wy4jewKNMlCI4rDUAygRtg-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v4 30/46] qapi/gen.py: Fix edge-case of _is_user_module Date: Wed, 30 Sep 2020 00:31:34 -0400 Message-Id: <20200930043150.1454766-31-jsnow@redhat.com> In-Reply-To: <20200930043150.1454766-1-jsnow@redhat.com> References: <20200930043150.1454766-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/30 00:31:59 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.687, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Eduardo Habkost , Markus Armbruster , John Snow , Cleber Rosa , =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The edge case is that if the name is '', this expression returns a string instead of a bool, which violates our declared type. Signed-off-by: John Snow Reviewed-by: Cleber Rosa Reviewed-by: Eduardo Habkost --- scripts/qapi/gen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py index b8a6fe8a5c3..58cc1d8e734 100644 --- a/scripts/qapi/gen.py +++ b/scripts/qapi/gen.py @@ -243,7 +243,7 @@ def __init__(self, prefix, what, user_blurb, builtin_bl= urb, pydoc): =20 @staticmethod def _is_user_module(name): - return name and not name.startswith('./') + return bool(name and not name.startswith('./')) =20 @staticmethod def _is_builtin_module(name): --=20 2.26.2