From nobody Mon Feb 9 20:46:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1601408502; cv=none; d=zohomail.com; s=zohoarc; b=BPHmiUOo8RdepdYBw4eASNDklJH9tbdt8nN4I0tthClPgEqYyrc1anWKmMIdF8ktAzSRSWpa46d4TexkVqglq0pH9Sw0+oTtn/FYJk2TS+HOWWUIU+48X4B1paPRQTmnUoQo11DyRfX8+cgjCA69xlZMXcOX0VuK3rsfx4DaMxc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601408502; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=0uRdLMEkStNDsIE72X2fVUad0wG7IvLGN5J5AqixjpQ=; b=Et39Z727gUVRA3bSHNrGEW07M9uxcOvFxZeZmIhfnZeFi/z3nnJfTn8DdEyBWdWmKlpjzY2Z0tHTted3bIqbe7kszqEdPV/sGNxLvgX9aHeRL8SIhZJGg0H/+N8YOg7sKQVrTlsr5O6BR7rp4XUFHgNgEPJTgmiwUWrKPIElkWA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160140850284434.434878973407535; Tue, 29 Sep 2020 12:41:42 -0700 (PDT) Received: from localhost ([::1]:44692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNLVN-0002A5-Fl for importer@patchew.org; Tue, 29 Sep 2020 15:41:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNKy6-0005iw-62 for qemu-devel@nongnu.org; Tue, 29 Sep 2020 15:07:18 -0400 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:40657) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNKy3-0002D2-Ak for qemu-devel@nongnu.org; Tue, 29 Sep 2020 15:07:17 -0400 Received: by mail-pg1-x544.google.com with SMTP id s31so4630459pga.7 for ; Tue, 29 Sep 2020 12:07:14 -0700 (PDT) Received: from localhost.localdomain (122-116-72-36.HINET-IP.hinet.net. [122.116.72.36]) by smtp.gmail.com with ESMTPSA id v8sm6003950pgg.58.2020.09.29.12.07.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2020 12:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0uRdLMEkStNDsIE72X2fVUad0wG7IvLGN5J5AqixjpQ=; b=dnuWM1Nx4t3IaFZKMZxtnVyybMkQCyubdRkyHKWee9mnpbY0HvkDTlL3NUcHccLRu5 gVklsXyf40sG6HytOW4pTfWltwZ8/9dcYvlVO/feYG1/a03HafB64gBPMfq/hDInU+iI BiwFCB0I5Gr4WsGC3PeLjaRg9chuH6MCuYpSY/3ZGH1ksqGmCSHygitidInnPFDNYX2i XUxI93nx2OmH8CuBCmUJi28F9VdmR3zrPhSNQ6E0O2z6zYfvJrxwuhiwcpqHn7QoMezK qqvP252fNGaRLUiev2efJVzR7FHuW2d0Zu1KmcCAvO7YTiJrkZ/iyeu+XAImBz0pjFnP DJ/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=0uRdLMEkStNDsIE72X2fVUad0wG7IvLGN5J5AqixjpQ=; b=BnSeOUT5msI1/xW8OZX+kiz0TucfNuFgb2K6VEof85talc0EdDm15hqZEun9RSPRT9 /ybB0qunzLkyPYrmIzTakasmw63EA2RWQsGw/uwvb+rlLanCOnTvP8MK5O64oV7ZvPdC wtFeeFibzEe8Yhcq8dSuu32bTkxLKGg8n2pALYAPTkNubyCH040HCIahr3NUX7fSQ1l9 K5FMvNzUa5HYeWVLaDk2ADqGfXPIywJzqv4x2UVOP8De92cwWyiOS1G4Hnj+Dj75vSiK BzybTJ/C2bkLnxhS4OmuINMWZoBzadv11RaWW0ujN3IT3ojEs1PebcKqb13EcK/wvan7 zl/Q== X-Gm-Message-State: AOAM530emDyjYbD9Ptccn6WWebyNL2KC/GsKgCgt18beoQupUtC/NTOd mYn9pDYUm7dYqntXRx/7nwP73byuIYbi+A== X-Google-Smtp-Source: ABdhPJyf2N/F70hP4gzzFTf/cKPa+BGnLMlkrTaN70TPcXka68O82n5XtSo3EMyj9fJiXyz0BSrtkA== X-Received: by 2002:a17:902:ec02:b029:d1:fc2b:fe95 with SMTP id l2-20020a170902ec02b02900d1fc2bfe95mr6333700pld.79.1601406434003; Tue, 29 Sep 2020 12:07:14 -0700 (PDT) From: frank.chang@sifive.com To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Subject: [RFC v5 33/68] target/riscv: rvv-1.0: allow load element with sign-extended Date: Wed, 30 Sep 2020 03:04:08 +0800 Message-Id: <20200929190448.31116-34-frank.chang@sifive.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200929190448.31116-1-frank.chang@sifive.com> References: <20200929190448.31116-1-frank.chang@sifive.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::544; envelope-from=frank.chang@sifive.com; helo=mail-pg1-x544.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagar Karandikar , Frank Chang , Bastian Koppelmann , Richard Henderson , Alistair Francis , Palmer Dabbelt , LIU Zhiwei Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Frank Chang For some vector instructions (e.g. vmv.s.x), the element is loaded with sign-extended. Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/insn_trans/trans_rvv.c.inc | 32 +++++++++++++++++-------- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc b/target/riscv/insn_tr= ans/trans_rvv.c.inc index ae2b224b0f..6c542a97d8 100644 --- a/target/riscv/insn_trans/trans_rvv.c.inc +++ b/target/riscv/insn_trans/trans_rvv.c.inc @@ -3068,17 +3068,29 @@ static bool trans_vid_v(DisasContext *s, arg_vid_v = *a) /* Integer Extract Instruction */ =20 static void load_element(TCGv_i64 dest, TCGv_ptr base, - int ofs, int sew) + int ofs, int sew, bool sign) { switch (sew) { case MO_8: - tcg_gen_ld8u_i64(dest, base, ofs); + if (!sign) { + tcg_gen_ld8u_i64(dest, base, ofs); + } else { + tcg_gen_ld8s_i64(dest, base, ofs); + } break; case MO_16: - tcg_gen_ld16u_i64(dest, base, ofs); + if (!sign) { + tcg_gen_ld16u_i64(dest, base, ofs); + } else { + tcg_gen_ld16s_i64(dest, base, ofs); + } break; case MO_32: - tcg_gen_ld32u_i64(dest, base, ofs); + if (!sign) { + tcg_gen_ld32u_i64(dest, base, ofs); + } else { + tcg_gen_ld32s_i64(dest, base, ofs); + } break; case MO_64: tcg_gen_ld_i64(dest, base, ofs); @@ -3133,7 +3145,7 @@ static void vec_element_loadx(DisasContext *s, TCGv_i= 64 dest, =20 /* Perform the load. */ load_element(dest, base, - vreg_ofs(s, vreg), s->sew); + vreg_ofs(s, vreg), s->sew, false); tcg_temp_free_ptr(base); tcg_temp_free_i32(ofs); =20 @@ -3151,9 +3163,9 @@ static void vec_element_loadx(DisasContext *s, TCGv_i= 64 dest, } =20 static void vec_element_loadi(DisasContext *s, TCGv_i64 dest, - int vreg, int idx) + int vreg, int idx, bool sign) { - load_element(dest, cpu_env, endian_ofs(s, vreg, idx), s->sew); + load_element(dest, cpu_env, endian_ofs(s, vreg, idx), s->sew, sign); } =20 static bool trans_vext_x_v(DisasContext *s, arg_r *a) @@ -3163,7 +3175,7 @@ static bool trans_vext_x_v(DisasContext *s, arg_r *a) =20 if (a->rs1 =3D=3D 0) { /* Special case vmv.x.s rd, vs2. */ - vec_element_loadi(s, tmp, a->rs2, 0); + vec_element_loadi(s, tmp, a->rs2, 0, false); } else { /* This instruction ignores LMUL and vector register groups */ int vlmax =3D s->vlen >> (3 + s->sew); @@ -3245,7 +3257,7 @@ static bool trans_vfmv_f_s(DisasContext *s, arg_vfmv_= f_s *a) (s->mstatus_fs !=3D 0) && (s->sew !=3D 0)) { unsigned int len =3D 8 << s->sew; =20 - vec_element_loadi(s, cpu_fpr[a->rd], a->rs2, 0); + vec_element_loadi(s, cpu_fpr[a->rd], a->rs2, 0, false); if (len < 64) { tcg_gen_ori_i64(cpu_fpr[a->rd], cpu_fpr[a->rd], MAKE_64BIT_MASK(len, 64 - len)); @@ -3347,7 +3359,7 @@ static bool trans_vrgather_vx(DisasContext *s, arg_rm= rr *a) TCGv_i64 dest =3D tcg_temp_new_i64(); =20 if (a->rs1 =3D=3D 0) { - vec_element_loadi(s, dest, a->rs2, 0); + vec_element_loadi(s, dest, a->rs2, 0, false); } else { vec_element_loadx(s, dest, a->rs2, cpu_gpr[a->rs1], vlmax); } --=20 2.17.1