From nobody Mon Feb 9 22:19:52 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1601407235; cv=none; d=zohomail.com; s=zohoarc; b=hqQYP/7heTiina1ODe2ZUypuv0DVCE0IH0xcsO6tYhOnCtQhUYGeNt3o5IjM/fLYjG5972/+Va7kBpNUudYPqe54FbVz3x/p3muEDpgBS1/YvJAAs0DModldWczqeeN6cMsfGfUjr/KeRBPV3WN3AbeoYnDLhsXW4LysvsMIX0E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601407235; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=TdAeKsA5L+s4IiMWzkqm1nibEblXKkWRjjA3AJ5bA5U=; b=YWKvEIYF4EPZyry8YaoUM26JlUrllUiSeFWrPtSmC3xR0rcOA1pGplWj9xCAT7A1WBKWdLuLGASck0utz2GWuBJtIzdngVYHELtuhEWqWAljMgA4MdmaVGNbYbU+JxdJKBEAuFaUYdj/g/7LtXeZkvByjLO695BRwxhjOt6Mpww= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1601407235379653.0223449468973; Tue, 29 Sep 2020 12:20:35 -0700 (PDT) Received: from localhost ([::1]:41322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNLAw-0002HI-4G for importer@patchew.org; Tue, 29 Sep 2020 15:20:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNKxI-0004LV-Na for qemu-devel@nongnu.org; Tue, 29 Sep 2020 15:06:28 -0400 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]:42880) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNKxF-00023K-U2 for qemu-devel@nongnu.org; Tue, 29 Sep 2020 15:06:28 -0400 Received: by mail-pf1-x436.google.com with SMTP id d6so5516124pfn.9 for ; Tue, 29 Sep 2020 12:06:25 -0700 (PDT) Received: from localhost.localdomain (122-116-72-36.HINET-IP.hinet.net. [122.116.72.36]) by smtp.gmail.com with ESMTPSA id v8sm6003950pgg.58.2020.09.29.12.06.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2020 12:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TdAeKsA5L+s4IiMWzkqm1nibEblXKkWRjjA3AJ5bA5U=; b=b5ZszqYTXE8PpSjNsp+kYGiuv1geDDwhIev4bvNlLY536qZ09sz/sl/T/fzs9aV3mc DILOtDIww98xLeRhxgxIw42XzJqhTF+Pn5a/t3rIsiCdeRW51RoetdHnhJJH5xLgFi/i ehqt9L6xe+FuJTRpX8XgZcKxgXFUNKc9GkOvF1iO56fAXkHcmhgk+STY9zXtcCPUUvF6 duGR2INjrV4kiFvBI0CdSlLh19d45GzXJXW5oqZcFGP4vVjQrZT0Lv8Yli0NZDFiT75N YSPOY/Gw7jwuARQueSw8y/aclrLAL5A2bLFSZRe5RKQVXBjqXmNIzRFtbVwQRXkl2QNg miDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TdAeKsA5L+s4IiMWzkqm1nibEblXKkWRjjA3AJ5bA5U=; b=KMIqVglKaJ3ki0azronfu3Mg+kzmqW8Sl+wItAnCiUiux/+lSM7nyQcSMneCBWIS6L NsS9x0UqOh5h2kQ7dB3fzLsjthRhU3Hwf95IpHEKDe6hsK0Bkd9xhYQwLc76l5prVcZ8 a5kmCfHvXSQwKe0dtc2WVYcjvBn74YvLERMIcldWiuEr/DPTMq85PZsV7MKMbsjwsJb5 Ilx4yUQFsSlW3HYakmQwal9Df3GKEjI4lxRofo7sKN/uMGmLfSs982SgqX7IFZ2/Mv9m XU8zOFiqY/BvEEhb0+zl3R/qcmL6wOAZS/9eB3vd3kxP9R9Mp6M1akDAp5RBUTLwKKQk 88qw== X-Gm-Message-State: AOAM531gJgY8awoQbblmXzuYthKr7rb79H19X2bn/iJ6eieZgMvQOxLk sbc2jLxYwGCkSGHy6E1S841v5odihA4tpA== X-Google-Smtp-Source: ABdhPJySXnyWytVeIHHuWbL7lSx+hvYWzOqxJCvSGtes0ftBd+JJ3sBxjKtmC6tGOaYK1O7PP7uT0g== X-Received: by 2002:a63:1226:: with SMTP id h38mr4309113pgl.196.1601406384520; Tue, 29 Sep 2020 12:06:24 -0700 (PDT) From: frank.chang@sifive.com To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Subject: [RFC v5 20/68] target/riscv: rvv-1.0: fix address index overflow bug of indexed load/store insns Date: Wed, 30 Sep 2020 03:03:55 +0800 Message-Id: <20200929190448.31116-21-frank.chang@sifive.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200929190448.31116-1-frank.chang@sifive.com> References: <20200929190448.31116-1-frank.chang@sifive.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::436; envelope-from=frank.chang@sifive.com; helo=mail-pf1-x436.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Frank Chang , Alistair Francis , Palmer Dabbelt , Sagar Karandikar , Bastian Koppelmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Frank Chang Replace ETYPE from signed int to unsigned int to prevent index overflow issue, which would lead to wrong index address. Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/vector_helper.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index 368259f75a..9349a36b41 100644 --- a/target/riscv/vector_helper.c +++ b/target/riscv/vector_helper.c @@ -361,10 +361,10 @@ static target_ulong NAME(target_ulong base, = \ return (base + *((ETYPE *)vs2 + H(idx))); \ } =20 -GEN_VEXT_GET_INDEX_ADDR(idx_b, int8_t, H1) -GEN_VEXT_GET_INDEX_ADDR(idx_h, int16_t, H2) -GEN_VEXT_GET_INDEX_ADDR(idx_w, int32_t, H4) -GEN_VEXT_GET_INDEX_ADDR(idx_d, int64_t, H8) +GEN_VEXT_GET_INDEX_ADDR(idx_b, uint8_t, H1) +GEN_VEXT_GET_INDEX_ADDR(idx_h, uint16_t, H2) +GEN_VEXT_GET_INDEX_ADDR(idx_w, uint32_t, H4) +GEN_VEXT_GET_INDEX_ADDR(idx_d, uint64_t, H8) =20 static inline void vext_ldst_index(void *vd, void *v0, target_ulong base, --=20 2.17.1