From nobody Mon Feb 9 23:14:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=amd.com) ARC-Seal: i=2; a=rsa-sha256; t=1601323669; cv=pass; d=zohomail.com; s=zohoarc; b=g4seGEIVu9cNDunh5a77dfk/uYZYOR0J89sbm40qXYXRAQj/U9n/MYTUIUw4Y0lByRnbsQ0lyj25nk8pochRloQUbt5clWN2toSt85+6RzpjBGs089Y3tuwhP1Fjh5qtURzxzV42FT00ltwAFGG1fJmIkJ4FiBGRZM0H1QDG7+o= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601323669; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+lGCQG8ohaktYqh4DdntmrGbaibr6BlmrS5abSwHzQg=; b=PIow4HqekKYQ91m3X3wSBhEYHrHsPKYbdRp+HD03Sv04Yq4csmsdbOi3dzzVMq1894FzzJG+SkA4RLB5Petgr3pKd6qJShKOJq1nlwoyIvnXdRbe3ZzBTFb1phEskhmSGDwmHHMx0WgfIJTpNXDNHs+LUWAZ7maHuwZIcFoNbSQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=amd.com) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1601323669424805.2221720784462; Mon, 28 Sep 2020 13:07:49 -0700 (PDT) Received: from localhost ([::1]:58912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMzR5-0007iC-Q7 for importer@patchew.org; Mon, 28 Sep 2020 16:07:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMzPS-0006Oj-SJ for qemu-devel@nongnu.org; Mon, 28 Sep 2020 16:06:07 -0400 Received: from mail-mw2nam10on2065.outbound.protection.outlook.com ([40.107.94.65]:7990 helo=NAM10-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMzPP-0006yf-SS for qemu-devel@nongnu.org; Mon, 28 Sep 2020 16:06:06 -0400 Received: from CY4PR12MB1494.namprd12.prod.outlook.com (2603:10b6:910:f::22) by CY4PR1201MB0023.namprd12.prod.outlook.com (2603:10b6:910:1f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.21; Mon, 28 Sep 2020 20:05:26 +0000 Received: from CY4PR12MB1494.namprd12.prod.outlook.com ([fe80::11f9:59c8:16c0:7718]) by CY4PR12MB1494.namprd12.prod.outlook.com ([fe80::11f9:59c8:16c0:7718%8]) with mapi id 15.20.3412.029; Mon, 28 Sep 2020 20:05:26 +0000 Received: from ethanolx56bbhost.amd.com (165.204.78.2) by DM5PR11CA0014.namprd11.prod.outlook.com (2603:10b6:3:115::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.20 via Frontend Transport; Mon, 28 Sep 2020 20:05:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SnWXgHmGXzSTGEc+w8j4VvQMiH2aY9grDpbNqwhLLhVhz3ZQVVBPM95iT0v6BySqxNfpFOHlB4GXBVY8hP8+nd1OyGFfYl9VAu0X2QHxUXrQzYTle+W8je/M6kUG9iEE7QzKszcxInBBRaKA1ad67KTA4E8svBd7p2KEuKKamM2EfzAbyE5qlxYKIzpMh5TktAFV8vpijyyEAaYWQmw9a+zuPUdMm/mxF9uipdCIpBLPUXY9CYscg4+BElzbGLvk2hZtga8HF8kV9bs3bjcHH81kzZl1MZMLk28TKbdGet04yI1hF373U4d8/0GWG4pLWphVxKbMj26NNkn3wrYTOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+lGCQG8ohaktYqh4DdntmrGbaibr6BlmrS5abSwHzQg=; b=CtXy/sFxBMNtX5q6IynBTXCrMR0cC5z/9FbI3kfU2ro0qNs8HEK6y2uN+3b3VlYgqUat7qCOZR97pWPAoaoaoQaxfvbNEx4cm4SdmmnYjQqkkX0jqo2qy9wDohEbxYX982uFh3ZmJndXtByyDrlEl5MlNoQUFQhJiyBla40vjLSB1bSgFOgwO3K+VWBnWgF3aomBzJmlbIeTtzxg/0vI57ELvQD3KzvVnHpqd7ryHzTDHxeLLcK5r5zYpRULDcvJql7pVtcy/tewXibv+TUKlQQScihgDa9JWhWlxh4sOpBmURTE/L8atBRbWuCTAiJAN0MnYBrc4dT1hc8swGGPFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+lGCQG8ohaktYqh4DdntmrGbaibr6BlmrS5abSwHzQg=; b=GSU3/lV6ZT+U5kL5exerUmJ6ZJrPcaO0JZxeR64I1qZ8Vdo/UoO8B3nxYOgPcabQyfSBq5zvs3MAD39Pp/0iLXoQJHvcFWjdufR7mVZ4RstGvAT7AipiX9Gj+fhPwogLfIDgHIfzh1MgRdrYTpVFaBDR5dD91J+lYPTdLIOrpXs= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=amd.com; From: Wei Huang To: qemu-devel@nongnu.org Subject: [PATCH V1 1/3] amd-iommu: Add address space notifier and replay support Date: Mon, 28 Sep 2020 15:05:04 -0500 Message-Id: <20200928200506.75441-2-wei.huang2@amd.com> X-Mailer: git-send-email 2.25.2 In-Reply-To: <20200928200506.75441-1-wei.huang2@amd.com> References: <20200928200506.75441-1-wei.huang2@amd.com> Content-Transfer-Encoding: quoted-printable X-Originating-IP: [165.204.78.2] X-ClientProxiedBy: DM5PR11CA0014.namprd11.prod.outlook.com (2603:10b6:3:115::24) To CY4PR12MB1494.namprd12.prod.outlook.com (2603:10b6:910:f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4946a599-834f-4fc4-db9d-08d863e9d733 X-MS-TrafficTypeDiagnostic: CY4PR1201MB0023: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:415; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TcqEX/7ffe/9I+gGNDWSw2wRUzjxWqimXWjFJdcKsQ5w1CFYK2EWzg6N6SbQ1xOPIzjQraLYuNh18Sw1S1eKgPeGtXsZGST7DhLpdNPGTWtw8bfyH7c6Rk/hHCT5+d4u5N8l3AqH5jkUIaO+gws4y7y4weQCQBTFtATCvWaOd41YmmpElslsCusZmc3vE0BoMx/i3YZlLmx+jXqqiBygCHnFtHRaYOd3+WCKjMqclHgcVDGHJ36MyefM+YI4VrCWNGZbGzF/tuRefsy5X81ggCr3wsDIWA55Tray9iCH7XUQTLL5fv/PEOhMZA3skrfrUszzpGzbfcy854jRQXdz7QUP9ZKpPK/ubgbHVj7fBTnpd3pH8QL+ntH11Nu330vi X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR12MB1494.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(376002)(346002)(396003)(136003)(6486002)(4326008)(316002)(2906002)(8676002)(86362001)(8936002)(6666004)(478600001)(16526019)(5660300002)(186003)(26005)(1076003)(6916009)(83380400001)(66946007)(2616005)(52116002)(7696005)(66476007)(956004)(36756003)(66556008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: LjdDq0yUkLYjk0MTFqinzhJaVIZIc8OCMFqS+FWvzgZyaFFW8zXhLkLwx8/9hNroRyvovvh94k2v0fA3WoRz7UglDiTy0cjpC9VYHcOQvJcAHL58Ee3EHrH5qdHrnulst3sqvhnkwIE74L4MlAb+jTmZKjvsFjsDiO9TFeNa5rsYuVCL1DrSsEipk9BmOeNKa3EpD7F430Iu9IvmAiZqMnOTQR8jd2R6X6OOPKPOlni4/bimYqU8lb5P72k+xjj/PssqVRypkCNGnjAm1lxz40zi3lhwaCdUgKwjM1+PkOcQBEa5Kl4bGBobteTfx84vp5L8XO7wItnJnB2x+7mSbhx9i6ceANeVyuXYyoNi2x0XS3PlW5ZFgPyWmCNwBx/V6xITzVuMeTnl1pwzM9ecI2tkpbsEmRm7VT2dSWo21dxemP2Kef7DjXDNygF9GPXMSzydGDvntPswM7gBAzmNvCJjXokXyL1X7HyFuOCQjQGFSdBIomwy+wa2pTWsl5zuMMvYC6/YeTThuYsgcDgHvmaX7N48g5ZGW23Kh33dbbNVY3hh7+eIekcN5+Tw3Q7OQZvf8SNwlMbp4C29+DXu6HD0kzXd2gfB7M7fD2hK8A5ROB3kapDjU1e1uSeo+FXQZrm1B/A6bafmu88IaPbYBg== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4946a599-834f-4fc4-db9d-08d863e9d733 X-MS-Exchange-CrossTenant-AuthSource: CY4PR12MB1494.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2020 20:05:26.4863 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8PO+FZA5i4gPVUqM9eG/UePMMfvi1m70SGmpGpRiikbROzAvDqtnhiwk6xVwgjav X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0023 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=40.107.94.65; envelope-from=Wei.Huang2@amd.com; helo=NAM10-MW2-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/28 16:06:01 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FORGED_SPF_HELO=1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.614, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ehabkost@redhat.com, mst@redhat.com, wei.huang2@amd.com, peterx@redhat.com, alex.williamson@redhat.com, pbonzini@redhat.com, Suravee.Suthikulpanit@amd.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @amdcloud.onmicrosoft.com) Content-Type: text/plain; charset="utf-8" Currently the emulated amd-iommu device does not support memory address space notifier and replay. These two functions are required to have I/O devices supported inside guest VMs as passthru devices. This patch adds basic as_notifier infrastructure and replay function in amd_iommu. Co-developed-by: Wei Huang Signed-off-by: Suravee Suthikulpanit --- hw/i386/amd_iommu.c | 45 +++++++++++++++++++++++++++++++++++++++------ hw/i386/amd_iommu.h | 3 +++ 2 files changed, 42 insertions(+), 6 deletions(-) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index 74a93a5d93f4..c7d24a05484d 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -63,6 +63,8 @@ struct AMDVIAddressSpace { IOMMUMemoryRegion iommu; /* Device's address translation region */ MemoryRegion iommu_ir; /* Device's interrupt remapping region */ AddressSpace as; /* device's corresponding address space */ + IOMMUNotifierFlag notifier_flags; /* notifier flags of address space */ + QLIST_ENTRY(AMDVIAddressSpace) next; /* notifier linked list */ }; =20 /* AMDVI cache entry */ @@ -425,6 +427,22 @@ static void amdvi_inval_all(AMDVIState *s, uint64_t *c= md) trace_amdvi_all_inval(); } =20 +static void amdvi_address_space_unmap(AMDVIAddressSpace *as, IOMMUNotifier= *n) +{ + IOMMUTLBEntry entry; + hwaddr start =3D n->start; + hwaddr end =3D n->end; + hwaddr size =3D end - start + 1; + + entry.target_as =3D &address_space_memory; + entry.iova =3D start; + entry.translated_addr =3D 0; + entry.perm =3D IOMMU_NONE; + entry.addr_mask =3D size - 1; + + memory_region_notify_one(n, &entry); +} + static gboolean amdvi_iotlb_remove_by_domid(gpointer key, gpointer value, gpointer user_data) { @@ -1473,14 +1491,17 @@ static int amdvi_iommu_notify_flag_changed(IOMMUMem= oryRegion *iommu, Error **errp) { AMDVIAddressSpace *as =3D container_of(iommu, AMDVIAddressSpace, iommu= ); + AMDVIState *s =3D as->iommu_state; =20 - if (new & IOMMU_NOTIFIER_MAP) { - error_setg(errp, - "device %02x.%02x.%x requires iommu notifier which is n= ot " - "currently supported", as->bus_num, PCI_SLOT(as->devfn), - PCI_FUNC(as->devfn)); - return -EINVAL; + /* Update address space notifier flags */ + as->notifier_flags =3D new; + + if (old =3D=3D IOMMU_NOTIFIER_NONE) { + QLIST_INSERT_HEAD(&s->amdvi_as_with_notifiers, as, next); + } else if (new =3D=3D IOMMU_NOTIFIER_NONE) { + QLIST_REMOVE(as, next); } + return 0; } =20 @@ -1573,6 +1594,8 @@ static void amdvi_realize(DeviceState *dev, Error **e= rrp) /* Pseudo address space under root PCI bus. */ x86ms->ioapic_as =3D amdvi_host_dma_iommu(bus, s, AMDVI_IOAPIC_SB_DEVI= D); =20 + QLIST_INIT(&s->amdvi_as_with_notifiers); + /* set up MMIO */ memory_region_init_io(&s->mmio, OBJECT(s), &mmio_mem_ops, s, "amdvi-mm= io", AMDVI_MMIO_SIZE); @@ -1631,12 +1654,22 @@ static const TypeInfo amdviPCI =3D { }, }; =20 +static void amdvi_iommu_replay(IOMMUMemoryRegion *iommu_mr, IOMMUNotifier = *n) +{ + AMDVIAddressSpace *as =3D container_of(iommu_mr, AMDVIAddressSpace, io= mmu); + + amdvi_address_space_unmap(as, n); + + return; +} + static void amdvi_iommu_memory_region_class_init(ObjectClass *klass, void = *data) { IOMMUMemoryRegionClass *imrc =3D IOMMU_MEMORY_REGION_CLASS(klass); =20 imrc->translate =3D amdvi_translate; imrc->notify_flag_changed =3D amdvi_iommu_notify_flag_changed; + imrc->replay =3D amdvi_iommu_replay; } =20 static const TypeInfo amdvi_iommu_memory_region_info =3D { diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h index fa5feb183c03..aeed9fd1cbb0 100644 --- a/hw/i386/amd_iommu.h +++ b/hw/i386/amd_iommu.h @@ -364,6 +364,9 @@ struct AMDVIState { /* for each served device */ AMDVIAddressSpace **address_spaces[PCI_BUS_MAX]; =20 + /* list of registered notifiers */ + QLIST_HEAD(, AMDVIAddressSpace) amdvi_as_with_notifiers; + /* IOTLB */ GHashTable *iotlb; =20 --=20 2.25.2