From nobody Fri May 17 18:57:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601297952; cv=none; d=zohomail.com; s=zohoarc; b=iJTsB1pqNRHPHrPgnIUNwv2yX/641SLAuvpIoy3tX33mxfkxlOilqwEnkmfK0sSY0WHeaV0Ibr7pyZAgi6HzTGkaqEkEp2faF2bY4zp15VAB1VgAllrGEaf4Sz/z6oTbDC22VP9lbFcrrlis5Z/TuC2NdXHcO3KWzfWnfAbN8CQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601297952; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=bU29bJZTMasQeNNiJs3vBtDqyXAGJWgpUOEt6l9XHtE=; b=eIkvmgwnNlR7up52XRuLOyStBPoPhDNxj8CBTVKiCBQMbPp2eHdGlvwcSBNeXmlUGfswAE1FtHs6K/MyM5hixAW1zgAeLm359cuH0k9A9MxEAFP6ZlHkixIx6OAd8BZsJ7uu1HTFhZ9smjWzJr/K+vRbJQu4pNLMRrA+TZ1awPM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1601297952068203.3224095905665; Mon, 28 Sep 2020 05:59:12 -0700 (PDT) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-2-rHqMzCIsMoOuK8frVriTQQ-1; Mon, 28 Sep 2020 08:59:09 -0400 Received: by mail-wm1-f72.google.com with SMTP id x6so361418wmi.1 for ; Mon, 28 Sep 2020 05:59:08 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (74.red-83-53-161.dynamicip.rima-tde.net. [83.53.161.74]) by smtp.gmail.com with ESMTPSA id d19sm996387wmd.0.2020.09.28.05.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2020 05:59:06 -0700 (PDT) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601297950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bU29bJZTMasQeNNiJs3vBtDqyXAGJWgpUOEt6l9XHtE=; b=BC75JjSZ5lYHl9BVMcvNEjY7HRJHJYy7e80hK6W96AFsCh9rzMh6woSnK3Ly8DbufooicU ISK7xq8Zi8lIH4jIMm1Sls0oPf/cqLUp/s/j6le+ovmwijn6jEWmU572QFRICuVHLDoQqZ 36vDqVPB3+NU7/Uolv7IriMxlJGN0ik= X-MC-Unique: rHqMzCIsMoOuK8frVriTQQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bU29bJZTMasQeNNiJs3vBtDqyXAGJWgpUOEt6l9XHtE=; b=KHHabuBbhtrmhoJ231wD87J5OvVeLJUb46D0idZoX8jforW7r6IBVWzn/sUP/5SV48 BxciqGC2E/QHsk7kwGxn6k5LFgdOFt3ZKSflbYCm0ij/5bOuluYDqvtImtnIbihUKdma jr3ZWqyYaQc41+QrYPA0yxyIvM7FOFaUGqXJhgCt09evb2jM1j8Feyyfk9NTIyAlvciN 8Q0cUJuJeXUBUAZ1MDk9UuzjtdvzIhrfpjW99NbBn+NCY5YMhqoQHvn4gTOn2fe6IUSB NIjmXL1xLVheRf1rCgW69prkbDZHL9hOo6RS4cSfsg8Sy78Hi5K65jKAx55dFgPZsLrU NT0g== X-Gm-Message-State: AOAM531ToSy8ioQcE3WJ3qi8gCx7VSG+qYoWN+a7NRbiYWiskdOl9Z6m DuyN0X6K0R8tg1HuED5c8EIbdYY/SArD6i+98g90bI1s66O+oA+QvpsDOXbU65qA2mrKVZW4LpK KcrY14/PtRsYyhA== X-Received: by 2002:a05:6000:124d:: with SMTP id j13mr1702596wrx.182.1601297947711; Mon, 28 Sep 2020 05:59:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwHP9xoNeu6jyrNE81jWruhebydXnrMPVCLnP0CexOt3GmUwsUBAtmmDtx1HP6Vjschk7wS7g== X-Received: by 2002:a05:6000:124d:: with SMTP id j13mr1702580wrx.182.1601297947495; Mon, 28 Sep 2020 05:59:07 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Paolo Bonzini , Richard Henderson , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf' Date: Mon, 28 Sep 2020 14:58:57 +0200 Message-Id: <20200928125859.734287-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200928125859.734287-1-philmd@redhat.com> References: <20200928125859.734287-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Since commit efc6c070aca ("configure: Add a test for the minimum compiler version") the minimum compiler version required for GCC is 4.8, which supports the gnu_printf attribute. We can safely remove the code introduced in commit 9c9e7d51bf0 ("Move macros GCC_ATTR and GCC_FMT_ATTR to common header file"). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/qemu/compiler.h | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h index c76281f3540..207e3bd4feb 100644 --- a/include/qemu/compiler.h +++ b/include/qemu/compiler.h @@ -104,17 +104,14 @@ sizeof(QEMU_BUILD_BUG_ON_STRUCT(x))) =20 #if defined __GNUC__ -# if !QEMU_GNUC_PREREQ(4, 4) - /* gcc versions before 4.4.x don't support gnu_printf, so use printf. */ -# define GCC_FMT_ATTR(n, m) __attribute__((format(printf, n, m))) -# else - /* Use gnu_printf when supported (qemu uses standard format strings). */ -# define GCC_FMT_ATTR(n, m) __attribute__((format(gnu_printf, n, m))) -# if defined(_WIN32) - /* Map __printf__ to __gnu_printf__ because we want standard format st= rings - * even when MinGW or GLib include files use __printf__. */ -# define __printf__ __gnu_printf__ -# endif + /* Use gnu_printf when supported (qemu uses standard format strings). */ +# define GCC_FMT_ATTR(n, m) __attribute__((format(gnu_printf, n, m))) +# if defined(_WIN32) + /* + * Map __printf__ to __gnu_printf__ because we want standard format str= ings + * even when MinGW or GLib include files use __printf__. + */ +# define __printf__ __gnu_printf__ # endif #else #define GCC_FMT_ATTR(n, m) --=20 2.26.2 From nobody Fri May 17 18:57:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601297964; cv=none; d=zohomail.com; s=zohoarc; b=MnWtwRhbXSCbsSL1dXiwep2NhQ307brYnKDq3Nq/ihUrbj+c/6NK1QpiBRucVvs2Lv/agUJeLe6+ofhjbRlyp6YlZlHR6TXfY1vOx13/zq10wAg1l2MoSkgOfKIfcobu/hP337ezfsHttMQA9JtcH9+ugv5oPw+DMEzUTlkJYkw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601297964; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=v6PGjLSw3kSK6ARw73eSqwNVErLiz9tgI0uJe1vk+sQ=; b=j6Fw/nWXoOW473gMNv2SkeWhJVAVuNGyOL2H6rn30pqtT27T+oHpTmQbwtRpfIVbh15medQobpwKe3RB/ZCMHeZ9GIdD0y1RU4EYezwl8ERw66BOG8L/1ogqnmL4I4/Lg/xrpwi1Zsje1cjM8EVEvBdEKWjlHyBJ31MH98RoY1o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1601297964107858.2791745083554; Mon, 28 Sep 2020 05:59:24 -0700 (PDT) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-94-eUDN1RHiNKOrwK90LQlfkA-1; Mon, 28 Sep 2020 08:59:14 -0400 Received: by mail-wm1-f71.google.com with SMTP id x6so361496wmi.1 for ; Mon, 28 Sep 2020 05:59:14 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (74.red-83-53-161.dynamicip.rima-tde.net. [83.53.161.74]) by smtp.gmail.com with ESMTPSA id c16sm1502529wrx.31.2020.09.28.05.59.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2020 05:59:12 -0700 (PDT) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601297962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v6PGjLSw3kSK6ARw73eSqwNVErLiz9tgI0uJe1vk+sQ=; b=b3CaFbQCUMzLY/AmvVu9OUV5kePL74Pl8NgTx5JQ6wHTSVdOr0LqQr1z77hVDXSM3ZIdMS 9J53ucofxCl6tAdELDAfdpetnmMBW9MHjJsaM4/d4MSNtrVBBo4gE/bSRe4VbAjBEsKivx Z6toUdAiJWx4aVarnsVcZnXHJ3xse4Y= X-MC-Unique: eUDN1RHiNKOrwK90LQlfkA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v6PGjLSw3kSK6ARw73eSqwNVErLiz9tgI0uJe1vk+sQ=; b=TRY7YWBvzBzVT91iNrUp3db3G0kFZFpGOSDeYui4lSHr+XxKbmyhcqh4o20txVDxaP SmNJDbHSi9ovHF9HdrCm0Xl9+WF5uL3FEfTjSKWcg2hvMy3Bjs/DIg/jAfMvyTSnoVJ5 4UHNCfZE2Cv655RLvVpUnAY6MuTx+R7U8xY5ZOxcpB+RSWHAhi68v5YHD0LdD0btrrRs uUC8birhlMom8aPu8EcRCytFf0/efdY6/UXnwYybZrcwRlUtJzOZKRgKoVz2fJx7EfIY jM+JXiEaRR8+VOepDvy+r4BZTIWDK29EqUC2Et4nC/bt9c+ZneI48QNAVZNQXJtIqPwT ehDA== X-Gm-Message-State: AOAM530FQSGIgtdWPyP6q4kLs6QFfO9sDp0DbycJnFVCCMIUv60WlD2S AwLgMYuwe4K1xDH5NhKNdLCxBVpEOXfRdLYTSeHbDyKyYj7SlW9OClePbu7ONdjWAsMXBEEJMNC 1H4mhk2pl475SWQ== X-Received: by 2002:adf:fd12:: with SMTP id e18mr1677851wrr.96.1601297953012; Mon, 28 Sep 2020 05:59:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy51qV0gl8YBMCmmGG7e3hY0ATWkyT+tJ+uJmjlEfM2JwyBMN36ZcpD7qVM0V/bebKJrKynpA== X-Received: by 2002:adf:fd12:: with SMTP id e18mr1677831wrr.96.1601297952846; Mon, 28 Sep 2020 05:59:12 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Paolo Bonzini , Richard Henderson , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/3] qemu/atomic: Drop special case for unsupported compiler Date: Mon, 28 Sep 2020 14:58:58 +0200 Message-Id: <20200928125859.734287-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200928125859.734287-1-philmd@redhat.com> References: <20200928125859.734287-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Since commit efc6c070aca ("configure: Add a test for the minimum compiler version") the minimum compiler version required for GCC is 4.8, which has the GCC BZ#36793 bug fixed. We can safely remove the special case introduced in commit a281ebc11a6 ("virtio: add missing mb() on notification"). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- include/qemu/atomic.h | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h index c1d211a3519..8f4b3a80fbd 100644 --- a/include/qemu/atomic.h +++ b/include/qemu/atomic.h @@ -241,23 +241,6 @@ =20 #else /* __ATOMIC_RELAXED */ =20 -/* - * We use GCC builtin if it's available, as that can use mfence on - * 32-bit as well, e.g. if built with -march=3Dpentium-m. However, on - * i386 the spec is buggy, and the implementation followed it until - * 4.3 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D36793). - */ -#if defined(__i386__) || defined(__x86_64__) -#if !QEMU_GNUC_PREREQ(4, 4) -#if defined __x86_64__ -#define smp_mb() ({ asm volatile("mfence" ::: "memory"); (void)0; }) -#else -#define smp_mb() ({ asm volatile("lock; addl $0,0(%%esp) " ::: "memory"= ); (void)0; }) -#endif -#endif -#endif - - #ifdef __alpha__ #define smp_read_barrier_depends() asm volatile("mb":::"memory") #endif --=20 2.26.2 From nobody Fri May 17 18:57:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601297962; cv=none; d=zohomail.com; s=zohoarc; b=TH8UbLtK0/qHJjA1zuByAUDhQX4UXOHtEcdJ4KDU56yIWfYWyt/wd9jRog9M3kmzeHxMHn/VZ9dV5A494Jph15PM9eCC/87iwXRn425yaNFuIxGSmx5aO3QVgGavIIUolv+ZS/iG6fyPjPwEqPE8crDL+EgUoUz0N+DDdo5PxqM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601297962; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=lNLoWuf3VWBMLbz8iFaGpHLsud63gIf1tGgS+8bafOY=; b=fgHrbyOE9OJxECHaTDVUhPJWi/h6EsZVIa8QBoaQ9uq7S7DzZKs0u1Pkn+/KSUUReuEvGqJRyOh9Ca0B8Ik7ITREeQNNSuztrBYmJmUO4WabCEBvwfTwMTPUc8xVRwh/RGzd3QAZUbcsyipDpQgHMHeQ64mFmqrz5CiGMmxbQNg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1601297962522291.2404394638261; Mon, 28 Sep 2020 05:59:22 -0700 (PDT) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-230-X6IYOQ3GPaOzhf-R0XPrvA-1; Mon, 28 Sep 2020 08:59:19 -0400 Received: by mail-wm1-f72.google.com with SMTP id l26so318117wmg.7 for ; Mon, 28 Sep 2020 05:59:19 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (74.red-83-53-161.dynamicip.rima-tde.net. [83.53.161.74]) by smtp.gmail.com with ESMTPSA id h204sm1227917wmf.35.2020.09.28.05.59.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2020 05:59:17 -0700 (PDT) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601297961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lNLoWuf3VWBMLbz8iFaGpHLsud63gIf1tGgS+8bafOY=; b=AYgFVU8JRVl+5HPS1Dtlc9sB+d0XXxBX4Dt7ZLzQwUinQOaXKU6ZKtNM0U/I7e3fwayq2N XQ4p39nixTqQ1re6y3CG6hp1SwFc9Qd0kNa+ecU0GTdRyJi+vxmj8JAK4qM5aTKx0+bDY0 P/kegB7KDrM/7UnxShE7VNjwGsMb5lg= X-MC-Unique: X6IYOQ3GPaOzhf-R0XPrvA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lNLoWuf3VWBMLbz8iFaGpHLsud63gIf1tGgS+8bafOY=; b=p79e3TrBZ3eIITkOKKc4rh90m3CxCStjNzQtO3g2SwbT2oxwi3/7D423lXqFqd9W5l u2kKUhtjHreZWOJYXw70ZY3zTGBsIxzgeh+i3iT7Umqp0p+JcGgrFw/tvSpI+RHBxUdh OjpTpj9DOUovkxatPogZG9jz2MzDq6peZlE9v9EFqaBW/iQkI26Tx0RN9E+VRNHfo6Sa 0A2c6Mztj+VCHbJ0nh42P2/mmbZv5jQ0JTGAm5LCZy6lMwsxaJwtRxOmUp6eu7IE+bGx oQJe97uQOOtHtUaXqOZxzKpcQk5+RB4pQVfqwNbxpIreAAXe9TBfrYyua2yeRROef+sF kXCQ== X-Gm-Message-State: AOAM530otNIhWnpsG7zg17uIe8eZbIsU+HG+ZLBE4KgNH17CDFf4OPN2 aRh1xn4XytQAqbN59eItblkinwpuoS9oOz0Vw5RQha2+m/V5ccRu3j5r5vJDMzyz2t8t9cFL1Sp MTgfYC1aE+262nQ== X-Received: by 2002:a5d:5602:: with SMTP id l2mr1710767wrv.410.1601297957999; Mon, 28 Sep 2020 05:59:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0Dv01edvAvpJmhJDT9ncCo9xT2GQjpsNpprD/jVFhfQiV2PfWTdwUtIcF6CUX0ulciThpQg== X-Received: by 2002:a5d:5602:: with SMTP id l2mr1710753wrv.410.1601297957839; Mon, 28 Sep 2020 05:59:17 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Paolo Bonzini , Richard Henderson , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/3] accel/tcg: Remove special case for GCC < 4.6 Date: Mon, 28 Sep 2020 14:58:59 +0200 Message-Id: <20200928125859.734287-4-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200928125859.734287-1-philmd@redhat.com> References: <20200928125859.734287-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Since commit efc6c070aca ("configure: Add a test for the minimum compiler version") the minimum compiler version required for GCC is 4.8. We can safely remove the special case for GCC 4.6 introduced in commit 0448f5f8b81 ("cpu-exec: Fix compiler warning (-Werror=3Dclobbered)"). No change for Clang as we don't know. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell --- accel/tcg/cpu-exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index e10b46283cc..bf149bb824e 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -703,7 +703,7 @@ int cpu_exec(CPUState *cpu) =20 /* prepare setjmp context for exception handling */ if (sigsetjmp(cpu->jmp_env, 0) !=3D 0) { -#if defined(__clang__) || !QEMU_GNUC_PREREQ(4, 6) +#if defined(__clang__) /* Some compilers wrongly smash all local variables after * siglongjmp. There were bug reports for gcc 4.5.0 and clang. * Reload essential local variables here for those compilers. --=20 2.26.2