From nobody Sun Nov 16 18:48:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.67 as permitted sender) client-ip=209.85.221.67; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f67.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.67 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1601197707; cv=none; d=zohomail.com; s=zohoarc; b=GYWkHt/rgb+8xgxeGCM2vCG9cnUgzA8rkZJQ417GPRaPHPjELS51J7HbV9+0DfiB5Q1dxMj5c2QlH6c719O4pEkN7i2zQskXIXq1eOAMM/vMOD2wktPqFSoFcCf9waF5QZYsm283sr2szTnpLsioPkDl5iAjrANXWRy+stO5vi0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601197707; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=g/6nKkvgWnq0c/AG8DfCxF9NNLJNAWyxVfnfIeVT6t8=; b=NXoU5x9z0Bgy7Y0zCLQ4Iwr53Wdc5nnzs9mjNBxCP23FuJAZIKXaO9mIk6N/xqqYyljfip+zT2nPpuidS8tgDgt41ZRmOZf+fDAG2mHk+ckfglvXH5QkjOZrAXZh1V/9KH7tbjO21RhP0wfRJzlq4EHiwEJZCXwqnUljIeVBlLU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.67 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.zohomail.com with SMTPS id 1601197707492382.07826573256; Sun, 27 Sep 2020 02:08:27 -0700 (PDT) Received: by mail-wr1-f67.google.com with SMTP id x14so8350517wrl.12 for ; Sun, 27 Sep 2020 02:08:26 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (74.red-83-53-161.dynamicip.rima-tde.net. [83.53.161.74]) by smtp.gmail.com with ESMTPSA id y6sm9007187wrn.41.2020.09.27.02.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2020 02:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g/6nKkvgWnq0c/AG8DfCxF9NNLJNAWyxVfnfIeVT6t8=; b=mdPBjNfcPkLfBgSUQeZDh+mxzVmtg/H2GK1HTBzqmcprES/nCEsPACKP5l4ISdbrH5 mdJK4dtnR8oPAl3om5xjhlnGb+44+fppxFf23MQuZarjg1blWGecIZOwlXxqeXnU02rs zvOMlCgQsuM2EbGH5GwqmjLTwrGWczShSFvVleovAQsHo5aHLhEx8qbla3uexYANv316 3nRlSfdvCoVgYInxlbt8ufDfCG/mUmZZOl9pmKhOGvcXYTRKso1L3wnDMEa79m7Wvlxi J94k1DA9MXHMEpZ5PebOaooBdQV9xMnHctXe+mgCRKBmpVGoY5/s4D3dF+7smpJFX0XR Hh/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=g/6nKkvgWnq0c/AG8DfCxF9NNLJNAWyxVfnfIeVT6t8=; b=ioakjzvKnDXcqaokQTGh6mYXGBfAXK+t+z5GZhtWb1a0DE+pj5kb72DemEDt80NBWO bPiB3XkA2S1KIXuMDI6PcRISk/+y7INKqxqiDFIh8q5W6B3MxKGNDG5ECVo8jaA+JJ38 GhX2RwV4MZrnsnAlH67LzCJfZfWAjpEShY9roNf8w439gh9FmRn1/h1gJoUx4jsgyeRx wusFfHlBZlEAaWWDPGlV+S31Rc89mOriNHFHhHiA+XRiw0dJ4JF/HD5tQVIDNu/qM4d4 +ObZKKZTdgsyLpTkjL1mwafrbvMCNZMNVPPekTVJdzzabogXn5A4C2ieIo06JsyutZdI Lj2A== X-Gm-Message-State: AOAM530aPBgGoqLdM0P2AYEqzQQX8TAVcv/BBLo1H3aB5P5IXR/C4SHx QoBYmbvaieePY8oBvBRiAE8= X-Google-Smtp-Source: ABdhPJzKaiDMaImaZToR7YXr9MEBSOLaHTuNCojcQODEJemcetZXMiWfa4KQ0h8DDEwJihbqbSoUjw== X-Received: by 2002:a5d:4d01:: with SMTP id z1mr13010243wrt.366.1601197705256; Sun, 27 Sep 2020 02:08:25 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Tyrone Ting , Alistair Francis , Eduardo Habkost , Luc Michel , Damien Hedde , "Edgar E . Iglesias" , Havard Skinnemoen , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 2/3] qdev-monitor: Display frequencies scaled to SI unit Date: Sun, 27 Sep 2020 11:08:19 +0200 Message-Id: <20200927090820.61859-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200927090820.61859-1-f4bug@amsat.org> References: <20200927090820.61859-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Since commit 9f2ff99c7f2 ("qdev-monitor: print the device's clock with info qtree") we can display the clock frequencies in the monitor. Use the recently introduced freq_to_str() to display the frequencies using the closest SI unit (human friendlier). Before: (qemu) info qtree [...] dev: xilinx,zynq_slcr, id "" clock-in "ps_clk" freq_hz=3D3.333333e+07 mmio 00000000f8000000/0000000000001000 After: dev: xilinx,zynq_slcr, id "" clock-in "ps_clk" freq_hz=3D33.3 MHz mmio 00000000f8000000/0000000000001000 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Damien Hedde Reviewed-by: Luc Michel --- qdev-monitor.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index e9b7228480d..a0301cfca81 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -747,11 +747,13 @@ static void qdev_print(Monitor *mon, DeviceState *dev= , int indent) } } QLIST_FOREACH(ncl, &dev->clocks, node) { - qdev_printf("clock-%s%s \"%s\" freq_hz=3D%e\n", + g_autofree char *freq =3D NULL; + + freq =3D freq_to_str(clock_get_hz(ncl->clock)); + qdev_printf("clock-%s%s \"%s\" freq_hz=3D%s\n", ncl->output ? "out" : "in", ncl->alias ? " (alias)" : "", - ncl->name, - CLOCK_PERIOD_TO_HZ(1.0 * clock_get(ncl->clock))); + ncl->name, freq); } class =3D object_get_class(OBJECT(dev)); do { --=20 2.26.2