From nobody Sun Nov 16 16:31:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) client-ip=209.85.128.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1601197705; cv=none; d=zohomail.com; s=zohoarc; b=KkXh9XS/PgP+nxzUERWwl3ReAAof6g0GjEXI9C3Mwpq6PyzFtSmyTBza3B35eFwzVfjGaXgIEMyqZzogkuXSzNyYA2LTPMS1C2nD8Wa4PY1a2FIVudEUbrk9knLHB7dLWj/voKEhMGMlIxXbt8wCUC95tPkhM5QQePB0k9Zq17Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601197705; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gSWJZnKhOrC53eEU7BCKaT5VT2GqivKC/fTv2rJCfmw=; b=VN6Mq5ZVnP+FGsOpSIUCvjbZrNYgbHfSwNuGu6gJYfZm6VwivOyESTbN17DuSM66oikilYuRp+1+yJRa3jyLtv60SGJpVjYEPIOmnmXRnhEm0K/msqf3QCf2Exm2LAiF9qgrSkiSh8IopsTMSIHUpLYTpy11bGexsMf///5jVKs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mx.zohomail.com with SMTPS id 1601197705859425.062861715448; Sun, 27 Sep 2020 02:08:25 -0700 (PDT) Received: by mail-wm1-f50.google.com with SMTP id s13so3349116wmh.4 for ; Sun, 27 Sep 2020 02:08:25 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (74.red-83-53-161.dynamicip.rima-tde.net. [83.53.161.74]) by smtp.gmail.com with ESMTPSA id y6sm9007187wrn.41.2020.09.27.02.08.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2020 02:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gSWJZnKhOrC53eEU7BCKaT5VT2GqivKC/fTv2rJCfmw=; b=X5WvMunjUsLtd2mptGhZleNmCFMuZ4w7XejQhfK2oyhGIpeC+BchQD4w8YwsF/wILH O1nqo6JcAGIOORTxzHo5WsaA0XONqTOTA77relREpEfXsje6Xh/qrtVEgbwLnDxkNkye begFE2y963So5IYztpwkv5z5D2bn2JKEM2M2eOcvr5E+lIzd+wx1maz/F1ftgan9uRv+ ysv3cEECIW2LnX6eME5yeKwE+Pxf+ZPoFIc6mtuVgsj3lUq04a09uvFpT/K6nIEv7axG stzyQkPIfoxXe9NXt8IhgG6tytG+SYx61SL29sxSVmI0zi9lJ9WLdJdXfz6PMd7ibMuz 3JRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=gSWJZnKhOrC53eEU7BCKaT5VT2GqivKC/fTv2rJCfmw=; b=FYDQEDVU2QXmV8KYNXetFHuahpsQo7Us6479AQHBft7dVbHJVHxRi/WNfZe5nb6oHK xU1Rrpm6dP91XiP79gRDjQLevoLxnL5r9lXOeHboIbtazpW/ElmEVWmkIhZot0u+imOD Hv1vUG/sT1MykCnGWV1t4+wHGOyHFPkc+BRX8r1YGU0c1047ifA5QcjcyVO92GGxHND1 YS94NamtJyVYoQ/Ldbqb+v40QJ/0jb7vt0M3ZBITYSn+0ksbyXg955PkpN90aZGA8VxN jhnRSPYRbbIipw7Tzyljh4JPci3tMmFQEt4i/YBzPhjFbSl/SsmaFN+ntvU5x43etMuP ZECw== X-Gm-Message-State: AOAM532zxEb2iW2w/K+yKxZ2q66W9NGJInNnmKdnZZWHC9kGk2Op9z2z 6UVUPs4idfjBKOVxzK0JHcA= X-Google-Smtp-Source: ABdhPJwGxE71rID2mFA3DEuK+vzDWzKrydocZuPZ2wGQitxZ8AgaDXRVy2kjMCPnlkwSvJiegrpvew== X-Received: by 2002:a1c:7911:: with SMTP id l17mr6084925wme.179.1601197703999; Sun, 27 Sep 2020 02:08:23 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Tyrone Ting , Alistair Francis , Eduardo Habkost , Luc Michel , Damien Hedde , "Edgar E . Iglesias" , Havard Skinnemoen , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/3] util/cutils: Introduce freq_to_str() to display Hertz units Date: Sun, 27 Sep 2020 11:08:18 +0200 Message-Id: <20200927090820.61859-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200927090820.61859-1-f4bug@amsat.org> References: <20200927090820.61859-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Introduce freq_to_str() to convert frequency values in human friendly units using the SI units for Hertz. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/qemu/cutils.h | 12 ++++++++++++ util/cutils.c | 10 ++++++++++ 2 files changed, 22 insertions(+) diff --git a/include/qemu/cutils.h b/include/qemu/cutils.h index eb59852dfdf..0186c846e9c 100644 --- a/include/qemu/cutils.h +++ b/include/qemu/cutils.h @@ -158,6 +158,18 @@ int qemu_strtosz_metric(const char *nptr, const char *= *end, uint64_t *result); =20 char *size_to_str(uint64_t val); =20 +/** + * freq_to_str: + * @freq_hz: frequency to stringify + * + * Return human readable string for frequency @freq_hz. + * Use SI units like KHz, MHz, and so forth. + * + * The caller is responsible for releasing the value returned with g_free() + * after use. + */ +char *freq_to_str(uint64_t freq_hz); + /* used to print char* safely */ #define STR_OR_NULL(str) ((str) ? (str) : "null") =20 diff --git a/util/cutils.c b/util/cutils.c index 36ce712271f..dab837fd8b8 100644 --- a/util/cutils.c +++ b/util/cutils.c @@ -885,6 +885,16 @@ char *size_to_str(uint64_t val) return g_strdup_printf("%0.3g %sB", (double)val / div, suffixes[i]); } =20 +char *freq_to_str(uint64_t freq_hz) +{ + static const char *suffixes[] =3D { "", "K", "M", "G", "T", "P", "E" }; + unsigned unit_index =3D log10(freq_hz) / 3; + + return g_strdup_printf("%0.3g %sHz", + freq_hz / pow(10.0, unit_index * 3.0), + suffixes[unit_index]); +} + int qemu_pstrcmp0(const char **str1, const char **str2) { return g_strcmp0(*str1, *str2); --=20 2.26.2 From nobody Sun Nov 16 16:31:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.67 as permitted sender) client-ip=209.85.221.67; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f67.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.67 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1601197707; cv=none; d=zohomail.com; s=zohoarc; b=GYWkHt/rgb+8xgxeGCM2vCG9cnUgzA8rkZJQ417GPRaPHPjELS51J7HbV9+0DfiB5Q1dxMj5c2QlH6c719O4pEkN7i2zQskXIXq1eOAMM/vMOD2wktPqFSoFcCf9waF5QZYsm283sr2szTnpLsioPkDl5iAjrANXWRy+stO5vi0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601197707; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=g/6nKkvgWnq0c/AG8DfCxF9NNLJNAWyxVfnfIeVT6t8=; b=NXoU5x9z0Bgy7Y0zCLQ4Iwr53Wdc5nnzs9mjNBxCP23FuJAZIKXaO9mIk6N/xqqYyljfip+zT2nPpuidS8tgDgt41ZRmOZf+fDAG2mHk+ckfglvXH5QkjOZrAXZh1V/9KH7tbjO21RhP0wfRJzlq4EHiwEJZCXwqnUljIeVBlLU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.67 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.zohomail.com with SMTPS id 1601197707492382.07826573256; Sun, 27 Sep 2020 02:08:27 -0700 (PDT) Received: by mail-wr1-f67.google.com with SMTP id x14so8350517wrl.12 for ; Sun, 27 Sep 2020 02:08:26 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (74.red-83-53-161.dynamicip.rima-tde.net. [83.53.161.74]) by smtp.gmail.com with ESMTPSA id y6sm9007187wrn.41.2020.09.27.02.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2020 02:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g/6nKkvgWnq0c/AG8DfCxF9NNLJNAWyxVfnfIeVT6t8=; b=mdPBjNfcPkLfBgSUQeZDh+mxzVmtg/H2GK1HTBzqmcprES/nCEsPACKP5l4ISdbrH5 mdJK4dtnR8oPAl3om5xjhlnGb+44+fppxFf23MQuZarjg1blWGecIZOwlXxqeXnU02rs zvOMlCgQsuM2EbGH5GwqmjLTwrGWczShSFvVleovAQsHo5aHLhEx8qbla3uexYANv316 3nRlSfdvCoVgYInxlbt8ufDfCG/mUmZZOl9pmKhOGvcXYTRKso1L3wnDMEa79m7Wvlxi J94k1DA9MXHMEpZ5PebOaooBdQV9xMnHctXe+mgCRKBmpVGoY5/s4D3dF+7smpJFX0XR Hh/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=g/6nKkvgWnq0c/AG8DfCxF9NNLJNAWyxVfnfIeVT6t8=; b=ioakjzvKnDXcqaokQTGh6mYXGBfAXK+t+z5GZhtWb1a0DE+pj5kb72DemEDt80NBWO bPiB3XkA2S1KIXuMDI6PcRISk/+y7INKqxqiDFIh8q5W6B3MxKGNDG5ECVo8jaA+JJ38 GhX2RwV4MZrnsnAlH67LzCJfZfWAjpEShY9roNf8w439gh9FmRn1/h1gJoUx4jsgyeRx wusFfHlBZlEAaWWDPGlV+S31Rc89mOriNHFHhHiA+XRiw0dJ4JF/HD5tQVIDNu/qM4d4 +ObZKKZTdgsyLpTkjL1mwafrbvMCNZMNVPPekTVJdzzabogXn5A4C2ieIo06JsyutZdI Lj2A== X-Gm-Message-State: AOAM530aPBgGoqLdM0P2AYEqzQQX8TAVcv/BBLo1H3aB5P5IXR/C4SHx QoBYmbvaieePY8oBvBRiAE8= X-Google-Smtp-Source: ABdhPJzKaiDMaImaZToR7YXr9MEBSOLaHTuNCojcQODEJemcetZXMiWfa4KQ0h8DDEwJihbqbSoUjw== X-Received: by 2002:a5d:4d01:: with SMTP id z1mr13010243wrt.366.1601197705256; Sun, 27 Sep 2020 02:08:25 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Tyrone Ting , Alistair Francis , Eduardo Habkost , Luc Michel , Damien Hedde , "Edgar E . Iglesias" , Havard Skinnemoen , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 2/3] qdev-monitor: Display frequencies scaled to SI unit Date: Sun, 27 Sep 2020 11:08:19 +0200 Message-Id: <20200927090820.61859-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200927090820.61859-1-f4bug@amsat.org> References: <20200927090820.61859-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Since commit 9f2ff99c7f2 ("qdev-monitor: print the device's clock with info qtree") we can display the clock frequencies in the monitor. Use the recently introduced freq_to_str() to display the frequencies using the closest SI unit (human friendlier). Before: (qemu) info qtree [...] dev: xilinx,zynq_slcr, id "" clock-in "ps_clk" freq_hz=3D3.333333e+07 mmio 00000000f8000000/0000000000001000 After: dev: xilinx,zynq_slcr, id "" clock-in "ps_clk" freq_hz=3D33.3 MHz mmio 00000000f8000000/0000000000001000 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Damien Hedde Reviewed-by: Luc Michel --- qdev-monitor.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index e9b7228480d..a0301cfca81 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -747,11 +747,13 @@ static void qdev_print(Monitor *mon, DeviceState *dev= , int indent) } } QLIST_FOREACH(ncl, &dev->clocks, node) { - qdev_printf("clock-%s%s \"%s\" freq_hz=3D%e\n", + g_autofree char *freq =3D NULL; + + freq =3D freq_to_str(clock_get_hz(ncl->clock)); + qdev_printf("clock-%s%s \"%s\" freq_hz=3D%s\n", ncl->output ? "out" : "in", ncl->alias ? " (alias)" : "", - ncl->name, - CLOCK_PERIOD_TO_HZ(1.0 * clock_get(ncl->clock))); + ncl->name, freq); } class =3D object_get_class(OBJECT(dev)); do { --=20 2.26.2 From nobody Sun Nov 16 16:31:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.65 as permitted sender) client-ip=209.85.128.65; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f65.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1601197708; cv=none; d=zohomail.com; s=zohoarc; b=hYUQBQp6M+QU2+IwVexAVm5W7W2+tkI2ynMG1VRdQSJ7jqWh4upMaLiK3G406NO8qwIlEjgGonkEAwm3SGQNjmihzZE3nHXVvtRUm/QVI8gLLAePn30rY5KTMYeyACpUtbSs+++1w0EPjjEZDrfLK7+WrD+Ek51JQdVuzGQBuZw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601197708; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=t3BREwZtlazYO80VUKfXukPFJ19pqUVUnt1RMwbxcUM=; b=Tu6KKYiDyOrj+J+KqjlYrN1AqwzYVLGNP4aHAWEHQAQkNnAWtb4L26vPhSIo8LDFl8UtKy8QICbaZFdkxi9ckjHOewnWHGNyLTEJ6tRGQZDnffPqs5m/AvQiLdXVND015awUIQ6V+IAnytH2mG+VjSXB/p++ETZxMmyV+QK5pfo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.zohomail.com with SMTPS id 1601197708290674.0426409596976; Sun, 27 Sep 2020 02:08:28 -0700 (PDT) Received: by mail-wm1-f65.google.com with SMTP id y15so3585702wmi.0 for ; Sun, 27 Sep 2020 02:08:27 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (74.red-83-53-161.dynamicip.rima-tde.net. [83.53.161.74]) by smtp.gmail.com with ESMTPSA id y6sm9007187wrn.41.2020.09.27.02.08.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2020 02:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=t3BREwZtlazYO80VUKfXukPFJ19pqUVUnt1RMwbxcUM=; b=SL+rwC+XFiGvq5yE0OJaxyFRRXicxzbYUhe7t0JtPPMFhc8PbWEK0m/3o4tIbMXKhV XZjvaf9wb656+H7EfHcKit4Cz1phJNU6vQJF8CKWbhFUgzVk1C9vDuhJrSirEU/CToqY re7uJfr6PBfRIpRK4exMIucLuffOSI4ARlj+0mr03LA4yhGkDyGbUb5TqCvlhnJP0cRJ eQ0hHqumqj4mhgBCuff+b7esWZQCPybpGu1AUMGcvcH3UsHSBovsYj6CeaaBiuzwkttc AsgXny808rjLmgKkBfaXphTw2QAELHKmdbFan7mvTIpayr6kAOj1iYVsptG4cr/Cy7VO LXkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=t3BREwZtlazYO80VUKfXukPFJ19pqUVUnt1RMwbxcUM=; b=L6geGaMB2w5jpPyjHAnptcHL195xpdN0t/Tj0uA5/BciWHzX6dBn9p9Z7QrdhnV0ZF 7JTntq45yPjXkNbXyEpxQ0mdBd++/VVHvxUmx2MNUN3Q+g9RieGWQbR6eFWIJ1VnlmUl fsufcRt1/9Tpc0Np4EVMg/skYKxstPxqnH+ByQd9RIiwEBno1eTmKd5OYBIo9F/mHCXy ALUbfF+GX1FX7wtLwOPq+2LbV108/fkThc+G1jiphhs786/t6q7+dk3Su8cPzjdOiXNx vLNmYtTVchbVbeAudymk7xdKdAYGiZf2fvEQsDX9OELiplIsRG6nrv1Lz71dmapy7nmf DQRw== X-Gm-Message-State: AOAM533fmFSpq2zNILaRYwQ/BmYd+rLUEucWq7avdanRUKzDCRoNE6vT TxVaU3JX1jwDxk4YhCCMIdg= X-Google-Smtp-Source: ABdhPJyAO6B3/PsaFvI5o0iZWWAVH+pvG4PCweOMTLUpLnb5WiEy44yJ7nYxjGnFMHxWYX0tDMWIRA== X-Received: by 2002:a1c:9d42:: with SMTP id g63mr6267355wme.20.1601197706424; Sun, 27 Sep 2020 02:08:26 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Tyrone Ting , Alistair Francis , Eduardo Habkost , Luc Michel , Damien Hedde , "Edgar E . Iglesias" , Havard Skinnemoen , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 3/3] hw/qdev-clock: Display error hint when clock is missing from device Date: Sun, 27 Sep 2020 11:08:20 +0200 Message-Id: <20200927090820.61859-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200927090820.61859-1-f4bug@amsat.org> References: <20200927090820.61859-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Instead of directly aborting, display a hint to help the developer figure out the problem (likely trying to connect a clock to a device pre-dating the Clock API, thus not expecting clocks). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Damien Hedde Reviewed-by: Edgar E. Iglesias Reviewed-by: Luc Michel --- hw/core/qdev-clock.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/core/qdev-clock.c b/hw/core/qdev-clock.c index 47ecb5b4fae..33bd4a9d520 100644 --- a/hw/core/qdev-clock.c +++ b/hw/core/qdev-clock.c @@ -12,6 +12,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/error-report.h" #include "hw/qdev-clock.h" #include "hw/qdev-core.h" #include "qapi/error.h" @@ -153,6 +154,11 @@ Clock *qdev_get_clock_in(DeviceState *dev, const char = *name) assert(name); =20 ncl =3D qdev_get_clocklist(dev, name); + if (!ncl) { + error_report("can not find clock-in '%s' for device type '%s'", + name, object_get_typename(OBJECT(dev))); + abort(); + } assert(!ncl->output); =20 return ncl->clock; @@ -165,6 +171,11 @@ Clock *qdev_get_clock_out(DeviceState *dev, const char= *name) assert(name); =20 ncl =3D qdev_get_clocklist(dev, name); + if (!ncl) { + error_report("can not find clock-out '%s' for device type '%s'", + name, object_get_typename(OBJECT(dev))); + abort(); + } assert(ncl->output); =20 return ncl->clock; --=20 2.26.2