From nobody Mon Feb 9 11:33:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1600981384; cv=none; d=zohomail.com; s=zohoarc; b=CMcQPr+z6CgQjoIIwhV8PUwzw2h4Iqc8kyNdj5/GbWNCMq/cu0PzyFtC9z+6vrGybGe5Q7nECQ350X/ZZp4sVPo9W4dNG8dBkEz2Zae/Gu91PSGrt0/PkojqyFIiuQqjZEAEJ9DU3M04asS9u6typSr0evVZZxUpb7GYa9dkxWE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600981384; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qEKNIM+lPRA0c0RxRX/s4SVmBXPBiqyjUZhRX090gXI=; b=gTs51MCp9eC/6/evljs9pkCKk/towukrNS2BMo8MQRFZQTwDADO1IOqpNTJSKqHj1PEdCmKuNm2jJTOvgNj/a5/s+eVR26BNJz8KJZpmjxo82LLTuerQwK9cncB5zecqgI7gtZcqa63xsKcnbT0yslJU3wINiOlSIBtlTFVN6GE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600981384710105.79995865131741; Thu, 24 Sep 2020 14:03:04 -0700 (PDT) Received: from localhost ([::1]:37940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLYOM-0005tP-RI for importer@patchew.org; Thu, 24 Sep 2020 17:03:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLY7O-0004RD-1f; Thu, 24 Sep 2020 16:45:30 -0400 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:54601) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLY7J-0007h9-O9; Thu, 24 Sep 2020 16:45:29 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id AE0F558050C; Thu, 24 Sep 2020 16:45:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 24 Sep 2020 16:45:23 -0400 Received: from apples.local (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id D8F443064682; Thu, 24 Sep 2020 16:45:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=fm1; bh= qEKNIM+lPRA0c0RxRX/s4SVmBXPBiqyjUZhRX090gXI=; b=mFIKeNALOPJUzzRw iQmgnHbCruZbtxHZ557Ki9T2Dga7uvYIdf7IJyunEHhYJvfawD+lBR1h8hi+vi0U Sgmfnu/1BnemS7q5DnipzX2wO4tGWuYT7Q/rDU9e4zhi33zjlGf7KSIdfOXc4MVM GPED2AcPoApQFkEMtXqYjiAUmIOGPzVallmizORUeQI/OqIkm2qmP3JKAsgbVqIZ rqrdJVd+uIQjSxo1+AsXcHd95utdTNPkOJsNOlVzav3bJalt/9/tCnyzB9K/8Ps7 j4niKCZzRlL0yode+N5vSJIkwPEfeW3JAkesgXh3JdlplEc7vVNywlSPo7WI87LN e9wA8g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=qEKNIM+lPRA0c0RxRX/s4SVmBXPBiqyjUZhRX090g XI=; b=AhE/dRdrkdAkBngThpoY6CKJWUUXmMoY4KWrDhw6ZYIqSoyo/dY1564MN tkYiYiQTf1J0oVQuUSd8IgbuRk4XrPd7CqEVUXMjinlUtzZ+np1B7R6dHnt7fplH uQoOz9zK6ay1VPxPQv2L91z0pB0tcGhkf/MLmX4APIXzjJIfsNWxR2kvMW2DxPKi x6vrYWd1VmdIAawCqr5OFnZtUBOeNbmitZYagGKtTTrlcbmcrnrtgDl5ZNMD7PA5 duZsaqUkdfsHgYaOJXJ/VSZWdOHn16DdZpjekY3ri4Uju0Ql8RzPPfTm3cHM/8xx cAxS/u9GeRI4hmTTfPASsVksj9lJg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudekgdduheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepmfhlrghu shculfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrth htvghrnhepteevuedugeevieehgeeileeufeetvddtkeetfeelgeehudfhjeeuledvhfff tdegnecukfhppeektddrudeijedrleekrdduledtnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepihhtshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: From: Klaus Jensen To: qemu-devel@nongnu.org Subject: [PATCH 03/16] hw/block/nvme: make lba data size configurable Date: Thu, 24 Sep 2020 22:45:03 +0200 Message-Id: <20200924204516.1881843-4-its@irrelevant.dk> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200924204516.1881843-1-its@irrelevant.dk> References: <20200924204516.1881843-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=66.111.4.224; envelope-from=its@irrelevant.dk; helo=new2-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/24 14:55:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , qemu-block@nongnu.org, Klaus Jensen , Max Reitz , Keith Busch , Klaus Jensen , Maxim Levitsky , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Klaus Jensen Allos the LBA data size (lbads) to be set between 9 and 12. Signed-off-by: Klaus Jensen Acked-by: Keith Busch Reviewed-by: Maxim Levitsky Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- docs/specs/nvme.txt | 11 ++++++++++- hw/block/nvme-ns.h | 1 + hw/block/nvme-ns.c | 8 +++++++- hw/block/nvme.c | 1 + 4 files changed, 19 insertions(+), 2 deletions(-) diff --git a/docs/specs/nvme.txt b/docs/specs/nvme.txt index 56d393884e7a..438ca50d698c 100644 --- a/docs/specs/nvme.txt +++ b/docs/specs/nvme.txt @@ -1,7 +1,16 @@ NVM Express Controller =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 -The nvme device (-device nvme) emulates an NVM Express Controller. +The nvme device (-device nvme) emulates an NVM Express Controller. It is u= sed +together with nvme-ns devices (-device nvme-ns) which emulates an NVM Expr= ess +Namespace. + +nvme-ns Options +--------------- + + `lbads`; The "LBA Data Size (LBADS)" indicates the LBA data size used by= the + namespace. It is specified in terms of a power of two. Only values be= tween + 9 and 12 (both inclusive) are supported. =20 =20 Reference Specifications diff --git a/hw/block/nvme-ns.h b/hw/block/nvme-ns.h index 83734f4606e1..78b0d1a00672 100644 --- a/hw/block/nvme-ns.h +++ b/hw/block/nvme-ns.h @@ -21,6 +21,7 @@ =20 typedef struct NvmeNamespaceParams { uint32_t nsid; + uint8_t lbads; } NvmeNamespaceParams; =20 typedef struct NvmeNamespace { diff --git a/hw/block/nvme-ns.c b/hw/block/nvme-ns.c index 2ba0263ddaca..576c7486f45b 100644 --- a/hw/block/nvme-ns.c +++ b/hw/block/nvme-ns.c @@ -36,7 +36,7 @@ static void nvme_ns_init(NvmeNamespace *ns) ns->id_ns.dlfeat =3D 0x9; } =20 - id_ns->lbaf[0].ds =3D BDRV_SECTOR_BITS; + id_ns->lbaf[0].ds =3D ns->params.lbads; =20 id_ns->nsze =3D cpu_to_le64(nvme_ns_nlbas(ns)); =20 @@ -77,6 +77,11 @@ static int nvme_ns_check_constraints(NvmeNamespace *ns, = Error **errp) return -1; } =20 + if (ns->params.lbads < 9 || ns->params.lbads > 12) { + error_setg(errp, "unsupported lbads (supported: 9-12)"); + return -1; + } + return 0; } =20 @@ -125,6 +130,7 @@ static void nvme_ns_realize(DeviceState *dev, Error **e= rrp) static Property nvme_ns_props[] =3D { DEFINE_BLOCK_PROPERTIES(NvmeNamespace, blkconf), DEFINE_PROP_UINT32("nsid", NvmeNamespace, params.nsid, 0), + DEFINE_PROP_UINT8("lbads", NvmeNamespace, params.lbads, BDRV_SECTOR_BI= TS), DEFINE_PROP_END_OF_LIST(), }; =20 diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 3cbc3c7b75b1..758f58c88026 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -2812,6 +2812,7 @@ static void nvme_realize(PCIDevice *pci_dev, Error **= errp) if (n->namespace.blkconf.blk) { ns =3D &n->namespace; ns->params.nsid =3D 1; + ns->params.lbads =3D BDRV_SECTOR_BITS; =20 if (nvme_ns_setup(n, ns, errp)) { return; --=20 2.28.0