From nobody Mon Feb 9 07:55:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600964611; cv=none; d=zohomail.com; s=zohoarc; b=HBpFQYiQsyeBp5qeYeYp9HVknYpexi9Ll7UVY6KpRwYPQWDLxU43TOvfESVKjsFY7V1z1YpE+6NhFBaEH+vUS+fNYBIKCnxP5L83O5idGYsbjklVbHmw1hOAFURkXWQoAz6fiiCjwsRzkeevNT+YR+iYojpit1THG7147aXArV0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600964611; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=v6IefpecqGL3XgdT1oT6U0apZGd5TzKbwUBmHtxx5Ps=; b=TWIf+1pfIh0aqDoUmO/HzOKlMhPor7Rudq+n71mogWZHMuQlGQ56Kcl8HTjh0O6lCC/OsLraZXoNmL60nCIMCUds6iRYObHeOFPGyLxSiJSK3CkDwY9mtA4jIrFIqb3vvzpZloyOKsYhvPJABQrNtqepw/K5+MCBqLlEVy96jmg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600964611052495.14045388661725; Thu, 24 Sep 2020 09:23:31 -0700 (PDT) Received: from localhost ([::1]:46980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLU1p-0001F0-Ly for importer@patchew.org; Thu, 24 Sep 2020 12:23:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLTkp-00036e-FN for qemu-devel@nongnu.org; Thu, 24 Sep 2020 12:05:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:21279) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kLTkn-00043A-Ik for qemu-devel@nongnu.org; Thu, 24 Sep 2020 12:05:55 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-64-QVowD1Z_NfCRO4e7H1nxcw-1; Thu, 24 Sep 2020 12:05:51 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1DE26AD687; Thu, 24 Sep 2020 16:05:50 +0000 (UTC) Received: from t480s.redhat.com (ovpn-114-4.ams2.redhat.com [10.36.114.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id ADDD619C66; Thu, 24 Sep 2020 16:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600963552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v6IefpecqGL3XgdT1oT6U0apZGd5TzKbwUBmHtxx5Ps=; b=TPlSCqu3YejMpTspCx2GvrcnzZ5y7zxJC2qcQgAiNZz5KE0EG/hwsK5ZSf053hqPxAIH5f tCIl+pcO6cZHYiL211tjnbqyjumAxBCh9HU1eQqsSSynKg4cr03NIH0WYfwi7aBdIL5+Fr jhFQoNilbPElWBxMrAMq6e2ClZs3BV8= X-MC-Unique: QVowD1Z_NfCRO4e7H1nxcw-1 From: David Hildenbrand To: qemu-devel@nongnu.org Subject: [PATCH PROTOTYPE 5/6] virtio-mem: Require only RAM_BLOCK_DISCARD_T_COORDINATED discards Date: Thu, 24 Sep 2020 18:04:22 +0200 Message-Id: <20200924160423.106747-6-david@redhat.com> In-Reply-To: <20200924160423.106747-1-david@redhat.com> References: <20200924160423.106747-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/24 01:10:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pankaj Gupta , David Hildenbrand , "Michael S. Tsirkin" , "Dr . David Alan Gilbert" , Peter Xu , Luiz Capitulino , Auger Eric , Alex Williamson , Wei Yang , Igor Mammedov , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" We implement the SparseRamHandler interface and properly communicate changes by notifying listeners - especially in all scenarios - when memory becomes usable by the guest - when memory becomes unusable by the guest (and we discard memory) Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Alex Williamson Cc: Wei Yang Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Pankaj Gupta Cc: Peter Xu Signed-off-by: David Hildenbrand --- hw/virtio/virtio-mem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c index e23969eaed..efeff7c64c 100644 --- a/hw/virtio/virtio-mem.c +++ b/hw/virtio/virtio-mem.c @@ -531,7 +531,7 @@ static void virtio_mem_device_realize(DeviceState *dev,= Error **errp) return; } =20 - if (ram_block_discard_require(true)) { + if (ram_block_discard_type_require(RAM_BLOCK_DISCARD_T_COORDINATED, tr= ue)) { error_setg(errp, "Discarding RAM is disabled"); return; } @@ -539,7 +539,7 @@ static void virtio_mem_device_realize(DeviceState *dev,= Error **errp) ret =3D ram_block_discard_range(rb, 0, qemu_ram_get_used_length(rb)); if (ret) { error_setg_errno(errp, -ret, "Unexpected error discarding RAM"); - ram_block_discard_require(false); + ram_block_discard_type_require(RAM_BLOCK_DISCARD_T_COORDINATED, fa= lse); return; } =20 @@ -579,7 +579,7 @@ static void virtio_mem_device_unrealize(DeviceState *de= v) virtio_del_queue(vdev, 0); virtio_cleanup(vdev); g_free(vmem->bitmap); - ram_block_discard_require(false); + ram_block_discard_type_require(RAM_BLOCK_DISCARD_T_COORDINATED, false); } =20 static int virtio_mem_restore_unplugged(VirtIOMEM *vmem) --=20 2.26.2