From nobody Tue Feb 10 01:00:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600940410; cv=none; d=zohomail.com; s=zohoarc; b=QHZcYKeVJNm18JkSHoH4xKQ5No/p0xsk2vUgGeL08twLyWEyUtF1RbLGEQR4JYzqVZmh+kqOCTYPClvy3blND2N+xOfZdGtFdZryWwCniPGTHu9W+BWcS0ltA6+mPnlT4SBl//UDDml2B/8ewCY+AEEPLeDJGs38aQu4QKMGMTI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600940410; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=154efQ/NHyBGhzEktus473Tw2MtI1+6f/qx/y7yZY0o=; b=C2qcexoRphLyELyAs3d5E3w52NsxqjMiC43ucXEzv4Zzf8zIM9uFNGwaqtNuf6XrKSJ1VolVowAIpUEWf8dodeInkxHQKTYIqkTI9Fpn3tADMHwJk1XhmNE9RoW94Cqf+lN1lIZspbS6tp5r6CXaLD6nJ6mf13ZMb0bIsi/O5XU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600940410650936.2894363015927; Thu, 24 Sep 2020 02:40:10 -0700 (PDT) Received: from localhost ([::1]:58136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLNjV-0006Wv-5t for importer@patchew.org; Thu, 24 Sep 2020 05:40:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLNTl-0000xH-7v for qemu-devel@nongnu.org; Thu, 24 Sep 2020 05:23:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:35758) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kLNTi-000638-5Z for qemu-devel@nongnu.org; Thu, 24 Sep 2020 05:23:52 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-228-xxyUwXVWPve96fBKj0x_iA-1; Thu, 24 Sep 2020 05:23:47 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 69A651891E80; Thu, 24 Sep 2020 09:23:46 +0000 (UTC) Received: from virtlab701.virt.lab.eng.bos.redhat.com (virtlab701.virt.lab.eng.bos.redhat.com [10.19.152.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id 348D055764; Thu, 24 Sep 2020 09:23:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600939429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=154efQ/NHyBGhzEktus473Tw2MtI1+6f/qx/y7yZY0o=; b=FIFBXbuo0WzjF43lrw0dsqcFunj+jwu5cNPKDLwieBz8aPp1vohBIeo55an27MdbdZ4wf7 D13fYEofQ1YVxPHE0EhJvZSAScwpD3gyqxLfZxfYURnHv5NkuUxjo4Bkov/6o4dC/4t6hF sz48a1MoejH9NNklwIZWScNIGyQIfUU= X-MC-Unique: xxyUwXVWPve96fBKj0x_iA-1 From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 34/92] configure: move cocoa option to Meson Date: Thu, 24 Sep 2020 05:22:16 -0400 Message-Id: <20200924092314.1722645-35-pbonzini@redhat.com> In-Reply-To: <20200924092314.1722645-1-pbonzini@redhat.com> References: <20200924092314.1722645-1-pbonzini@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/24 01:10:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.228, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe de Dinechin , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" While detection of the framework was already there, moving the option allows for better error reporting. Reported-by: Christophe de Dinechin Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- configure | 17 +++++++---------- meson.build | 9 +++++++-- meson_options.txt | 2 ++ ui/meson.build | 2 +- 4 files changed, 17 insertions(+), 13 deletions(-) diff --git a/configure b/configure index 50ddfdeb20..f3a2f43250 100755 --- a/configure +++ b/configure @@ -457,7 +457,7 @@ bsd=3D"no" linux=3D"no" solaris=3D"no" profiler=3D"no" -cocoa=3D"no" +cocoa=3D"auto" softmmu=3D"yes" linux_user=3D"no" bsd_user=3D"no" @@ -875,7 +875,7 @@ Darwin) QEMU_CFLAGS=3D"-arch x86_64 $QEMU_CFLAGS" QEMU_LDFLAGS=3D"-arch x86_64 $QEMU_LDFLAGS" fi - cocoa=3D"yes" + cocoa=3D"enabled" audio_drv_list=3D"coreaudio try-sdl" audio_possible_drivers=3D"coreaudio sdl" QEMU_LDFLAGS=3D"-framework CoreFoundation -framework IOKit $QEMU_LDFLAGS" @@ -1246,10 +1246,10 @@ for opt do ;; --enable-profiler) profiler=3D"yes" ;; - --disable-cocoa) cocoa=3D"no" + --disable-cocoa) cocoa=3D"disabled" ;; --enable-cocoa) - cocoa=3D"yes" ; + cocoa=3D"enabled" ; audio_drv_list=3D"coreaudio $(echo $audio_drv_list | sed s,coreaudio= ,,g)" ;; --disable-system) softmmu=3D"no" @@ -2391,8 +2391,8 @@ fi # cocoa implies not SDL or GTK # (the cocoa UI code currently assumes it is always the active UI # and doesn't interact well with other UI frontend code) -if test "$cocoa" =3D "yes"; then - if test "$sdl" =3D "yes"; then +if test "$cocoa" =3D "enabled"; then + if test "$sdl" =3D "enabled"; then error_exit "Cocoa and SDL UIs cannot both be enabled at once" fi if test "$gtk" =3D "yes"; then @@ -6556,9 +6556,6 @@ if test "$have_x11" =3D "yes" && test "$need_x11" =3D= "yes"; then echo "X11_CFLAGS=3D$x11_cflags" >> $config_host_mak echo "X11_LIBS=3D$x11_libs" >> $config_host_mak fi -if test "$cocoa" =3D "yes" ; then - echo "CONFIG_COCOA=3Dy" >> $config_host_mak -fi if test "$iconv" =3D "yes" ; then echo "CONFIG_ICONV=3Dy" >> $config_host_mak echo "ICONV_CFLAGS=3D$iconv_cflags" >> $config_host_mak @@ -7860,7 +7857,7 @@ NINJA=3D${ninja:-$PWD/ninjatool} $meson setup \ -Db_pie=3D$(if test "$pie" =3D yes; then echo true; else echo fals= e; fi) \ -Db_coverage=3D$(if test "$gcov" =3D yes; then echo true; else ech= o false; fi) \ -Dmalloc=3D$malloc -Dmalloc_trim=3D$malloc_trim \ - -Dmpath=3D$mpath -Dsdl=3D$sdl -Dsdl_image=3D$sdl_image \ + -Dcocoa=3D$cocoa -Dmpath=3D$mpath -Dsdl=3D$sdl -Dsdl_image=3D$sdl_image \ -Dvnc=3D$vnc -Dvnc_sasl=3D$vnc_sasl -Dvnc_jpeg=3D$vnc_jpeg -Dvnc_png=3D$v= nc_png \ -Dgettext=3D$gettext -Dxkbcommon=3D$xkbcommon -Du2f=3D$u2f\ $cross_arg \ diff --git a/meson.build b/meson.build index 08ebfca6d0..1e7d2f9a0a 100644 --- a/meson.build +++ b/meson.build @@ -101,7 +101,7 @@ socket =3D [] version_res =3D [] coref =3D [] iokit =3D [] -cocoa =3D [] +cocoa =3D not_found hvf =3D [] if targetos =3D=3D 'windows' socket =3D cc.find_library('ws2_32') @@ -114,7 +114,7 @@ if targetos =3D=3D 'windows' elif targetos =3D=3D 'darwin' coref =3D dependency('appleframeworks', modules: 'CoreFoundation') iokit =3D dependency('appleframeworks', modules: 'IOKit') - cocoa =3D dependency('appleframeworks', modules: 'Cocoa') + cocoa =3D dependency('appleframeworks', modules: 'Cocoa', required: get_= option('cocoa')) hvf =3D dependency('appleframeworks', modules: 'Hypervisor') elif targetos =3D=3D 'sunos' socket =3D [cc.find_library('socket'), @@ -126,6 +126,10 @@ elif targetos =3D=3D 'haiku' cc.find_library('bsd')] endif =20 +if not cocoa.found() and get_option('cocoa').enabled() + error('Cocoa not available on this platform') +endif + ################ # Dependencies # ################ @@ -536,6 +540,7 @@ endif =20 # Create config-host.h =20 +config_host_data.set('CONFIG_COCOA', cocoa.found()) config_host_data.set('CONFIG_LIBUDEV', libudev.found()) config_host_data.set('CONFIG_MPATH', mpathpersist.found()) config_host_data.set('CONFIG_MPATH_NEW_API', mpathpersist_new_api) diff --git a/meson_options.txt b/meson_options.txt index 8a59ec263d..46ea1d889a 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -11,6 +11,8 @@ option('malloc_trim', type : 'feature', value : 'auto', option('malloc', type : 'combo', choices : ['system', 'tcmalloc', 'jemallo= c'], value: 'system', description: 'choose memory allocator to use') =20 +option('cocoa', type : 'feature', value : 'auto', + description: 'Cocoa user interface (macOS only)') option('mpath', type : 'feature', value : 'auto', description: 'Multipath persistent reservation passthrough') option('sdl', type : 'feature', value : 'auto', diff --git a/ui/meson.build b/ui/meson.build index dd6c110136..8a080c38e3 100644 --- a/ui/meson.build +++ b/ui/meson.build @@ -15,7 +15,7 @@ softmmu_ss.add(files( =20 softmmu_ss.add(when: 'CONFIG_LINUX', if_true: files('input-linux.c')) softmmu_ss.add(when: 'CONFIG_SPICE', if_true: files('spice-core.c', 'spice= -input.c', 'spice-display.c')) -softmmu_ss.add(when: [cocoa, 'CONFIG_COCOA'], if_true: files('cocoa.m')) +softmmu_ss.add(when: cocoa, if_true: files('cocoa.m')) =20 vnc_ss =3D ss.source_set() vnc_ss.add(files( --=20 2.26.2