From nobody Sun Nov 16 16:27:26 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600852750; cv=none; d=zohomail.com; s=zohoarc; b=dR/LCAwAI0Y3L2+HI0/Dv8SZDxXJSQrxWRs+j4BQLHmOEASV9H5LNPRueZ+rFvlaQ8+cqH8N0k2HpkYsvtfJdjwskCKtzKiRX5luLxA/HXXqgp3q1ERmiaAIw5mtBjIy/D48EtA4FMzqBYtnYt9Qm16yo9zlPe/yjwe7He7h72A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600852750; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oF6uWLN54rhpi5znI8oZjbiaXIAljFhTjCrXho8KFh8=; b=TnubFgih2ACJNFB8hCU6qNLS+GsMd3vx+9DbeE0wtotc6Xt0sHK0+WjQpButIGV/TO5MBmmPtv0H94VID2wBxUODxSUQ4f+vX58x9sp+G/MGfr2JTQJWkZAeuzdqBRvQXsDbeYAr3Nz4s/Z+sYDYUCzG3ANjZf/y2ze1dthA4hw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600852750866753.9466435171543; Wed, 23 Sep 2020 02:19:10 -0700 (PDT) Received: from localhost ([::1]:48552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kL0vd-00034c-9b for importer@patchew.org; Wed, 23 Sep 2020 05:19:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kL0n6-0007vI-Fs for qemu-devel@nongnu.org; Wed, 23 Sep 2020 05:10:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:40510) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kL0n4-00025a-P8 for qemu-devel@nongnu.org; Wed, 23 Sep 2020 05:10:20 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-552-18yGpEj_OlKmwWVF1tEj5Q-1; Wed, 23 Sep 2020 05:10:16 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0E83E8027E2; Wed, 23 Sep 2020 09:10:15 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-85.ams2.redhat.com [10.36.112.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2D36A55782; Wed, 23 Sep 2020 09:10:08 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id E5B8031E60; Wed, 23 Sep 2020 11:10:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600852217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oF6uWLN54rhpi5znI8oZjbiaXIAljFhTjCrXho8KFh8=; b=dsb42MBKbgs7H5iir9b7L5ldnRwgpwviwjpOiEygT1b2TzIFTo9k8IlwNzuelPuhiy/GAO kbWGym/488Tz33AHZ+xyDrTfUYW8SklBonZBxarVLlwKZ+u+1MQxrTu/x36gZVe2D0vciB RR7zLC6jmBM2rg+tkLse99ZZL4ORK/w= X-MC-Unique: 18yGpEj_OlKmwWVF1tEj5Q-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 5/9] audio: remove unnecessary calls to put_buffer_in Date: Wed, 23 Sep 2020 11:09:57 +0200 Message-Id: <20200923091001.20814-6-kraxel@redhat.com> In-Reply-To: <20200923091001.20814-1-kraxel@redhat.com> References: <20200923091001.20814-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/23 00:53:58 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.455, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Volker=20R=C3=BCmelin?= , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Volker R=C3=BCmelin This patch removes unnecessary calls to the pcm_ops function put_buffer_in(). No audio backend needs this call if the returned length of pcm_ops function get_buffer_in() is zero. For the DirectSound backend this prevents a call to dsound_unlock_in() without a preceding call to dsound_lock_in(). While Windows doesn't complain it seems wrong anyway. Signed-off-by: Volker R=C3=BCmelin Message-id: 20200920171729.15861-5-vr_qemu@t-online.de Signed-off-by: Gerd Hoffmann --- audio/audio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 5c47a036028c..341edc4d0012 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1261,7 +1261,6 @@ static size_t audio_pcm_hw_run_in(HWVoiceIn *hw, size= _t samples) =20 assert(size % hw->info.bytes_per_frame =3D=3D 0); if (size =3D=3D 0) { - hw->pcm_ops->put_buffer_in(hw, buf, size); break; } =20 @@ -1502,7 +1501,6 @@ size_t audio_generic_read(HWVoiceIn *hw, void *buf, s= ize_t size) void *src =3D hw->pcm_ops->get_buffer_in(hw, &src_size); =20 if (src_size =3D=3D 0) { - hw->pcm_ops->put_buffer_in(hw, src, src_size); break; } =20 --=20 2.27.0