From nobody Sun Nov 16 16:27:28 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600852436; cv=none; d=zohomail.com; s=zohoarc; b=ipwSmXfV00Ne0dnHsRat7qUHpA9sqMSkRiOT1q9d9pVkPRGNZ/9JPAU06Vlg+Cx3763on5WLe2alY3HPnlUaGqczttYYf8D/sPHx3ZZdH7TLev0yojPkSttZk2A2CxrlMHRl5vVlUDkqbUmqc8rdEscq97Tzb04ujAwIZO6LPLw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600852436; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dUUhJZUJNQ98mPvRgxdG/nK0wS8NrKuyi1QgyFaNmvU=; b=IpBwpSOid+ggfCrUu9R0N5oQdGTJydgBkwaxdKUK2L9CE/E83anl2ZJmIg2c6nuD0L2aCf5C0fK+5mGdcFFecGOhFYODY6DG24kN697Xs65ja6xTUWQx0jm9KhFVgqwcqdy/axA9wVGY1ORL+4GnA8KGesA7Sdqh26ZyKwvPoAo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600852436764516.8857739962491; Wed, 23 Sep 2020 02:13:56 -0700 (PDT) Received: from localhost ([::1]:60228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kL0qZ-0004WH-Gt for importer@patchew.org; Wed, 23 Sep 2020 05:13:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kL0n2-0007lS-BF for qemu-devel@nongnu.org; Wed, 23 Sep 2020 05:10:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54642) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kL0n0-00022T-DL for qemu-devel@nongnu.org; Wed, 23 Sep 2020 05:10:16 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-45-LG3ezJtPP-SU4yVcQpkSwA-1; Wed, 23 Sep 2020 05:10:10 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 16C9710BBEED; Wed, 23 Sep 2020 09:10:09 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-85.ams2.redhat.com [10.36.112.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7D84973691; Wed, 23 Sep 2020 09:10:02 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id C831D1FCF5; Wed, 23 Sep 2020 11:10:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600852213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dUUhJZUJNQ98mPvRgxdG/nK0wS8NrKuyi1QgyFaNmvU=; b=OR8bkljW64+EQ3Y0iquIxK9WvAztcAkYNZq1STmFFJGITpqdbEt5OgAJ3JPcJj+GmiT1ZW pepYEPxvgPUsMEoRfW+qXuaxsMvxiuOU/sEWK40WZPlZGwmnLOrVZbaIsUxVwKlyiwiTQ4 LKnG4VOzQk/8b7HjzxnucpLdCFyQ7nw= X-MC-Unique: LG3ezJtPP-SU4yVcQpkSwA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 2/9] audio/audio: fix video playback slowdown with spiceaudio Date: Wed, 23 Sep 2020 11:09:54 +0200 Message-Id: <20200923091001.20814-3-kraxel@redhat.com> In-Reply-To: <20200923091001.20814-1-kraxel@redhat.com> References: <20200923091001.20814-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 23:02:20 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.455, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Volker=20R=C3=BCmelin?= , Gerd Hoffmann , Qi Zhou Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Volker R=C3=BCmelin This patch allows the audio backends get_buffer_out() functions to drop audio data and mitigates a bug reported on the qemu-devel mailing list. https://lists.nongnu.org/archive/html/qemu-devel/2020-09/msg03832.html The new rules for the variables buf and size returned by get_buffer_out() are: size =3D=3D 0: Downstream playback buffer is full. Retry later. size > 0, buf !=3D NULL: Copy size bytes to buf for playback. size > 0, buf =3D=3D NULL: Drop size bytes. The audio playback rate with spiceaudio for the no audio case is too fast, but that's what we had before commit fb35c2cec5 "audio/dsound: fix invalid parameters error". The complete fix comes with the next patch. Reported-by: Qi Zhou Signed-off-by: Volker R=C3=BCmelin Message-id: 20200920171729.15861-2-vr_qemu@t-online.de Signed-off-by: Gerd Hoffmann --- audio/audio.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 1a68cfaafb9f..7b660dd0c4d0 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1091,12 +1091,15 @@ static size_t audio_pcm_hw_run_out(HWVoiceOut *hw, = size_t live) while (live) { size_t size, decr, proc; void *buf =3D hw->pcm_ops->get_buffer_out(hw, &size); - if (!buf || size =3D=3D 0) { + + if (size =3D=3D 0) { break; } =20 decr =3D MIN(size / hw->info.bytes_per_frame, live); - audio_pcm_hw_clip_out(hw, buf, decr); + if (buf) { + audio_pcm_hw_clip_out(hw, buf, decr); + } proc =3D hw->pcm_ops->put_buffer_out(hw, buf, decr * hw->info.bytes_per_frame= ) / hw->info.bytes_per_frame; --=20 2.27.0