From nobody Sun Nov 16 16:12:40 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600815121; cv=none; d=zohomail.com; s=zohoarc; b=FXE5ltKq7FjFlzZWS6deBayePCKgpcd/E7rDldhW5C6UQ/IY2Op4v7iUrHONddIeDJWuTktvUdM/6ukJBDUyvFeQAR24w0gQKFdRQNk09iTmIwTDe0fdMQ2R0mfe2LJWSUsymeRGQW5Hpbb4JUjC++Xkbb01dIGOBrjZDw3uX4k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600815121; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Vg9UpVpOIFGZP/PFAC6mOMwuyzcjipA1odkHyeJaY84=; b=PPpiSa9chDlU+TRAWA7sWGJD/dtz22KVDCws85Y0qCzL//AR+OBUr7g7es3X3WNXZCbyAI7wd9R7bBhLHQG9XAN0BwUMWQZkqDXmsuSAGg8aBwW/omvx400cGmg8bdn8GipsU2f/oNbPfWHwvfhq5ahqtUNa/e/CDpIcy6t6a7w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600815121541851.927214290209; Tue, 22 Sep 2020 15:52:01 -0700 (PDT) Received: from localhost ([::1]:36548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKr8h-0002Wp-UJ for importer@patchew.org; Tue, 22 Sep 2020 18:52:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60276) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKr2J-00023u-9t for qemu-devel@nongnu.org; Tue, 22 Sep 2020 18:45:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:58130) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kKr2G-0000OE-Si for qemu-devel@nongnu.org; Tue, 22 Sep 2020 18:45:23 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-29-6P_BKxHSPEK1Usp9Sr-9_Q-1; Tue, 22 Sep 2020 18:45:18 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3052B81CAFC; Tue, 22 Sep 2020 22:45:17 +0000 (UTC) Received: from scv.redhat.com (ovpn-119-140.rdu2.redhat.com [10.10.119.140]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5FAA55C1A3; Tue, 22 Sep 2020 22:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600814720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vg9UpVpOIFGZP/PFAC6mOMwuyzcjipA1odkHyeJaY84=; b=UrE3Y38rnIVBm5ET9KCkJAVf9y7x2IOHfkF33/KkiWj94t6hsI8N+crl5uMmdRVkUPggws mPuM+6lUz8tqhrdMlt9XQG0Rrx/reQonog9gwIskQyaOvosChcBVqsuPqF2gnRxqtIrXZY 2WxAfypUCkaECq4Y/e70g7HDxXunBIc= X-MC-Unique: 6P_BKxHSPEK1Usp9Sr-9_Q-1 From: John Snow To: Markus Armbruster Subject: [PATCH 09/25] qapi/schema.py: remove superfluous assert Date: Tue, 22 Sep 2020 18:44:45 -0400 Message-Id: <20200922224501.4087749-10-jsnow@redhat.com> In-Reply-To: <20200922224501.4087749-1-jsnow@redhat.com> References: <20200922224501.4087749-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 15:47:47 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.455, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , qemu-devel@nongnu.org, John Snow , Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" We'll actually get a better error message by just letting the dictionary lookup fail. Signed-off-by: John Snow --- scripts/qapi/schema.py | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py index a84d8549a4..b35f741c6f 100644 --- a/scripts/qapi/schema.py +++ b/scripts/qapi/schema.py @@ -892,7 +892,6 @@ def _make_module(self, fname): =20 def module_by_fname(self, fname): name =3D self._module_name(fname) - assert name in self._module_dict return self._module_dict[name] =20 def _def_include(self, expr, info, doc): --=20 2.26.2