From nobody Mon May 6 04:42:16 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600804133; cv=none; d=zohomail.com; s=zohoarc; b=K1kGWSewGOd2EkwM9nd0TQn1aMrEneDxSbWgqWst7BZQVdWBnQ1AMc0chdqNBga3YRqkn3NqWI8cOSOemPHVCSJI2MAXZNO8rKw0AkB3iSk/n+MGtesU1yIlVY3vXn01A8sda40XkbNi/SLg6UnPXZG3NflwVgJK/NEoJgCo3qc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600804133; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=HcylN3+ZJ6vZ/Mby0hLpsXmZsSXQu1h+AgSu1T22ggA=; b=M2fGB1TnkDxh2yfPem5rZ+wyyWdTV3A42FayVFAyi4WSKEHzrS3K77Igw1bM6MKNkho1c3Km2ZHPqceJ1TEWJyHXpbxVBK0Izdw72z536lXexDoryNGIHenHIBQD3JaboMw+hrHaHwjLsdPJ5gazxnyAT8ergkxiteDGpk8JWiY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600804133677987.8441464423236; Tue, 22 Sep 2020 12:48:53 -0700 (PDT) Received: from localhost ([::1]:33584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKoHU-0007Mw-Eo for importer@patchew.org; Tue, 22 Sep 2020 15:48:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKoGV-0006ZD-6G for qemu-devel@nongnu.org; Tue, 22 Sep 2020 15:47:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30986) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kKoGS-0003pc-NS for qemu-devel@nongnu.org; Tue, 22 Sep 2020 15:47:50 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-399-yRxv6HkxNA6yXNZOmrqNdw-1; Tue, 22 Sep 2020 15:47:40 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 744BA809AD1; Tue, 22 Sep 2020 19:47:39 +0000 (UTC) Received: from localhost (unknown [10.10.67.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F62D19D61; Tue, 22 Sep 2020 19:47:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600804067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HcylN3+ZJ6vZ/Mby0hLpsXmZsSXQu1h+AgSu1T22ggA=; b=bsRUPMvS2yn+tbUnTAQmisp2VM5DJlpbS6MVHpxBs9tOYuXJJg4/XQewIiMf4dcNDBmppe KaYcQmFt2w38/0Gua47GN1VfANVNpr1NYDoXPu4mjcTxvzdNhteaQcZ3neg/4/GJ8rUONj ABBS00GS/a4UBcyFYXgBKl0TT9PW52c= X-MC-Unique: yRxv6HkxNA6yXNZOmrqNdw-1 From: Eduardo Habkost To: qemu-devel@nongnu.org Subject: [PATCH] bios-tables-test: Remove kernel-irqchip=off option Date: Tue, 22 Sep 2020 15:47:32 -0400 Message-Id: <20200922194732.2100510-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 15:47:47 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.455, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , 1896263@bugs.launchpad.net, Thomas Huth , "Michael S. Tsirkin" , "Dr. David Alan Gilbert" , Stefan Hajnoczi , Paolo Bonzini , Igor Mammedov , Vitaly Kuznetsov Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" We don't need to use kernel-irqchip=3Doff for irq0 override if IRQ routing is supported by the host, which is the case since 2009 (IRQ routing was added to KVM in Linux v2.6.30). This is a more straightforward fix for Launchpad bug #1896263, as it doesn't require increasing the complexity of the MSR code. kernel-irqchip=3Doff is for debugging only and there's no need to increase the complexity of the code just to work around an issue that was already fixed in the kernel. Fixes: https://bugs.launchpad.net/bugs/1896263 Signed-off-by: Eduardo Habkost --- tests/qtest/bios-tables-test.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index a9c8d478aee..27e8f0a1cb7 100644 --- a/tests/qtest/bios-tables-test.c +++ b/tests/qtest/bios-tables-test.c @@ -663,8 +663,7 @@ static void test_acpi_one(const char *params, test_data= *data) data->uefi_fl1, data->uefi_fl2, data->cd, params ? params : ""= ); =20 } else { - /* Disable kernel irqchip to be able to override apic irq0. */ - args =3D g_strdup_printf("-machine %s,kernel-irqchip=3Doff %s -acc= el tcg " + args =3D g_strdup_printf("-machine %s %s -accel tcg " "-net none -display none %s " "-drive id=3Dhd0,if=3Dnone,file=3D%s,format=3Draw " "-device %s,drive=3Dhd0 ", --=20 2.26.2