From nobody Sun Nov 16 16:41:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600773059; cv=none; d=zohomail.com; s=zohoarc; b=R7vRif+FRkJ9rKPl6oTVMLqSIBqBBYamCqHQvz4tMGrWywp8Iw0XSqTZdLq9zWYQG92ETj4zzF/zG5i3DtqXw7OYCDoBr8iyccRXvB7iXsOZ87JvbHg+w6a6LE2tlu+dwj+n4vS4OGd/vEegISevu6eOxHOu2TilbUOJhPgVz0M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600773059; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Ea+fAxd76C35M69AMFmG807EWQmuEAGwHDLdotk1wII=; b=isUk7QJmesLdfaGiiN+8UNQgP5vCp2ImrWXy039x+MlD2bVxiNBhG99oOMFJp7HXAVAHFQEPI2kaFXsl+oe43BLFMlGuLmdz2RACrqc+HYB+mTdTRa1qPg+rycGVJgX8VIefwEIDewhB+PyPlln6CUipsn1+9EUmnQSmG8xOeD0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600773059631851.633061145041; Tue, 22 Sep 2020 04:10:59 -0700 (PDT) Received: from localhost ([::1]:37494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKgCI-0007AJ-Cs for importer@patchew.org; Tue, 22 Sep 2020 07:10:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKfsx-0001Ng-Dk for qemu-devel@nongnu.org; Tue, 22 Sep 2020 06:50:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34333) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kKfst-0000nP-ML for qemu-devel@nongnu.org; Tue, 22 Sep 2020 06:50:59 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-303-qR_5u4mlMg2ZWNeAQdcvqw-1; Tue, 22 Sep 2020 06:50:51 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 51EB91084C80; Tue, 22 Sep 2020 10:50:50 +0000 (UTC) Received: from localhost (ovpn-114-26.ams2.redhat.com [10.36.114.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CF27D5DA7B; Tue, 22 Sep 2020 10:50:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600771855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ea+fAxd76C35M69AMFmG807EWQmuEAGwHDLdotk1wII=; b=i4sKxCohazqmQlNoqB+lqm1+8+H4EcEPfT4abvEZj8Bjte+5YFsiMvPnD24XfuceWzJoFh wyCxq6XQvhXy/vxrI39CWAFDI09wVvCCrJVl8Dw6DQtzrfeTqxbIDTx22Dp0VVDnqdq1sI ZAtMRbeo6BsWyzpQD29hxQPDzMoyofg= X-MC-Unique: qR_5u4mlMg2ZWNeAQdcvqw-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH v2 16/20] storage-daemon: Call bdrv_close_all() on exit Date: Tue, 22 Sep 2020 12:49:28 +0200 Message-Id: <20200922104932.46384-17-mreitz@redhat.com> In-Reply-To: <20200922104932.46384-1-mreitz@redhat.com> References: <20200922104932.46384-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 00:31:51 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.455, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Otherwise, exports and block devices are not properly shut down and closed, unless the users explicitly issues blockdev-del and block-export-del commands for each of them. Signed-off-by: Max Reitz --- storage-daemon/qemu-storage-daemon.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/storage-daemon/qemu-storage-daemon.c b/storage-daemon/qemu-sto= rage-daemon.c index e6157ff518..0b6d469751 100644 --- a/storage-daemon/qemu-storage-daemon.c +++ b/storage-daemon/qemu-storage-daemon.c @@ -324,6 +324,9 @@ int main(int argc, char *argv[]) main_loop_wait(false); } =20 + bdrv_drain_all_begin(); + bdrv_close_all(); + monitor_cleanup(); qemu_chr_cleanup(); user_creatable_cleanup(); --=20 2.26.2