From nobody Sun Nov 16 16:39:11 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600772640; cv=none; d=zohomail.com; s=zohoarc; b=DXXzFfn7+c5Yv9zAu/KSvqeh/4oRyP3QhTw+56XBhi5zV6hwFjWODDxg+lo70RzkCDWPMWnYGvMCx/HIsEuUlgCNFCZpwSQF3BJGSTcaEcAdv6AfcVmppx8pH9TBerF1P0iZw/zs5ETh6KHKw5oY7k1E/3FNQZJ48oZq903YjsM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600772640; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bMqqcLr9JG95ly+lj7FE8wdO+45EOuRAVEGeYi7CymE=; b=XngY34+91XNVTW+RfteHTy/Zqbl0BkeT1sCFEUan1NcKr4Y5DkDKW/uT7nz02gPXXKcI6UEAcl0Hd8ifN1Ms9sYSVBfu/kQETg2kN770yb3ffaJMto2TTRwCfmDMReVMAAjLikjksYwPymjPMyffgHC76dj6AYL4BHJWWTVCPOE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600772640763580.6448409509751; Tue, 22 Sep 2020 04:04:00 -0700 (PDT) Received: from localhost ([::1]:48616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKg5S-0008EK-El for importer@patchew.org; Tue, 22 Sep 2020 07:03:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKfsS-0000ii-VZ for qemu-devel@nongnu.org; Tue, 22 Sep 2020 06:50:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59384) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kKfsR-0000ih-8k for qemu-devel@nongnu.org; Tue, 22 Sep 2020 06:50:28 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-13-gE7TE96RMXil7LJCTwV4yQ-1; Tue, 22 Sep 2020 06:50:22 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 32CED186841B; Tue, 22 Sep 2020 10:50:21 +0000 (UTC) Received: from localhost (ovpn-114-26.ams2.redhat.com [10.36.114.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D46177367E; Tue, 22 Sep 2020 10:50:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600771826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bMqqcLr9JG95ly+lj7FE8wdO+45EOuRAVEGeYi7CymE=; b=ed9xKkavhtZ1JXkLxetyaXYRUqcKR6FODwfTHXYHS1N47IR5OwLyiLOqUq6LMr/T9c5H32 gH7rOFEYixBLTIaw6ZmX4amULCC2DFzJo3vHhCD68n4nGAkly7gb8dw+IsPuJ9b61hAW7T tKpact/DOJTD3WRtdLVDStNEa3KDi+E= X-MC-Unique: gE7TE96RMXil7LJCTwV4yQ-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH v2 10/20] iotests/046: Avoid renaming images Date: Tue, 22 Sep 2020 12:49:22 +0200 Message-Id: <20200922104932.46384-11-mreitz@redhat.com> In-Reply-To: <20200922104932.46384-1-mreitz@redhat.com> References: <20200922104932.46384-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 00:31:51 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.455, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This generally does not work on non-file protocols. It is better to create the image with the final name from the start, and most tests do this already. Let 046 follow suit. Signed-off-by: Max Reitz --- tests/qemu-iotests/046 | 5 +++-- tests/qemu-iotests/046.out | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/046 b/tests/qemu-iotests/046 index 88b3363c19..40a9f30087 100755 --- a/tests/qemu-iotests/046 +++ b/tests/qemu-iotests/046 @@ -47,6 +47,8 @@ size=3D128M echo echo "=3D=3D creating backing file for COW tests =3D=3D" =20 +TEST_IMG_SAVE=3D$TEST_IMG +TEST_IMG=3D"$TEST_IMG.base" _make_test_img $size =20 backing_io() @@ -67,8 +69,7 @@ backing_io() =20 backing_io 0 32 write | $QEMU_IO "$TEST_IMG" | _filter_qemu_io =20 -mv "$TEST_IMG" "$TEST_IMG.base" - +TEST_IMG=3D$TEST_IMG_SAVE _make_test_img -b "$TEST_IMG.base" -F $IMGFMT 6G =20 echo diff --git a/tests/qemu-iotests/046.out b/tests/qemu-iotests/046.out index b022bcddd5..66ad987ab3 100644 --- a/tests/qemu-iotests/046.out +++ b/tests/qemu-iotests/046.out @@ -1,7 +1,7 @@ QA output created by 046 =20 =3D=3D creating backing file for COW tests =3D=3D -Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D134217728 +Formatting 'TEST_DIR/t.IMGFMT.base', fmt=3DIMGFMT size=3D134217728 wrote 65536/65536 bytes at offset 0 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) wrote 65536/65536 bytes at offset 65536 --=20 2.26.2