From nobody Sun Apr 28 11:15:16 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1600768648; cv=none; d=zohomail.com; s=zohoarc; b=msVAfsOGGT2UGhp6MEm8DcOT6khR+nauRND9oqqe2BzZlQa9P4O1oGMiAwvlZXFzcpQjquaJBGIRLNTgykE0ozhEoXIFp3ftSnVc10j4oyxzt1rkgUMuHlDtCEOJNnEbN7Ng5DFZVGa+cchAoUHZPrq4La075AAU1MKpqdfEKx0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600768648; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UBCedFPOa/poaLuTkZQB+bDqC344DTgf8r4X0KHTh7w=; b=j5ojNnh5Rb7KaAE5fJEg5o08dkt89glru6Mxs9DzCqX7GkeUiolo8XQhmHSptCF5LHub4ofqj2LhYF3/rfjQLIw+dt0ZiDcdZsGYiGKuoZoCs2HP/Z8lKypbksDjbQT/ZWpqr/QSeKtAmGlBdH2iDXDNAXmcZ+de3NoBDmdk1hQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600768648501878.7572737111622; Tue, 22 Sep 2020 02:57:28 -0700 (PDT) Received: from localhost ([::1]:36628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKf38-0002re-61 for importer@patchew.org; Tue, 22 Sep 2020 05:57:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKf1e-0000d5-Aj for qemu-devel@nongnu.org; Tue, 22 Sep 2020 05:55:54 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:51556 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKf1a-0001kD-Qt for qemu-devel@nongnu.org; Tue, 22 Sep 2020 05:55:54 -0400 Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 22 Sep 2020 17:55:41 +0800 Received: from G08CNEXMBPEKD06.g08.fujitsu.local (unknown [10.167.33.206]) by cn.fujitsu.com (Postfix) with ESMTP id D49C448990F1; Tue, 22 Sep 2020 17:55:39 +0800 (CST) Received: from G08CNEXCHPEKD05.g08.fujitsu.local (10.167.33.203) by G08CNEXMBPEKD06.g08.fujitsu.local (10.167.33.206) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 22 Sep 2020 17:55:37 +0800 Received: from FNSTPC.g08.fujitsu.local (10.167.226.45) by G08CNEXCHPEKD05.g08.fujitsu.local (10.167.33.209) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 22 Sep 2020 17:55:37 +0800 X-IronPort-AV: E=Sophos;i="5.77,290,1596470400"; d="scan'208";a="99500710" From: Li Zhijian To: , Subject: [PATCH 1/3] colo-compare: return -1 if no packet is queued Date: Tue, 22 Sep 2020 17:55:23 +0800 Message-ID: <20200922095525.4081603-2-lizhijian@cn.fujitsu.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200922095525.4081603-1-lizhijian@cn.fujitsu.com> References: <20200922095525.4081603-1-lizhijian@cn.fujitsu.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-yoursite-MailScanner-ID: D49C448990F1.ABB47 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: lizhijian@cn.fujitsu.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=183.91.158.132; envelope-from=lizhijian@cn.fujitsu.com; helo=heian.cn.fujitsu.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 05:55:42 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Li Zhijian Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Return 0 will trigger a packet comparison Signed-off-by: Li Zhijian --- net/colo-compare.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/colo-compare.c b/net/colo-compare.c index 3a45d64175..039b515611 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -289,6 +289,7 @@ static int packet_enqueue(CompareState *s, int mode, Co= nnection **con) "queue size too big, drop packet"); packet_destroy(pkt, NULL); pkt =3D NULL; + return -1; } =20 *con =3D conn; --=20 2.28.0 From nobody Sun Apr 28 11:15:16 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1600768606; cv=none; d=zohomail.com; s=zohoarc; b=Jgw3nNTcf7We4XgPoJLpytqPsFqwwnDlS08oQa0oXgXbj8erBLdNYKMfNNeTw867Zk6EnmvNALHEDInxeyuwXLaj/GAEwVvYzcSrrhvxP+wpvGJOv9vTF31mBnRNGP1uzw0JLz4yuZ1bU0V7GOHoKLkR88Z7PupN455U6NgF7K0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600768606; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=V3IM46okHw/vl1ZMnD4pOuCPRP/QQsVns8RF7xrKKhM=; b=a3Ou14mpqAvaEDs2Jv76/vUBJZzatq4eRU6rs9Un5nXfzJ8BE9YB9k4LNWoS//PYyz9tF6ynnxvlmhPgQzqPdNGqebVg1hFrCJgc4DO02v9ifrWumTkrx5F8NZzjhK6cuWGEHPSsxjmxtkdwZHXmwaTDBjMWFVX7/PCYpYkYjkE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160076860652933.139579360012476; Tue, 22 Sep 2020 02:56:46 -0700 (PDT) Received: from localhost ([::1]:34210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKf2T-0001rU-8J for importer@patchew.org; Tue, 22 Sep 2020 05:56:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKf1d-0000at-64 for qemu-devel@nongnu.org; Tue, 22 Sep 2020 05:55:53 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:51551 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKf1Z-0001hD-U8 for qemu-devel@nongnu.org; Tue, 22 Sep 2020 05:55:52 -0400 Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 22 Sep 2020 17:55:41 +0800 Received: from G08CNEXMBPEKD05.g08.fujitsu.local (unknown [10.167.33.204]) by cn.fujitsu.com (Postfix) with ESMTP id 351FF48990F2; Tue, 22 Sep 2020 17:55:41 +0800 (CST) Received: from G08CNEXCHPEKD05.g08.fujitsu.local (10.167.33.203) by G08CNEXMBPEKD05.g08.fujitsu.local (10.167.33.204) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 22 Sep 2020 17:55:40 +0800 Received: from FNSTPC.g08.fujitsu.local (10.167.226.45) by G08CNEXCHPEKD05.g08.fujitsu.local (10.167.33.209) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 22 Sep 2020 17:55:39 +0800 X-IronPort-AV: E=Sophos;i="5.77,290,1596470400"; d="scan'208";a="99500709" From: Li Zhijian To: , Subject: [PATCH 2/3] colo-compare: fix missing compare_seq initialization Date: Tue, 22 Sep 2020 17:55:24 +0800 Message-ID: <20200922095525.4081603-3-lizhijian@cn.fujitsu.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200922095525.4081603-1-lizhijian@cn.fujitsu.com> References: <20200922095525.4081603-1-lizhijian@cn.fujitsu.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-yoursite-MailScanner-ID: 351FF48990F2.AA95D X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: lizhijian@cn.fujitsu.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=183.91.158.132; envelope-from=lizhijian@cn.fujitsu.com; helo=heian.cn.fujitsu.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 05:55:42 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Li Zhijian Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Signed-off-by: Li Zhijian Reviewed-by: Zhang Chen --- net/colo.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/colo.c b/net/colo.c index a6c66d829a..ef00609848 100644 --- a/net/colo.c +++ b/net/colo.c @@ -133,14 +133,11 @@ void reverse_connection_key(ConnectionKey *key) =20 Connection *connection_new(ConnectionKey *key) { - Connection *conn =3D g_slice_new(Connection); + Connection *conn =3D g_slice_new0(Connection); =20 conn->ip_proto =3D key->ip_proto; conn->processing =3D false; - conn->offset =3D 0; conn->tcp_state =3D TCPS_CLOSED; - conn->pack =3D 0; - conn->sack =3D 0; g_queue_init(&conn->primary_list); g_queue_init(&conn->secondary_list); =20 --=20 2.28.0 From nobody Sun Apr 28 11:15:16 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1600768739; cv=none; d=zohomail.com; s=zohoarc; b=HPTwMi5RX/O/tEdV3KqS4IzemnSnAmIIhc8t2jbTyYBeKYnj39QOvYvd/FhaYVxODzpYVkma91f4hnSqQuW4VfJDrmRAamcR/71b/y3fU3Sa+cT9JEt8+V1tBH7xaDY7qRBWKyGRIZa9C+6sjjVPeBbRkt+ALnmmpcwo6xgwdY8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600768739; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PKttcRAjifbgRgl/oHN/o0TWzrqCljp4netDhdjAJko=; b=k9bClsmqyxx5NjVsCsRyEpBQypbBGWeL2LI1X9TTGrXeXqJ8A8zl8ADC/vmI7f+plwXH7t4hgIYIVvDp9iA9CDaf1+UUBcM4O8WjMsijlksaw7XWsbxjKHhEVBToG3e3D6x2RT7/CpVaqzWcVTKSNttQOAeoO+ZOMGy71sVi0oE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600768739808661.5622622571789; Tue, 22 Sep 2020 02:58:59 -0700 (PDT) Received: from localhost ([::1]:41750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKf4c-0004vE-Hv for importer@patchew.org; Tue, 22 Sep 2020 05:58:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKf1f-0000g9-Oh for qemu-devel@nongnu.org; Tue, 22 Sep 2020 05:55:55 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:51551 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKf1d-0001hD-V6 for qemu-devel@nongnu.org; Tue, 22 Sep 2020 05:55:55 -0400 Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 22 Sep 2020 17:55:47 +0800 Received: from G08CNEXMBPEKD06.g08.fujitsu.local (unknown [10.167.33.206]) by cn.fujitsu.com (Postfix) with ESMTP id F1E7948990CB; Tue, 22 Sep 2020 17:55:42 +0800 (CST) Received: from G08CNEXCHPEKD05.g08.fujitsu.local (10.167.33.203) by G08CNEXMBPEKD06.g08.fujitsu.local (10.167.33.206) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 22 Sep 2020 17:55:40 +0800 Received: from FNSTPC.g08.fujitsu.local (10.167.226.45) by G08CNEXCHPEKD05.g08.fujitsu.local (10.167.33.209) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 22 Sep 2020 17:55:41 +0800 X-IronPort-AV: E=Sophos;i="5.77,290,1596470400"; d="scan'208";a="99500714" From: Li Zhijian To: , Subject: [PATCH 3/3] colo-compare: check mark in mutual exclusion Date: Tue, 22 Sep 2020 17:55:25 +0800 Message-ID: <20200922095525.4081603-4-lizhijian@cn.fujitsu.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200922095525.4081603-1-lizhijian@cn.fujitsu.com> References: <20200922095525.4081603-1-lizhijian@cn.fujitsu.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-yoursite-MailScanner-ID: F1E7948990CB.AC3C0 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: lizhijian@cn.fujitsu.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=183.91.158.132; envelope-from=lizhijian@cn.fujitsu.com; helo=heian.cn.fujitsu.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 05:55:42 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Li Zhijian Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Signed-off-by: Li Zhijian Reviewed-by: Zhang Chen --- net/colo-compare.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 039b515611..19633fc684 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -481,13 +481,11 @@ sec: colo_release_primary_pkt(s, ppkt); g_queue_push_head(&conn->secondary_list, spkt); goto pri; - } - if (mark =3D=3D COLO_COMPARE_FREE_SECONDARY) { + } else if (mark =3D=3D COLO_COMPARE_FREE_SECONDARY) { conn->compare_seq =3D spkt->seq_end; packet_destroy(spkt, NULL); goto sec; - } - if (mark =3D=3D (COLO_COMPARE_FREE_PRIMARY | COLO_COMPARE_FREE_SEC= ONDARY)) { + } else if (mark =3D=3D (COLO_COMPARE_FREE_PRIMARY | COLO_COMPARE_F= REE_SECONDARY)) { conn->compare_seq =3D ppkt->seq_end; colo_release_primary_pkt(s, ppkt); packet_destroy(spkt, NULL); --=20 2.28.0