From nobody Mon Feb 9 08:10:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600727246; cv=none; d=zohomail.com; s=zohoarc; b=WtR06v0eJE2aymo5yaXPLrlJvPsqMvgjcHjpg1vdIjrDPfH1WFNcFTQ/ZwU+gbTyhQVZBgVIilsmJEdpUCZLlBBujKhtcqQueYPdAfmR48VKBI8jK4ojBQWo4h3MrOUe+WcymSx4wM4xdaX0aAvsTnSBX3HF+gXXfgIW5KRpbUQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600727246; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+Uw2orecZVZm7IdW6a8lhZh1dRtMCA4m8TB4GxCPuOg=; b=QKnH+HiBg7Retr9J3LyGsAdlYBkl0ALNy9LjDbYKznvZ5DRlNV0+J81hhJ2sEeqty6f5iDD70o5ABgkpDvFFnOjO390FEHRtxy+o9A2uWPqKovyEmxQCpoDHlrR9sIYrJCnPvTOKwDWUiZqfSyEM0YHNEBpNVO2nb2SPr39L76A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160072724623548.10053843892058; Mon, 21 Sep 2020 15:27:26 -0700 (PDT) Received: from localhost ([::1]:58722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKUHM-0004LA-9n for importer@patchew.org; Mon, 21 Sep 2020 18:27:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKU22-0000QV-N1 for qemu-devel@nongnu.org; Mon, 21 Sep 2020 18:11:34 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:26409 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kKU1v-0001dK-6J for qemu-devel@nongnu.org; Mon, 21 Sep 2020 18:11:33 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-202-oL7LIBTkOLGi8x5LpRMzvg-1; Mon, 21 Sep 2020 18:11:24 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0F489873079; Mon, 21 Sep 2020 22:11:23 +0000 (UTC) Received: from localhost (unknown [10.10.67.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB38C5D9CD; Mon, 21 Sep 2020 22:11:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600726285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Uw2orecZVZm7IdW6a8lhZh1dRtMCA4m8TB4GxCPuOg=; b=D0b7513rMWSFy2FFI7Zsp+af1M4c8H2tcIGLzxW5WFmrpj+XBD7aDUj1KXYi8yc+oQi1wk 2qjDrG8tumPNgZTTtEPaDaDxfdALv1ergdI6LmXPEodtZaW9+tvwmqLFILd1iIvEcRdgWA luOgpjgCMwRuCyIU3eqq5RdvvH0mLhA= X-MC-Unique: oL7LIBTkOLGi8x5LpRMzvg-1 From: Eduardo Habkost To: qemu-devel@nongnu.org Subject: [PATCH 14/24] i386: Register feature bit properties as class properties Date: Mon, 21 Sep 2020 18:10:35 -0400 Message-Id: <20200921221045.699690-15-ehabkost@redhat.com> In-Reply-To: <20200921221045.699690-1-ehabkost@redhat.com> References: <20200921221045.699690-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=ehabkost@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/21 16:39:08 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.455, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Paolo Bonzini , "Daniel P. Berrange" , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov --- Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: qemu-devel@nongnu.org --- target/i386/cpu.c | 33 ++++++++++++++++----------------- 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 66792f28ba7..1aba87e0a5b 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -6819,16 +6819,17 @@ static void x86_cpu_release_bit_prop(Object *obj, c= onst char *name, * multiple bits in the same FeatureWord. In that case, the getter will re= turn * true only if all bits are set. */ -static void x86_cpu_register_bit_prop(X86CPU *cpu, +static void x86_cpu_register_bit_prop(X86CPUClass *xcc, const char *prop_name, FeatureWord w, int bitnr) { + ObjectClass *oc =3D OBJECT_CLASS(xcc); BitProperty *fp; ObjectProperty *op; uint64_t mask =3D (1ULL << bitnr); =20 - op =3D object_property_find(OBJECT(cpu), prop_name, NULL); + op =3D object_class_property_find(oc, prop_name, NULL); if (op) { fp =3D op->opaque; assert(fp->w =3D=3D w); @@ -6837,14 +6838,14 @@ static void x86_cpu_register_bit_prop(X86CPU *cpu, fp =3D g_new0(BitProperty, 1); fp->w =3D w; fp->mask =3D mask; - object_property_add(OBJECT(cpu), prop_name, "bool", - x86_cpu_get_bit_prop, - x86_cpu_set_bit_prop, - x86_cpu_release_bit_prop, fp); + object_class_property_add(oc, prop_name, "bool", + x86_cpu_get_bit_prop, + x86_cpu_set_bit_prop, + x86_cpu_release_bit_prop, fp); } } =20 -static void x86_cpu_register_feature_bit_props(X86CPU *cpu, +static void x86_cpu_register_feature_bit_props(X86CPUClass *xcc, FeatureWord w, int bitnr) { @@ -6863,7 +6864,7 @@ static void x86_cpu_register_feature_bit_props(X86CPU= *cpu, /* aliases don't use "|" delimiters anymore, they are registered * manually using object_property_add_alias() */ assert(!strchr(name, '|')); - x86_cpu_register_bit_prop(cpu, name, w, bitnr); + x86_cpu_register_bit_prop(xcc, name, w, bitnr); } =20 #if !defined(CONFIG_USER_ONLY) @@ -6917,7 +6918,6 @@ static void x86_cpu_initfn(Object *obj) X86CPU *cpu =3D X86_CPU(obj); X86CPUClass *xcc =3D X86_CPU_GET_CLASS(obj); CPUX86State *env =3D &cpu->env; - FeatureWord w; =20 env->nr_dies =3D 1; cpu_set_cpustate_pointers(cpu); @@ -6929,14 +6929,6 @@ static void x86_cpu_initfn(Object *obj) x86_cpu_get_feature_words, NULL, NULL, (void *)cpu->filtered_features); =20 - for (w =3D 0; w < FEATURE_WORDS; w++) { - int bitnr; - - for (bitnr =3D 0; bitnr < 64; bitnr++) { - x86_cpu_register_feature_bit_props(cpu, w, bitnr); - } - } - object_property_add_alias(obj, "sse3", obj, "pni"); object_property_add_alias(obj, "pclmuldq", obj, "pclmulqdq"); object_property_add_alias(obj, "sse4-1", obj, "sse4.1"); @@ -7221,6 +7213,7 @@ static void x86_cpu_common_class_init(ObjectClass *oc= , void *data) X86CPUClass *xcc =3D X86_CPU_CLASS(oc); CPUClass *cc =3D CPU_CLASS(oc); DeviceClass *dc =3D DEVICE_CLASS(oc); + FeatureWord w; =20 device_class_set_parent_realize(dc, x86_cpu_realizefn, &xcc->parent_realize); @@ -7310,6 +7303,12 @@ static void x86_cpu_common_class_init(ObjectClass *o= c, void *data) x86_cpu_get_crash_info_qom, NULL, NULL, NULL= ); #endif =20 + for (w =3D 0; w < FEATURE_WORDS; w++) { + int bitnr; + for (bitnr =3D 0; bitnr < 64; bitnr++) { + x86_cpu_register_feature_bit_props(xcc, w, bitnr); + } + } } =20 static const TypeInfo x86_cpu_type_info =3D { --=20 2.26.2