From nobody Tue Feb 10 14:32:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.65 as permitted sender) client-ip=209.85.128.65; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f65.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1600660387; cv=none; d=zohomail.com; s=zohoarc; b=d1pdme+c74ViOAvqOdopK5cBPysCo0fv96MBfI0kwo2rOY+KEr/YcYxqhGmKUrhFMTq6/zCIG1SifIJsWYRYhbjB/4WVIn/OGjy10yPyTrZfB9DzTrTtFbHUmEajWD18/qZWNgm5MRAeUSD8ZAckh5vpl8danY7Al0VakBRSxO0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600660387; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Pkq0sHrTv5/xZaj/954kaRSp726GwaYvD8ODlxKHlR0=; b=RfJkr09Weimyf+FPBrpf1Ucrx0potoyq9vxGv1dms+qrhRBvVI0p6RcITWaEd4avAmmyf437IrC63tK20tXKF/g86o0prjUKPiLLWU6stdKZE7WkiREVF+i1vWdHty5ZARBzlO+wJ67nfzRpRX5eQKviDpVnEd+iMn1vqQByRgE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.zohomail.com with SMTPS id 1600660387954858.0936984348567; Sun, 20 Sep 2020 20:53:07 -0700 (PDT) Received: by mail-wm1-f65.google.com with SMTP id y15so11042467wmi.0 for ; Sun, 20 Sep 2020 20:53:07 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (65.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.65]) by smtp.gmail.com with ESMTPSA id a17sm19633754wra.24.2020.09.20.20.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Sep 2020 20:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Pkq0sHrTv5/xZaj/954kaRSp726GwaYvD8ODlxKHlR0=; b=Go1ncPH9NLXvTxnZqohu+W7MLcTROVQi7HIKJkmLom6YO3MuX9HIJL0Wuai1L2ym5s BlV/C0iVBI6uJxXn0ua4CKeV3mXBJKlG0R5cLsfkGW7r3Sak3uJiRfWzxGrRhmNcoSTZ XUtCC0T/8L2TvErqS+tFcy+cI1KjA/ePGKwwmBtvDxwGz5iY++ftoK/WHvQEu2+GR1R9 CVwZKG/8vnlTnFu36Ra0xb4nLuA1ApLKY/qq4KZDmzu13FFTys6be0M53HHWiyvw/qYl I+MXP++AOOA5cG8BXW2jWEmTq8sqX1LG1NsMZZFBvHEUDGvv7sPTv7x82Bl4DaRsEqkJ OGoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Pkq0sHrTv5/xZaj/954kaRSp726GwaYvD8ODlxKHlR0=; b=IUhBD6p1Xh+osihypFvX2WVIk+8ijB4Vid4kKMO37149SOUADh7Z2zhB8oEFxrWPkn t2AY+pqijeoogX77fWOflHkCrvLMG/dwVGHlgLap7ocuXxAO7PhmaQcGDi/I5KL0Uh6m towU1iL889Jv5D01LpV3SzicuXIulMndaYbXJBMTD+XKnuBPKO62JPzwbdr9M8mGB7Wb K9PTZUFFYILUbM8AXNpZwh5zAmUyVCKJO1wCp4YwDrO+gmLXev0n4XAqNpILcWz8FjhP o3I9y+6wRI2kmND4VMVkT9dzp+ONxC1xX/HaiEm/E0uUJ4tJWhsxRBSVp9YsZI8FyJEt MHGg== X-Gm-Message-State: AOAM533IyWUrZFBeUZUU1DBXKQjaHTLu8NqJkJvvnqvUhBW4FTgwGxdA cmuZCe5fI1CqrqnzoMnzfk8= X-Google-Smtp-Source: ABdhPJwcgXuVOaOuuO2VfzfWjyr5YfxIrtxfuIFAtSTjOnFZH52u/dx0jkbB/nFFlMU1jcX8I0Ei0A== X-Received: by 2002:a1c:9885:: with SMTP id a127mr27720249wme.8.1600660386222; Sun, 20 Sep 2020 20:53:06 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Andrew Baumann , Luc Michel , qemu-arm@nongnu.org, Peter Maydell , Niek Linnenbank , Paul Zimmerman , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 5/5] hw/arm/bcm2835_peripherals: Correctly wire the SYS_timer IRQs Date: Mon, 21 Sep 2020 05:52:57 +0200 Message-Id: <20200921035257.434532-6-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200921035257.434532-1-f4bug@amsat.org> References: <20200921035257.434532-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The SYS_timer is not directly wired to the ARM core, but to the SoC (peripheral) interrupt controller. Fixes: 0e5bbd74064 ("hw/arm/bcm2835_peripherals: Use the SYS_timer") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Luc Michel --- hw/arm/bcm2835_peripherals.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c index 15c5c72e465..48909a43c32 100644 --- a/hw/arm/bcm2835_peripherals.c +++ b/hw/arm/bcm2835_peripherals.c @@ -171,8 +171,17 @@ static void bcm2835_peripherals_realize(DeviceState *d= ev, Error **errp) memory_region_add_subregion(&s->peri_mr, ST_OFFSET, sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->systmr), 0)); sysbus_connect_irq(SYS_BUS_DEVICE(&s->systmr), 0, - qdev_get_gpio_in_named(DEVICE(&s->ic), BCM2835_IC_ARM_IRQ, - INTERRUPT_ARM_TIMER)); + qdev_get_gpio_in_named(DEVICE(&s->ic), BCM2835_IC_GPU_IRQ, + INTERRUPT_TIMER0)); + sysbus_connect_irq(SYS_BUS_DEVICE(&s->systmr), 1, + qdev_get_gpio_in_named(DEVICE(&s->ic), BCM2835_IC_GPU_IRQ, + INTERRUPT_TIMER1)); + sysbus_connect_irq(SYS_BUS_DEVICE(&s->systmr), 2, + qdev_get_gpio_in_named(DEVICE(&s->ic), BCM2835_IC_GPU_IRQ, + INTERRUPT_TIMER2)); + sysbus_connect_irq(SYS_BUS_DEVICE(&s->systmr), 3, + qdev_get_gpio_in_named(DEVICE(&s->ic), BCM2835_IC_GPU_IRQ, + INTERRUPT_TIMER3)); =20 /* UART0 */ qdev_prop_set_chr(DEVICE(&s->uart0), "chardev", serial_hd(0)); --=20 2.26.2