From nobody Thu May 16 01:45:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) client-ip=209.85.221.66; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f66.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1600617225; cv=none; d=zohomail.com; s=zohoarc; b=Fg1VsnLxvZ+6txrmUtdZtmGKXebQk89uZH6VVkLDu7k2w+8/Yf5d6g+NNk1s/5y5s4mdw64PZYuMTR4O/YbM6mMBJeY9FYfIvSHvmn0Udu15ceQPLBs5Xdg7gTHBv8yGaKNIerxma/vgsI1yi66OGvBF/aGzz+BmpmpIx8uMWIM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600617225; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=NpNKL2s2eFl4dsz+xs9FYknazCQiYfioYg8R6EyiOVA=; b=jPxFZc8CW1xTLS1f+8Ehqfviuia8FY/xr3PysztvsiZBngJznKl5Ia5qbOEeB8X4qskCYtOSdhJXzI3w9c2Dsxf7sodWyKZu9ZHAJY3H3dRbnDwOWxTvxMzFXoiaxEVfaQyHR6sdiprRytKDsoQSc+CzVK2HcsjzMbcfb9rc0kM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.zohomail.com with SMTPS id 160061722507518.074278828181832; Sun, 20 Sep 2020 08:53:45 -0700 (PDT) Received: by mail-wr1-f66.google.com with SMTP id z4so10254395wrr.4 for ; Sun, 20 Sep 2020 08:53:44 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (65.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.65]) by smtp.gmail.com with ESMTPSA id n2sm16846253wma.29.2020.09.20.08.53.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Sep 2020 08:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NpNKL2s2eFl4dsz+xs9FYknazCQiYfioYg8R6EyiOVA=; b=jtHzzb1BDOKKKsMbLlzQTU6FIZqPekXYgq1Af5SfIgEWvaQtAG2Bio6V05oDD8+dB7 rVBFAeSl59TY0KI0FYUhUA6cDlOHR2EShT4qjyBh1US4QDXZUuV6wssaOG+XlOwyi1yS BShbEOu2U8f/P3x/uTCO8xgb6QdfktB+FQN3uT0DSQxQ/+dod3YawpqAL6Bztoh82o2D RhGg45P0gVZn3s4nq1cU9NRltolIjhphG8GXRvpUP+81cOXncTu7xe7kqzTr1WdGBVQe dkFkxhqcAQF80ZBrovdLiuYjpIjPXY5VDYAWOvGRrTh8pWbFh9f4aBk64apcFYkkPZXE +Ufw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=NpNKL2s2eFl4dsz+xs9FYknazCQiYfioYg8R6EyiOVA=; b=rBoaK+ktqH7M9Ncn2XMn1Wx6j6jNJHRnPebTUlauqgZ/XqeMaxTst0HhfxcvQ21Blf K60tuxcPAWTpvuEU06Lw60OhMagtWHfRMtlgM+sNhhbfZeeWySOxIYaPT5wdSfmt5dVx qydQUPGKrRXMWgYs0pm1jQHm/Ltgu9Ju5gnOjkj6ZsgqRi3E6AXnB0N5pdhWQu9SIPlD 88KbhbwzB+G/uTHNswd+n28wpJJpdfMMBSqlv/aspMBPiSGEjT5z+BBkavA3251WaM/a zJ+rWOXIixu4MO4YL0cfdcrv/xw0AZiNsLxX/XyeGV/LiWnHEoUs0eI+XY+pdLtqD35r gbYA== X-Gm-Message-State: AOAM530+KigNzmRyYn5aCegUbAKkQ+iLPC5Qw3+sLlci+sf65jAAKU02 idg1tavWc2y+JZeJ9IOF3a4= X-Google-Smtp-Source: ABdhPJyk4TPdjyUfSnhaqd5M22ij/B/DvIhR505DWBCmmT5jKFAaqJF/P6iTocDxsYaeGSIlBTLURg== X-Received: by 2002:a5d:6547:: with SMTP id z7mr47814087wrv.322.1600617223133; Sun, 20 Sep 2020 08:53:43 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Eduardo Habkost , Paolo Bonzini , qemu-trivial@nongnu.org, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] qom: Improve error message displayed with missing object properties Date: Sun, 20 Sep 2020 17:53:40 +0200 Message-Id: <20200920155340.401482-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Instead of only displaying the property missing, also display the object name. This help developer to quickly figure out the mistake without opening a debugger. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Paolo Bonzini Reviewed-by: Li Qiang --- qom/object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c index 387efb25ebe..257914b1fe3 100644 --- a/qom/object.c +++ b/qom/object.c @@ -1259,7 +1259,8 @@ ObjectProperty *object_property_find(Object *obj, con= st char *name, return prop; } =20 - error_setg(errp, "Property '.%s' not found", name); + error_setg(errp, "Property '%s.%s' not found", + object_get_typename(obj), name); return NULL; } =20 --=20 2.26.2