From nobody Thu May 16 22:07:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600615294; cv=none; d=zohomail.com; s=zohoarc; b=lBcpCm7VCVJ7LmMdx4YmL4W7N4T96SauKCTkR3Y95D+qCzkASXyL3bEm4dtZ9l6NKEwin41XiBq5wSvYY6/LoV8segVX59aIRFec78c932xokytlHs6wrVCtnKSfBpeBl4E9KbX60MftV+lzp0uXkMF5rtCwcoyzbDHPNzK+v9s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600615294; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=fPXueWttktEUjcOPlrIesR5oL3s/6sAM6uv0WPBOABU=; b=GcFHOoJlg7Fb9G1/GKjLJ4FzLCjLmqBI/4xKF+Q5x0gFAUmvSGoKMZFzt5SHPOP91eeKgKBhK7ygYL6xAQgnyYD+aOcAGw+pm5CU0nq6yHNuNDC+uKe/SwBLdFV1NQWQLOnvs82/5/ho+7ftVmSCJtbSfxV1FA3SzKMlZcrsxrA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600615294118294.5952187211286; Sun, 20 Sep 2020 08:21:34 -0700 (PDT) Received: from localhost ([::1]:60642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kK19g-0001zN-29 for importer@patchew.org; Sun, 20 Sep 2020 11:21:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kK18r-0001ZJ-I8 for qemu-devel@nongnu.org; Sun, 20 Sep 2020 11:20:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:22418) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kK18n-0008Ll-1p for qemu-devel@nongnu.org; Sun, 20 Sep 2020 11:20:41 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-408-J_9zU-ooOSa1QuDFThU_XA-1; Sun, 20 Sep 2020 11:20:30 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 00B2110BBEC0 for ; Sun, 20 Sep 2020 15:20:30 +0000 (UTC) Received: from thinkpad.redhat.com (ovpn-113-15.ams2.redhat.com [10.36.113.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 711325576A; Sun, 20 Sep 2020 15:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600615232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fPXueWttktEUjcOPlrIesR5oL3s/6sAM6uv0WPBOABU=; b=S6izdwyp3VM/Qu1wP4+W30PcfkABpChV0x8nQz4OLsSVUds+sVhuDhIhL7h2sQ9QxNz4Xd aqKhq2J6Em9g0Aj8SQSS8zHxIeu/BLRKFrUU8e9EKvgbS2EO1vP5kqyFG4MJ2YnI/eL9mv eDjRAkjAPbAsz1q+TxWh0TObAIqWG8A= X-MC-Unique: J_9zU-ooOSa1QuDFThU_XA-1 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PATCH] vhost-vdpa: remove useless variable Date: Sun, 20 Sep 2020 17:20:24 +0200 Message-Id: <20200920152024.860172-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lvivier@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=lvivier@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/20 11:14:48 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -45 X-Spam_score: -4.6 X-Spam_bar: ---- X-Spam_report: (-4.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.501, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Jason Wang , Cindy Lu , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" in vhost_vdpa_listener_region_del(), try_unmap is always true and so, vhost_vdpa_dma_unmap() is always called. We can remove the variable Signed-off-by: Laurent Vivier Reviewed-by: Li Qiang Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/virtio/vhost-vdpa.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index 4580f3efd8a2..c6cae6a6cabf 100644 --- a/hw/virtio/vhost-vdpa.c +++ b/hw/virtio/vhost-vdpa.c @@ -153,7 +153,6 @@ static void vhost_vdpa_listener_region_del(MemoryListen= er *listener, hwaddr iova; Int128 llend, llsize; int ret; - bool try_unmap =3D true; =20 if (vhost_vdpa_listener_skipped_section(section)) { return; @@ -176,11 +175,9 @@ static void vhost_vdpa_listener_region_del(MemoryListe= ner *listener, =20 llsize =3D int128_sub(llend, int128_make64(iova)); =20 - if (try_unmap) { - ret =3D vhost_vdpa_dma_unmap(v, iova, int128_get64(llsize)); - if (ret) { - error_report("vhost_vdpa dma unmap error!"); - } + ret =3D vhost_vdpa_dma_unmap(v, iova, int128_get64(llsize)); + if (ret) { + error_report("vhost_vdpa dma unmap error!"); } =20 memory_region_unref(section->mr); --=20 2.26.2