From nobody Sun Nov 16 12:25:01 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600531099; cv=none; d=zohomail.com; s=zohoarc; b=S9MmY0vSsObbgcPaV67bepB69un/jvaaL3A0PKTDf3weqXkaAisqC/I0f1ujgejczQg5CxRsRjuS7uAdHjoUK+9ko6UDk3G+GntUGUQgTEf688dir+M64XdHLF46smi4D51OdWrOtJlwB3/ON9WPW28PfEf+TBPSKRspOhOUPsU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600531099; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=8qTAIJZyzHI7wNgfQstf4zVGPe6N+ZPUdhocNqI3z0M=; b=giKEM6wM4FSCsw8x/PX6wwqA8DDyt98MK+kBsurElrLjRC2Q00Qa5OUgPAlXIYNkhERoOboLQV4iAFO0W2puO0wodA/f9rNqpzXC8j2FKoTNx+WGQ7c8zJDmngk7gf+nIBmy4nis50977dMvGCCIaKgDKSKsDcus1ogoBpiIHv8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600531099470399.43349433384674; Sat, 19 Sep 2020 08:58:19 -0700 (PDT) Received: from localhost ([::1]:52930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJfFh-0004Ia-Pw for importer@patchew.org; Sat, 19 Sep 2020 11:58:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJfEL-0003SD-9R for qemu-devel@nongnu.org; Sat, 19 Sep 2020 11:56:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:41108) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kJfEI-000797-8i for qemu-devel@nongnu.org; Sat, 19 Sep 2020 11:56:52 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-54-rqfZCbBMOdmc__g7p5Re6Q-1; Sat, 19 Sep 2020 11:56:41 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 36BBA801AC8; Sat, 19 Sep 2020 15:56:40 +0000 (UTC) Received: from virtlab701.virt.lab.eng.bos.redhat.com (virtlab701.virt.lab.eng.bos.redhat.com [10.19.152.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id E2DBE5576A; Sat, 19 Sep 2020 15:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600531005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8qTAIJZyzHI7wNgfQstf4zVGPe6N+ZPUdhocNqI3z0M=; b=eUmtfSEzf88Abfw5+49u0eebJXr/JrTZvFZcmyh6vO30kKT+Tt4WjJncaVgArGJ/gAaRr/ KrtENYaCC0A70bpBdKoOQDPiptan/p/i0Fzf4hEfSBBVaBF5v7rqxxTUpunnvWEzo+dB8a +iCVN6sPEQlvR2zdNqcujt9cWqkuwEs= X-MC-Unique: rqfZCbBMOdmc__g7p5Re6Q-1 From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH] configure: fix performance regression due to PIC objects Date: Sat, 19 Sep 2020 11:56:39 -0400 Message-Id: <20200919155639.1045857-1-pbonzini@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/19 11:03:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.996, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ahmed Karaman Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Because most files in QEMU are grouped into static libraries, Meson conserv= atively compiles them with -fPIC. This is overkill and produces slowdowns up to 20= % on some TCG tests. As a stopgap measure, use the b_staticpic option to limit the slowdown to --enable-pie. https://github.com/mesonbuild/meson/pull/7760 will allow us to use b_staticpic=3Dfalse and let Meson do the right thing. Reported-by: Ahmed Karaman Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 0004c46525..0786144043 100755 --- a/configure +++ b/configure @@ -7414,6 +7414,7 @@ NINJA=3D${ninja:-$PWD/ninjatool} $meson setup \ -Dwerror=3D$(if test "$werror" =3D yes; then echo true; else echo = false; fi) \ -Dstrip=3D$(if test "$strip_opt" =3D yes; then echo true; else ech= o false; fi) \ -Db_pie=3D$(if test "$pie" =3D yes; then echo true; else echo fals= e; fi) \ + -Db_staticpic=3D$(if test "$pie" =3D yes; then echo true; else ech= o false; fi) \ -Db_coverage=3D$(if test "$gcov" =3D yes; then echo true; else ech= o false; fi) \ -Dmalloc=3D$malloc -Dmalloc_trim=3D$malloc_trim -Dsparse=3D$sparse \ -Dkvm=3D$kvm -Dhax=3D$hax -Dwhpx=3D$whpx -Dhvf=3D$hvf \ --=20 2.26.2