From nobody Tue Feb 10 02:55:29 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1600461647; cv=none; d=zohomail.com; s=zohoarc; b=AecUPPlbdHhfGkrB21+RLAqpvfitPZqg3RcuBZjpXixrDs6/nowB2rQAImtWXGpIz6/gFq4g/crRZW7yJO7PtrKoDPhzk1MQH+CVD6HhzEG55n3ChNwWo6qnjmTcmBJsKIyqClhOGuopn4UhThdCvUIVaEWsZdE+9u1L+aQk3GY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600461647; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jAOuhAAf23VmKCf10RNUPVfZ5x/ccJIQFO986jexd6U=; b=cz2guDzhDu3zzrzrLp0roganD440kNixyCSmI6seZ1HTjBOl0RGkOXzrWgxVtRsAvQRTTxQJ1/zDujWjlKGk4EcRK/agUE+WGLAplEt6WMoT4spH3UWbidsaLx8AsEi8X4SzvqIzNJ8jlvZV4N6yW+cR5z8ZCdo7vRc39hc2RPU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600461647178474.9347324690085; Fri, 18 Sep 2020 13:40:47 -0700 (PDT) Received: from localhost ([::1]:43114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJNBV-0006yJ-Ng for importer@patchew.org; Fri, 18 Sep 2020 16:40:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46470) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJN7a-0004tu-Ht; Fri, 18 Sep 2020 16:36:44 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:44993) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJN7Y-0004yx-VS; Fri, 18 Sep 2020 16:36:42 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 2CA63580226; Fri, 18 Sep 2020 16:36:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 18 Sep 2020 16:36:40 -0400 Received: from apples.local (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id 619513064610; Fri, 18 Sep 2020 16:36:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=fm1; bh= jAOuhAAf23VmKCf10RNUPVfZ5x/ccJIQFO986jexd6U=; b=pEWNLFFqqcxwAGvx 289XpvY9Zf4EJ46zyvZRNp/T5ydw5UgQmemYO1m2CrBvUZCI5R9qvdHax+ial2Fo UZqyRQViiYjD7kNF6ubofAxHJRMSDJzCmrWcro1hn+3EXkz0xmPFl4XuS/NMnzcn R/G7hidoZZFIiRYpQN4rFEliifOGQrcYX43nuDiBuxVGLNKyR2iY1BJLQVRXDOLi fPKBqLyzqlIZytw6zGQsnj23KQdoxcpvLnbTR9Gm7w8jDPLVLtb8EGj7f0S+HFKc nPrfWs3BT4HRHGNt8xAsmQIUCcahVmObHX3B0R4Ye7+E7hzaR68DD4uDI3jKUjYD NcQZNg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=jAOuhAAf23VmKCf10RNUPVfZ5x/ccJIQFO986jexd 6U=; b=pxU9NiHCt6wrYB11nr1q7JgUkw8lQIJ3fKdFLnJD81uqEmwEEpaCYBGAr AeyBpRnvvHrjYxp9BmMwLRq4psgBY8ZFqdnLD83Yod18FXQuc/s6xyJ3RrEUgFS6 XXBmaF86YBDJjAb3BKdMKqZS7Ip/nksplMMIfL0/h9dOZ2j6q3pR5JgcnZdogwDH ws06dFfKfMwCSx5+C/3V4iA+lZp4I6c7sZXzgJbuwWt1ZgL6tNKMPRSfkl74NtTa ROP+STFQnfkHnx6MtVWf0m0fajowr6wB2yw9u7mmPAdOP8sBsYkWTDs452ynCtpD falMLItAKPcFi4dIaOwS63rmF64VQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrtdeigdduhedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepmfhlrghu shculfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrth htvghrnhepteevuedugeevieehgeeileeufeetvddtkeetfeelgeehudfhjeeuledvhfff tdegnecukfhppeektddrudeijedrleekrdduledtnecuvehluhhsthgvrhfuihiivgepvd enucfrrghrrghmpehmrghilhhfrhhomhepihhtshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: From: Klaus Jensen To: qemu-devel@nongnu.org Subject: [PATCH v2 10/17] hw/block/nvme: default request status to success Date: Fri, 18 Sep 2020 22:36:14 +0200 Message-Id: <20200918203621.602915-11-its@irrelevant.dk> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200918203621.602915-1-its@irrelevant.dk> References: <20200918203621.602915-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=66.111.4.221; envelope-from=its@irrelevant.dk; helo=new1-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 16:36:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , Klaus Jensen , Max Reitz , Klaus Jensen , Keith Busch , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Klaus Jensen Make the default request status NVME_SUCCESS so only error status codes have to be set. Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/block/nvme.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index e6790c196d2b..7e6cbd3f1058 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -230,6 +230,7 @@ static void nvme_req_clear(NvmeRequest *req) { req->ns =3D NULL; memset(&req->cqe, 0x0, sizeof(req->cqe)); + req->status =3D NVME_SUCCESS; } =20 static void nvme_req_exit(NvmeRequest *req) @@ -546,8 +547,6 @@ static void nvme_process_aers(void *opaque) result->log_page =3D event->result.log_page; g_free(event); =20 - req->status =3D NVME_SUCCESS; - trace_pci_nvme_aer_post_cqe(result->event_type, result->event_info, result->log_page); =20 @@ -626,7 +625,6 @@ static void nvme_rw_cb(void *opaque, int ret) =20 if (!ret) { block_acct_done(stats, acct); - req->status =3D NVME_SUCCESS; } else { uint16_t status; =20 --=20 2.28.0