From nobody Mon Apr 29 07:32:58 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1600421249; cv=none; d=zohomail.com; s=zohoarc; b=iwhLR4m9LB5h7HP601dmbYqWqo+hPaDirN/btXSqZnVsHosoorn5CjnvV1uXcQF8GSuvzbRxWVzV5QosURuBhD2Mx6noAHT/X2Br3OMfZ0Nw4jSbdZg5B+DcBwPhAFfQvjN8JauDsRdf6IQ/LW2vPSYs6zGWtZdELuYXltKf3xc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600421249; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=Lur0J2tasHb5yyx5zNq9WDUjHtMJ8e0IbTcRnfuwkco=; b=i2uGKPiyKti+O97GWRq2Lg0aYqrmF0F4HsbKo0TQrvhE1TJc8kfHcA6yNFLm0Jg1qtJCs+oaWrLk+yRBhookVVsymtZWPwXIae8uu954uEEdleBhptftemvqBaTA4g0M4RYalDs2BNab70jWb9rVoQz8Bwb3xBcqFUwm0rJ+buU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600421249261143.17845803747787; Fri, 18 Sep 2020 02:27:29 -0700 (PDT) Received: from localhost ([::1]:58460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJCfw-00042W-2E for importer@patchew.org; Fri, 18 Sep 2020 05:27:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJCcy-0000Ex-G9 for qemu-devel@nongnu.org; Fri, 18 Sep 2020 05:24:27 -0400 Received: from mga05.intel.com ([192.55.52.43]:42395) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJCcv-0004Px-9M for qemu-devel@nongnu.org; Fri, 18 Sep 2020 05:24:23 -0400 Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 02:24:16 -0700 Received: from unknown (HELO localhost.localdomain) ([10.239.13.19]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 02:24:14 -0700 IronPort-SDR: t7kgBNAN0EF6OE+HEZUgS6tD25FINZceC43STbD4CaSJbekzjiT8KX7lYq5r0dvTwJPy2ddjBV uBSw5wnjxkUw== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="244733388" X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="244733388" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False IronPort-SDR: Gzj36Tfc27pgsJjAg6qps2pEJC9thjg43j/a0maHr0Zdu48c/H5iksrtJ6zAFXwbTZdGpGqVgf qdSfexOUBLoQ== X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="484130678" From: Zhang Chen To: Jason Wang , qemu-dev Subject: [PATCH 1/4] net/colo-compare.c: Fix compare_timeout format issue Date: Fri, 18 Sep 2020 17:22:00 +0800 Message-Id: <20200918092203.20384-2-chen.zhang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200918092203.20384-1-chen.zhang@intel.com> References: <20200918092203.20384-1-chen.zhang@intel.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.55.52.43; envelope-from=chen.zhang@intel.com; helo=mga05.intel.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 05:24:15 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, FROM_ADDR_WS=2.999, FROM_WSP_TRAIL=1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Li Zhijian , Zhang Chen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Zhang Chen This parameter need compare with the return of qemu_clock_get_ms(), it is uinit64_t. So we need fix this issue here. Reported-by: Derek Su Signed-off-by: Zhang Chen Reviewed-by: Li Zhijian --- net/colo-compare.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 3a45d64175..7cba573dae 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -120,7 +120,7 @@ struct CompareState { SendCo out_sendco; SendCo notify_sendco; bool vnet_hdr; - uint32_t compare_timeout; + uint64_t compare_timeout; uint32_t expired_scan_cycle; =20 /* @@ -1081,9 +1081,9 @@ static void compare_get_timeout(Object *obj, Visitor = *v, Error **errp) { CompareState *s =3D COLO_COMPARE(obj); - uint32_t value =3D s->compare_timeout; + uint64_t value =3D s->compare_timeout; =20 - visit_type_uint32(v, name, &value, errp); + visit_type_uint64(v, name, &value, errp); } =20 static void compare_set_timeout(Object *obj, Visitor *v, @@ -1146,9 +1146,9 @@ static void set_max_queue_size(Object *obj, Visitor *= v, Error **errp) { Error *local_err =3D NULL; - uint32_t value; + uint64_t value; =20 - visit_type_uint32(v, name, &value, &local_err); + visit_type_uint64(v, name, &value, &local_err); if (local_err) { goto out; } @@ -1396,7 +1396,7 @@ static void colo_compare_init(Object *obj) object_property_add_str(obj, "notify_dev", compare_get_notify_dev, compare_set_notify_dev= ); =20 - object_property_add(obj, "compare_timeout", "uint32", + object_property_add(obj, "compare_timeout", "uint64", compare_get_timeout, compare_set_timeout, NULL, NULL); =20 --=20 2.17.1 From nobody Mon Apr 29 07:32:58 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1600421169; cv=none; d=zohomail.com; s=zohoarc; b=eDx0jm0YFAbKOKYJUdIfPJZEaudf91Hcr6cBBY2cOIuZm9I2eCCDpWCDUV8bwQxhcz6TFPRVre4eAWSVK4n/gYV/vlDj6fQHYamZGwpvwpoIu/4MTb9eNbV2+0nBsAzGe8aIpE0wxm5uqNBJoGnDd7/aZ8T7UtvWWZJ1NvR6vKg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600421169; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=qtesEkk/aQ9oGJKm4BPW34Zrd4BfL6U1faDP7XSSqkA=; b=UWi14uovp55LRRfApkHsf0bJdgBangEV88nbXF4GhXFijP30g0GLwT81lUi9v85R44J5BND6ZJJ4XXcfMkzlDLEUnrJfP1u+rdxRJHJhHpofOpXU9pLuH0q7QqYdMJM3tYwSu115XAw7w9pHguclNrsQQJKMw3SCXD8nNl2PYSc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600421169784347.2259241535302; Fri, 18 Sep 2020 02:26:09 -0700 (PDT) Received: from localhost ([::1]:52376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJCee-0001YE-FN for importer@patchew.org; Fri, 18 Sep 2020 05:26:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46740) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJCcz-0000F3-VF for qemu-devel@nongnu.org; Fri, 18 Sep 2020 05:24:27 -0400 Received: from mga05.intel.com ([192.55.52.43]:42397) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJCcx-0004Q2-IQ for qemu-devel@nongnu.org; Fri, 18 Sep 2020 05:24:24 -0400 Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 02:24:18 -0700 Received: from unknown (HELO localhost.localdomain) ([10.239.13.19]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 02:24:16 -0700 IronPort-SDR: G/wtuVaietPm90NCdT2k9SslQfaS1rcMTWXFRBp8EVgOBNH7KBOA/pjkykenjnLXs3G52HmsVw 9N/Zj1deJAtQ== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="244733404" X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="244733404" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False IronPort-SDR: xMoTIc6hXolT03sj8/ghLbsOwbNIFJRTBlFZwDP8t9rwQCfc7/CY4W8bPXH9c++dLu1YvrEDD6 hEcpC34EaRew== X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="484130695" From: Zhang Chen To: Jason Wang , qemu-dev Subject: [PATCH 2/4] net/colo-compare.c: Change the timer clock type Date: Fri, 18 Sep 2020 17:22:01 +0800 Message-Id: <20200918092203.20384-3-chen.zhang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200918092203.20384-1-chen.zhang@intel.com> References: <20200918092203.20384-1-chen.zhang@intel.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.55.52.43; envelope-from=chen.zhang@intel.com; helo=mga05.intel.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 05:24:15 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, FROM_ADDR_WS=2.999, FROM_WSP_TRAIL=1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Li Zhijian , Zhang Chen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Zhang Chen The virtual clock only runs during the emulation. It stops when the virtual machine is stopped. The host clock should be used for device models that emulate accurate real time sources. It will continue to run when the virtual machine is suspended. COLO need to know the host time here. Reported-by: Derek Su Signed-off-by: Zhang Chen Reviewed-by: Li Zhijian --- net/colo-compare.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 7cba573dae..3b72309d08 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -905,7 +905,7 @@ static void check_old_packet_regular(void *opaque) =20 /* if have old packet we will notify checkpoint */ colo_old_packet_check(s); - timer_mod(s->packet_check_timer, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL)= + + timer_mod(s->packet_check_timer, qemu_clock_get_ms(QEMU_CLOCK_HOST) + s->expired_scan_cycle); } =20 @@ -939,10 +939,10 @@ static void colo_compare_timer_init(CompareState *s) { AioContext *ctx =3D iothread_get_aio_context(s->iothread); =20 - s->packet_check_timer =3D aio_timer_new(ctx, QEMU_CLOCK_VIRTUAL, + s->packet_check_timer =3D aio_timer_new(ctx, QEMU_CLOCK_HOST, SCALE_MS, check_old_packet_regular, s); - timer_mod(s->packet_check_timer, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL)= + + timer_mod(s->packet_check_timer, qemu_clock_get_ms(QEMU_CLOCK_HOST) + s->expired_scan_cycle); } =20 --=20 2.17.1 From nobody Mon Apr 29 07:32:58 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1600421248; cv=none; d=zohomail.com; s=zohoarc; b=dB4For7oyK3Vn61xtNGmONXGwA7ZU2bRQfknyNa5oh6NaSW9sq1qKfVlbC5xPi2/VjbFPx8xBdraPN7eFb7rsFoPVECRPcADRtc72JDhiZfF+X2Y8xOzsu7543icF9btFmm7SiqEM+dr6YvUiePOVh3fpQnXSgRnIrfz7HUJ/QE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600421248; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=FufQ2Szq5gbDMeT0hyPCELZxrg9MCFZAhQ019r4du1Y=; b=hDl4dnZj0DGW/PZot76uU2QGEdUcbU/h9ifZ7ppv+RX5plYGvEsTWpSavIUcvs6hYmcI8xpmCj39Q56ndjJxWeezFHIMuL1MNHPwHyL790jJKOZRwRNsvQTJmafHD5uJOTNcxYOAiwySqV2314ZlZx2SU1st8jWWlYSlJWV+Zm8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600421248959990.1928543870378; Fri, 18 Sep 2020 02:27:28 -0700 (PDT) Received: from localhost ([::1]:58472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJCfv-00042j-NF for importer@patchew.org; Fri, 18 Sep 2020 05:27:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46738) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJCcz-0000F2-V2 for qemu-devel@nongnu.org; Fri, 18 Sep 2020 05:24:27 -0400 Received: from mga05.intel.com ([192.55.52.43]:42395) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJCcy-0004Px-Ek for qemu-devel@nongnu.org; Fri, 18 Sep 2020 05:24:25 -0400 Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 02:24:19 -0700 Received: from unknown (HELO localhost.localdomain) ([10.239.13.19]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 02:24:18 -0700 IronPort-SDR: kRJzOXA6u2yJW0sYCd7WGg4EUbGVM7dmggvu6K0zxwUDbSkiuN9TUmxfMR8Zs5Ahd7dCSOFIf/ QgEzA0MXmWBA== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="244733422" X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="244733422" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False IronPort-SDR: Hk1YeSKYFi2jNNqLR2Ptibyo4pzqVLkyhrBayZN/wOcoJ5vzF9AC85XDgWkV7Tpq776wy34L4E poHAYPO0iUqQ== X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="484130706" From: Zhang Chen To: Jason Wang , qemu-dev Subject: [PATCH 3/4] net/colo-compare.c: Add secondary old packet detection Date: Fri, 18 Sep 2020 17:22:02 +0800 Message-Id: <20200918092203.20384-4-chen.zhang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200918092203.20384-1-chen.zhang@intel.com> References: <20200918092203.20384-1-chen.zhang@intel.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.55.52.43; envelope-from=chen.zhang@intel.com; helo=mga05.intel.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 05:24:15 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, FROM_ADDR_WS=2.999, FROM_WSP_TRAIL=1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Li Zhijian , Zhang Chen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Zhang Chen Detect queued secondary packet to sync VM state in time. Signed-off-by: Zhang Chen Reviewed-by: Li Zhijian --- net/colo-compare.c | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 3b72309d08..f7271b976f 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -641,19 +641,26 @@ void colo_compare_unregister_notifier(Notifier *notif= y) static int colo_old_packet_check_one_conn(Connection *conn, CompareState *s) { - GList *result =3D NULL; - - result =3D g_queue_find_custom(&conn->primary_list, - &s->compare_timeout, - (GCompareFunc)colo_old_packet_check_one); + if (!g_queue_is_empty(&conn->primary_list)) { + if (g_queue_find_custom(&conn->primary_list, + &s->compare_timeout, + (GCompareFunc)colo_old_packet_check_one)) + goto out; + } =20 - if (result) { - /* Do checkpoint will flush old packet */ - colo_compare_inconsistency_notify(s); - return 0; + if (!g_queue_is_empty(&conn->secondary_list)) { + if (g_queue_find_custom(&conn->secondary_list, + &s->compare_timeout, + (GCompareFunc)colo_old_packet_check_one)) + goto out; } =20 return 1; + +out: + /* Do checkpoint will flush old packet */ + colo_compare_inconsistency_notify(s); + return 0; } =20 /* --=20 2.17.1 From nobody Mon Apr 29 07:32:58 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1600421297; cv=none; d=zohomail.com; s=zohoarc; b=Ya42MgsPxx5zToOdbUuTq3TlM4W2CHCCMUxOPMCgMPO3gIWygejHrbtoYz+qRaky0C0JkHzN6c6XOmbXVUy4guHgdmxNDOK6XwfPPLscfjcxMSx802k/xE5XEs5w91maK5YaFLKJwfukNswFym3tPBxhED69qQeFxFXIo6MvbzU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600421297; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=Bw2Ddi5W8eB0FdhyK9EbAnAlImGi0a2emTFukchtsSE=; b=geVdxrII861OnyV0diHby9AsoWN5ch8BcAl2lfjBup/K//oaB7rFFSZO8JiIoswfzTwJ/tUTzhV7hulbFDMgLC1gaqv3/YJmgJiDaCcUBwdPbZ3s8jlFOzMhIEj2CRLU4DQD+z2ptV6hzhuMi0qn7XOUoEiXyRemsJO4JAfNatE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600421297890784.8225237745901; Fri, 18 Sep 2020 02:28:17 -0700 (PDT) Received: from localhost ([::1]:33552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJCgi-0005Q9-Ig for importer@patchew.org; Fri, 18 Sep 2020 05:28:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJCd3-0000Fz-3i for qemu-devel@nongnu.org; Fri, 18 Sep 2020 05:24:30 -0400 Received: from mga05.intel.com ([192.55.52.43]:42394) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJCcz-0004Pi-Pv for qemu-devel@nongnu.org; Fri, 18 Sep 2020 05:24:28 -0400 Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 02:24:21 -0700 Received: from unknown (HELO localhost.localdomain) ([10.239.13.19]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 02:24:20 -0700 IronPort-SDR: 8dZIxZgDRLc9n9jlaFahQAEusW6c+g3xxeV7ogr5MzTWD6ep/0sHGhcmWpMYz/F9rZ2KMq8o+V VuWpnSeiKqAw== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="244733436" X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="244733436" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False IronPort-SDR: Zc3dnsMBju3jdUGKJcR8ZJOzp8nAfy4gPMUSHjt0O//r9800dWpJU8uzaqJ0AZYybeuVQqDCAL RvkDRo85SDSA== X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="484130723" From: Zhang Chen To: Jason Wang , qemu-dev Subject: [PATCH 4/4] net/colo-compare.c: Increase default queued packet scan frequency Date: Fri, 18 Sep 2020 17:22:03 +0800 Message-Id: <20200918092203.20384-5-chen.zhang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200918092203.20384-1-chen.zhang@intel.com> References: <20200918092203.20384-1-chen.zhang@intel.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.55.52.43; envelope-from=chen.zhang@intel.com; helo=mga05.intel.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 05:24:15 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, FROM_ADDR_WS=2.999, FROM_WSP_TRAIL=1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Li Zhijian , Zhang Chen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Zhang Chen In my test, use this default parameter looks better. Signed-off-by: Zhang Chen --- net/colo-compare.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index f7271b976f..6df6a7e66f 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -52,7 +52,7 @@ static NotifierList colo_compare_notifiers =3D #define COLO_COMPARE_FREE_PRIMARY 0x01 #define COLO_COMPARE_FREE_SECONDARY 0x02 =20 -#define REGULAR_PACKET_CHECK_MS 3000 +#define REGULAR_PACKET_CHECK_MS 1000 #define DEFAULT_TIME_OUT_MS 3000 =20 /* #define DEBUG_COLO_PACKETS */ --=20 2.17.1