From nobody Mon Feb 9 08:10:17 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600257477; cv=none; d=zohomail.com; s=zohoarc; b=a2XS2vUlYhTdZtsCCb02jpU2PdGA2ql3KrnucRnjZ032J4tRLtgr009Xk0TpV0uefVBRE750x9S1DKJgBws80giYeyY8kxpOTqevRe8C9Ptxuqz/8dfWazXtJeivsmOR54iAoPh70rVQn9+x/wXixEXSYFrOj6Kv7EBu4eK2MTs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600257477; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GMroMXGtE6vqLVUYuRAwoouHI145DINyzRRsqwIB/r4=; b=V1KzhLUTB/cyLwXwRppe88hiZN97s24a0I8QayKXXIzyI0uCuNXJHH3edWh8FEwMBb9nB/zlTJLkIdvgANhQqVs+CTtUgzVpK48m6Wl05Z1oPdXCQSh/LOgj5RcOS9dQCxMMJWXimRdlPsxSl1wLSshyJQLRqUX+P9IetgUVYaQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600257477883257.8231741564332; Wed, 16 Sep 2020 04:57:57 -0700 (PDT) Received: from localhost ([::1]:37264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIW4S-00054c-Ll for importer@patchew.org; Wed, 16 Sep 2020 07:57:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIVur-0006pt-1N for qemu-devel@nongnu.org; Wed, 16 Sep 2020 07:48:01 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:46129 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kIVup-00089s-7Y for qemu-devel@nongnu.org; Wed, 16 Sep 2020 07:48:00 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-596-EMG1zDUlPsGxT-N1jNDC6g-1; Wed, 16 Sep 2020 07:47:54 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 13735100670C; Wed, 16 Sep 2020 11:47:53 +0000 (UTC) Received: from thuth.com (ovpn-113-19.ams2.redhat.com [10.36.113.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 08CB55DA71; Wed, 16 Sep 2020 11:47:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600256878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GMroMXGtE6vqLVUYuRAwoouHI145DINyzRRsqwIB/r4=; b=RHbWvxo5RTV4grURNTaolLvCiQgpi8E0r/8F3aYIS9GqsVwQ4tX6jy7NFGRne6Ima5bf4u iwNLsC9ZimV6dLi0AxG8t127uZySYS3XufcKL0+t8C5odQaBuqLW5iuGzEFZSL11FChlfA dhqxa/BVxL+194SvZiD81wTtoiASKYk= X-MC-Unique: EMG1zDUlPsGxT-N1jNDC6g-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 12/24] tests: Fixes test-replication.c on msys2/mingw. Date: Wed, 16 Sep 2020 13:47:19 +0200 Message-Id: <20200916114731.102080-13-thuth@redhat.com> In-Reply-To: <20200916114731.102080-1-thuth@redhat.com> References: <20200916114731.102080-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/16 00:53:39 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.999, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yonggang Luo Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Yonggang Luo On Windows there is no path like /tmp/s_local_disk.XXXXXX Use g_get_tmp_dir instead of /tmp. Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrang=C3=A9 Message-Id: <20200915121318.247-8-luoyonggang@gmail.com> Signed-off-by: Thomas Huth --- tests/test-replication.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/tests/test-replication.c b/tests/test-replication.c index 9ab3666a90..e7cbd6b144 100644 --- a/tests/test-replication.c +++ b/tests/test-replication.c @@ -23,14 +23,14 @@ =20 /* primary */ #define P_ID "primary-id" -static char p_local_disk[] =3D "/tmp/p_local_disk.XXXXXX"; +static char *p_local_disk; =20 /* secondary */ #define S_ID "secondary-id" #define S_LOCAL_DISK_ID "secondary-local-disk-id" -static char s_local_disk[] =3D "/tmp/s_local_disk.XXXXXX"; -static char s_active_disk[] =3D "/tmp/s_active_disk.XXXXXX"; -static char s_hidden_disk[] =3D "/tmp/s_hidden_disk.XXXXXX"; +static char *s_local_disk; +static char *s_active_disk; +static char *s_hidden_disk; =20 /* FIXME: steal from blockdev.c */ QemuOptsList qemu_drive_opts =3D { @@ -571,6 +571,11 @@ static void setup_sigabrt_handler(void) int main(int argc, char **argv) { int ret; + const char *tmpdir =3D g_get_tmp_dir(); + p_local_disk =3D g_strdup_printf("%s/p_local_disk.XXXXXX", tmpdir); + s_local_disk =3D g_strdup_printf("%s/s_local_disk.XXXXXX", tmpdir); + s_active_disk =3D g_strdup_printf("%s/s_active_disk.XXXXXX", tmpdir); + s_hidden_disk =3D g_strdup_printf("%s/s_hidden_disk.XXXXXX", tmpdir); qemu_init_main_loop(&error_fatal); bdrv_init(); =20 @@ -605,5 +610,10 @@ int main(int argc, char **argv) =20 cleanup_imgs(); =20 + g_free(p_local_disk); + g_free(s_local_disk); + g_free(s_active_disk); + g_free(s_hidden_disk); + return ret; } --=20 2.18.2