From nobody Mon Feb 9 13:39:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600210621; cv=none; d=zohomail.com; s=zohoarc; b=J3pwL3TVdvDMFMh/Nzs2c1YqoB8A/GF/2TlN3b3jiUMMXki1xxMe6mH+Cas7jX58zDxvwhlfgfAxK6wHsM5Z5pvQljJjwRjlO0dKDbPHkH9KkT8/jFM13Wv5SJHZu5tgOYyMy7FRznZWMazGRe3xYqJYVlaUBkFNWDGh4WZko/o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600210621; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8ePgfCWByzRQmi2cnicC+aWlpeOGUB52vpyZeuE5ow4=; b=JJzOsoImlW6SXvufrxPZie5QQUk31Y792b/ctMwCFhgu15pdh27sEXMpL2TyuC2BrsURJBtB3XefihNXI7R0/SB/3jiV76nBbq7QjZxcO4yp1/4IqyDZLEKkQPRaZ06J7MF/w7sVzkhaiYHbgs8BvPpTnNqZk0YOet0omyKUHWE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600210621336819.0460016065082; Tue, 15 Sep 2020 15:57:01 -0700 (PDT) Received: from localhost ([::1]:36766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIJsi-0000Ly-1s for importer@patchew.org; Tue, 15 Sep 2020 18:57:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIJdb-0007BC-4T for qemu-devel@nongnu.org; Tue, 15 Sep 2020 18:41:23 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:39049 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kIJdZ-0002gB-Cq for qemu-devel@nongnu.org; Tue, 15 Sep 2020 18:41:22 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-246-iqmW3cotNZO7vKd3SHfA6A-1; Tue, 15 Sep 2020 18:41:18 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A5689801ABA; Tue, 15 Sep 2020 22:41:11 +0000 (UTC) Received: from scv.redhat.com (ovpn-119-140.rdu2.redhat.com [10.10.119.140]) by smtp.corp.redhat.com (Postfix) with ESMTP id A70AB7BE76; Tue, 15 Sep 2020 22:41:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600209680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8ePgfCWByzRQmi2cnicC+aWlpeOGUB52vpyZeuE5ow4=; b=XPBmYCyxCb2SpcWzD/e+pOgHwQPRP06QfXGdtXNRzSrGyaNEKWFknNmLIrLG4isob74Uwy pBCGQLxbTWD9YPNmD4FFeZ7/6Rd79DiOF/SccI5HizZBY4dz3PeRLot/BMlZw2UZUfx3Kf TS+dMdhVfC5m9FiJklcjXnnj3ujzeIs= X-MC-Unique: iqmW3cotNZO7vKd3SHfA6A-1 From: John Snow To: qemu-devel@nongnu.org, Markus Armbruster Subject: [PATCH 24/37] qapi/gen.py: Fix edge-case of _is_user_module Date: Tue, 15 Sep 2020 18:40:14 -0400 Message-Id: <20200915224027.2529813-25-jsnow@redhat.com> In-Reply-To: <20200915224027.2529813-1-jsnow@redhat.com> References: <20200915224027.2529813-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0.0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=jsnow@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/15 18:41:20 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.999, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The edge case is that if the name is '', this expression returns a string instead of a bool, which violates our declared type. Signed-off-by: John Snow --- scripts/qapi/gen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py index 11472ba043..fc46813d1a 100644 --- a/scripts/qapi/gen.py +++ b/scripts/qapi/gen.py @@ -221,7 +221,7 @@ def __init__(self, prefix, what, user_blurb, builtin_bl= urb, pydoc): =20 @staticmethod def _is_user_module(name): - return name and not name.startswith('./') + return name is not None and not name.startswith('./') =20 @staticmethod def _is_builtin_module(name): --=20 2.26.2