From nobody Tue Feb 10 23:58:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1600087128; cv=none; d=zohomail.com; s=zohoarc; b=oDJE7rczgfLV0aQoyY6weT2vKdZbKoilCisCOupouSaPlNPfZypVkZ/EIZU/7LSxRjdRb4FlwTdg4AdKHpqWIEkzKETyIum26B5316foS7uZ1MwJfcY/6Mv3r7NF1LzZwSOlT4XhNytYd3GTgWIT5qupQt90NCBEsiJAZ8IcHf8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600087128; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NYCcOCJzJbgq1t5zBYZO88LACM5bDaLr8OGcnOxAkDc=; b=TMwyKTmGAzrY1shmkdf+0+vseLYMeWndPX4uDVJFi2YunQqBAKjmQedZkcIptQVYQQN8gn7EJiw7ZMdz54AahB7SWFDuyPKwR8ERxQUEMjTuIPORK5ytEcqiOSZGKucfOqV58gdXIoWIO/ljaSG1H9BrN4v0Hc2wq/fqLQvtbLA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600087128279697.2685121774026; Mon, 14 Sep 2020 05:38:48 -0700 (PDT) Received: from localhost ([::1]:47634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHnkt-0003I8-3o for importer@patchew.org; Mon, 14 Sep 2020 08:38:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHnhi-0006UH-1G for qemu-devel@nongnu.org; Mon, 14 Sep 2020 08:35:32 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:58706 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kHnhf-0000fi-3G for qemu-devel@nongnu.org; Mon, 14 Sep 2020 08:35:29 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-511-0G_H5re9Mayk2gPwSRBExw-1; Mon, 14 Sep 2020 08:35:21 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 754F88030B9; Mon, 14 Sep 2020 12:35:20 +0000 (UTC) Received: from bahia.redhat.com (ovpn-112-218.ams2.redhat.com [10.36.112.218]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED5321002393; Mon, 14 Sep 2020 12:35:17 +0000 (UTC) X-MC-Unique: 0G_H5re9Mayk2gPwSRBExw-1 From: Greg Kurz To: qemu-devel@nongnu.org Subject: [PATCH 04/15] spapr: Simplify error handling in callers of ppc_set_compat() Date: Mon, 14 Sep 2020 14:34:54 +0200 Message-Id: <20200914123505.612812-5-groug@kaod.org> In-Reply-To: <20200914123505.612812-1-groug@kaod.org> References: <20200914123505.612812-1-groug@kaod.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=groug@kaod.org X-Mimecast-Spam-Score: 0.0 X-Mimecast-Originator: kaod.org Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: softfail client-ip=207.211.31.81; envelope-from=groug@kaod.org; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/14 00:11:19 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kurz , Vladimir Sementsov-Ogievskiy , qemu-ppc@nongnu.org, Markus Armbruster , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Now that ppc_set_compat() indicates success/failure with a return value, use it and reduce error propagation overhead. Signed-off-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daud=C3=83=C2=A9 Reviewed-by: Vladimir Sementsov-Ogievskiy --- hw/ppc/spapr.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index ea2c755310cd..c0a3f5f26d97 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -3820,10 +3820,9 @@ static void spapr_core_plug(HotplugHandler *hotplug_= dev, DeviceState *dev, */ if (hotplugged) { for (i =3D 0; i < cc->nr_threads; i++) { - ppc_set_compat(core->threads[i], POWERPC_CPU(first_cpu)->compa= t_pvr, - &local_err); - if (local_err) { - error_propagate(errp, local_err); + if (ppc_set_compat(core->threads[i], + POWERPC_CPU(first_cpu)->compat_pvr, + errp) < 0) { return; } } --=20 2.26.2