From nobody Mon Feb 9 11:33:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600026845; cv=none; d=zohomail.com; s=zohoarc; b=Px/++BYmYOCghLLotiVcYnTE0suaTsjRNOyVM8T6hUYwWiiM3W4jTV340XH9LjBbaS3130YpNLwrMwYUuI3eHvVRkmk8WTAPE2EvqQfORWKD/gg9O66Y3wZ+FlEae42p4Q6Pv8KTqwajUum9lQjDGrSuqj4+x4x6RKlmzT3AZMI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600026845; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=DOKnWX2iitjDbaYV++fqOhPdaz2ukNmCIoazESmp5Ss=; b=S9/HytBfbIz2N7dq51hhHBhGh3/R/66grpxZ9LNugTaZToHSAVqkSiEeffJPU02zQRVmUuzoyTsyl7ptZbLO5iSvtGyLtJs/z7d4zLfGovNCSH7ZzKJR+pwpqHk3jBuMS8M6uCZc4pF+8Xd5lqZpwMhQyASKrrwk2uVm+k9sKAo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1600026845554985.6422717185005; Sun, 13 Sep 2020 12:54:05 -0700 (PDT) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-31-HFnTe6AUMGG2XWKR45KlZQ-1; Sun, 13 Sep 2020 15:54:02 -0400 Received: by mail-wr1-f71.google.com with SMTP id f18so5908799wrv.19 for ; Sun, 13 Sep 2020 12:54:02 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (65.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.65]) by smtp.gmail.com with ESMTPSA id 185sm16936093wma.18.2020.09.13.12.54.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2020 12:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600026844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DOKnWX2iitjDbaYV++fqOhPdaz2ukNmCIoazESmp5Ss=; b=PlWt5VFzMTImHkOnCsukQIajrmwAKFWaWFA+wif7vqH2pndMI9x/QHkCX5MJIIDDn5SIlv eA84u9WsT/8uJM+VqqqCiIrQVYqJdRm4uqFm39k8y23BVNMt8RyDzN7a+pBn7jscc79X1C pHklZ4Wf6OO6lTGTttNdtZUpxLIYmWs= X-MC-Unique: HFnTe6AUMGG2XWKR45KlZQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DOKnWX2iitjDbaYV++fqOhPdaz2ukNmCIoazESmp5Ss=; b=mzhrxdwXGWDhMU4hn7zysQsSFciNfsbs8c3Y+wi5qnWENjkC6fyvtLIohIlaQ+6HFo EnPZ5syIfrqDiahlV/N7u5+jYNmSJ0Srver57M8hws1SARKyDU5+fSEQ1clFfS9VqG7i j7bc2plab0QWV/PSkOhm7rOu29aAsn4NzN8FxbBEl+xCAh8ACYLGmsDWO7P58v8CUG7m K12fTIGtlqwOZcS+CFNsy5Eo9uZXFj6jQEjwSGGcbdFPs6u2Oz+MzkLbFeH9BV47Zmjz P0DPjCchdCoeejqhnAVdGk3yN41B6Xdo7Q8cYBko3ixIMiM31pTDo1brlV8F4QOIzIRo EDdA== X-Gm-Message-State: AOAM533PzTV3hriIQkVUuod4UdRrtmeIIc2v1/5whZiejX/PnT3w2tiL ZGrvtzr4zH90ESQXjbKfuISUOZ5nGQaoKBCn5N9ZriV8NSTdaLksuMCTjFzaBvvAaAZmoGz5egY hvvSoNIcDchIRSg== X-Received: by 2002:adf:e84a:: with SMTP id d10mr13117168wrn.66.1600026841617; Sun, 13 Sep 2020 12:54:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwydVMNI8O82MHC3Yh09m15o42bkAztsq9W/dTzfnny7bIiJEB+QUX7yZgSJskz2nx1S48kcQ== X-Received: by 2002:adf:e84a:: with SMTP id d10mr13117161wrn.66.1600026841452; Sun, 13 Sep 2020 12:54:01 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Markus Armbruster , qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v5 2/8] qapi: Correct balloon documentation Date: Sun, 13 Sep 2020 21:53:42 +0200 Message-Id: <20200913195348.1064154-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200913195348.1064154-1-philmd@redhat.com> References: <20200913195348.1064154-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The documentation incorrectly uses the "size of the balloon" description when it should be "logical size of the VM". Fix it. The relation between both values is: logical_vm_size =3D vm_ram_size - balloon_size Reported-by: David Hildenbrand Suggested-by: David Hildenbrand Reviewed-by: David Hildenbrand Acked-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- qapi/misc.json | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/qapi/misc.json b/qapi/misc.json index b21963a176d..a667fdf03e5 100644 --- a/qapi/misc.json +++ b/qapi/misc.json @@ -192,7 +192,8 @@ # # Information about the guest balloon device. # -# @actual: the number of bytes the balloon currently contains +# @actual: the logical size of the VM in bytes +# Formula used: logical_vm_size =3D vm_ram_size - balloon_size # # Since: 0.14.0 # @@ -228,7 +229,8 @@ # Emitted when the guest changes the actual BALLOON level. This value is # equivalent to the @actual field return by the 'query-balloon' command # -# @actual: actual level of the guest memory balloon in bytes +# @actual: the logical size of the VM in bytes +# Formula used: logical_vm_size =3D vm_ram_size - balloon_size # # Note: this event is rate-limited. # @@ -759,7 +761,10 @@ # # Request the balloon driver to change its balloon size. # -# @value: the target size of the balloon in bytes +# @value: the target logical size of the VM in bytes +# We can deduce the size of the balloon using this formula: +# logical_vm_size =3D vm_ram_size - balloon_size +# From it we have: balloon_size =3D vm_ram_size - @value # # Returns: - Nothing on success # - If the balloon driver is enabled but not functional because t= he KVM @@ -777,6 +782,8 @@ # -> { "execute": "balloon", "arguments": { "value": 536870912 } } # <- { "return": {} } # +# With a 2.5GiB guest this command inflated the balloon to 3GiB. +# ## { 'command': 'balloon', 'data': {'value': 'int'} } =20 --=20 2.26.2