From nobody Tue Feb 10 06:58:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) client-ip=209.85.128.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1599918053; cv=none; d=zohomail.com; s=zohoarc; b=AOKk9Ihhu14IBQr3gB9Q3YA92LNqsj4bwBVgqw0BAKDOy5VV69NQR3wjJv4V+9romqeikqZEwoXxhEW/2M4l9FA/qynmdaatkwCP3SzWZpq/Km37kHiSUIE3j3+TwOVYlzTE336FkJxPT+B5U69JJ44FWusStTAdj9XRNBEXu+o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599918053; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bXijLj9sePf1x7H7g7xUVbfkwlSyCDahYBi9izMEMaE=; b=jwcL60tpW4EyEFkttrzpINK2Qti7WySp58vHqNvodSlYpd9TxLUgq/YEXJV17Li4dNRufqrUO6qcJ97y3n6DyXE1inlri0n60D2fEoUIripO9SY8Xi5K6Wv7fiLe6M2VFhy+s5wiNvJPTh4OQE0zMA/vVwbB09Ni1XKbLeka2mQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mx.zohomail.com with SMTPS id 1599918053700448.8718555020589; Sat, 12 Sep 2020 06:40:53 -0700 (PDT) Received: by mail-wm1-f51.google.com with SMTP id e11so5901414wme.0 for ; Sat, 12 Sep 2020 06:40:53 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (65.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.65]) by smtp.gmail.com with ESMTPSA id u66sm10309144wmg.44.2020.09.12.06.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Sep 2020 06:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bXijLj9sePf1x7H7g7xUVbfkwlSyCDahYBi9izMEMaE=; b=mWclFZG+rQt0YMlTsFC8jd/YVGr7FvbSvnoJGD53SxaLLRwtL92z4UvC8ZgncgiqQl /RmxKRT5V4mDck53UMhiLxuiuFfxzGkerzl7hODRyh7AK8hfvpv8SOW5EX5i0nkaSZPR le+EqzYodO4pHTdJQUvnpCSl0UdkKmo4qypp7ndyZDbHrNE6rEcZLyuuTahT+E48trdr 6DPryFMlWPXeimEMbZy67QeRxlf1ShfYlnZ3BBkmivfYOk4A3fvjAtCULY1yO0xFABhT 6uLqaKoj//Kp/Mt285KpwXibBFJUGzxCrv5aeRLGozKUoGlpo8XGT64WuApvj8ydYrsV KRTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=bXijLj9sePf1x7H7g7xUVbfkwlSyCDahYBi9izMEMaE=; b=r4ky7UI39FGDvb2e55tKaxt44H/uBI13W+bSuAET5XoHqNdcshGfORd+KJ8KlCu3YF JuX7JvhJ0H6ptXiFmFcL9DRFJPembjqM/1zp8NpefUPO5GXTyCcBBtfXSep1fvwB4YB9 y0HUE5tuzPrVmENZHjzZCDpdrpkljVneyv5fw+hgVBS9WmFSrga6U1DhO2c+hRZ0piSL OGXcaIFyuyun9n3MJdi+uNdh7S1Gr+36/5ij+WPGN3JCqb8m1qKQ9lryH8s00SZawh1F LAYYrLZDt/r+hvwa2ekRvVlFgDcDb211GmAPkGJeSRyUXPzQqixcH+ZOAcMU5g6lm3Tg MbRQ== X-Gm-Message-State: AOAM531tuBoAtwiZd1aUYGsmnFD5GIrXArLL3yHYGKvgnQb8O+krIHsw 0BmpXKGMf22MfOEl0hQoNFc= X-Google-Smtp-Source: ABdhPJy5yafx0nDzTWUiRAMEeeulwNX5WS/71lbhS392aPjxTP323W1hxn0Qeat4Nw84k9DiCX+/MQ== X-Received: by 2002:a7b:cb4e:: with SMTP id v14mr6820406wmj.5.1599918051618; Sat, 12 Sep 2020 06:40:51 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Andrew Jeffery , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Paolo Bonzini , Joel Stanley , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Luc Michel , Andrzej Zaborowski , Eduardo Habkost , qemu-arm@nongnu.org, Richard Henderson Subject: [PATCH v6 5/7] hw/misc/mps2-fpgaio: Use the LED device Date: Sat, 12 Sep 2020 15:40:39 +0200 Message-Id: <20200912134041.946260-6-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200912134041.946260-1-f4bug@amsat.org> References: <20200912134041.946260-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Per the 'ARM MPS2 and MPS2+ FPGA Prototyping Boards Technical Reference Manual' (100112_0200_07_en): 2.1 Overview of the MPS2 and MPS2+ hardware The MPS2 and MPS2+ FPGA Prototyping Boards contain the following components and interfaces: * User switches and user LEDs: - Two green LEDs and two push buttons that connect to the FPGA. - Eight green LEDs and one 8-way dip switch that connect to the MCC. Add the 2 LEDs connected to the FPGA. This replaces the 'mps2_fpgaio_leds' trace events by the generic 'led_set_intensity' event. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Luc Michel --- include/hw/misc/mps2-fpgaio.h | 2 ++ hw/misc/mps2-fpgaio.c | 23 ++++++++++++++++++----- hw/misc/Kconfig | 1 + hw/misc/trace-events | 1 - 4 files changed, 21 insertions(+), 6 deletions(-) diff --git a/include/hw/misc/mps2-fpgaio.h b/include/hw/misc/mps2-fpgaio.h index 991f5b731e8..513e3be6f13 100644 --- a/include/hw/misc/mps2-fpgaio.h +++ b/include/hw/misc/mps2-fpgaio.h @@ -22,6 +22,7 @@ #define MPS2_FPGAIO_H =20 #include "hw/sysbus.h" +#include "hw/misc/led.h" #include "qom/object.h" =20 #define TYPE_MPS2_FPGAIO "mps2-fpgaio" @@ -35,6 +36,7 @@ struct MPS2FPGAIO { =20 /*< public >*/ MemoryRegion iomem; + LEDState *led[2]; =20 uint32_t led0; uint32_t prescale; diff --git a/hw/misc/mps2-fpgaio.c b/hw/misc/mps2-fpgaio.c index 2f3fbeef348..6af0e8f837a 100644 --- a/hw/misc/mps2-fpgaio.c +++ b/hw/misc/mps2-fpgaio.c @@ -24,6 +24,7 @@ #include "migration/vmstate.h" #include "hw/registerfields.h" #include "hw/misc/mps2-fpgaio.h" +#include "hw/misc/led.h" #include "hw/qdev-properties.h" #include "qemu/timer.h" =20 @@ -176,12 +177,9 @@ static void mps2_fpgaio_write(void *opaque, hwaddr off= set, uint64_t value, =20 switch (offset) { case A_LED0: - /* LED bits [1:0] control board LEDs. We don't currently have - * a mechanism for displaying this graphically, so use a trace eve= nt. - */ - trace_mps2_fpgaio_leds(value & 0x02 ? '*' : '.', - value & 0x01 ? '*' : '.'); s->led0 =3D value & 0x3; + led_set_state(s->led[0], value & 0x01); + led_set_state(s->led[1], value & 0x02); break; case A_PRESCALE: resync_counter(s); @@ -239,6 +237,10 @@ static void mps2_fpgaio_reset(DeviceState *dev) s->counter =3D 0; s->pscntr =3D 0; s->pscntr_sync_ticks =3D now; + + for (size_t i =3D 0; i < ARRAY_SIZE(s->led); i++) { + device_cold_reset(DEVICE(s->led[i])); + } } =20 static void mps2_fpgaio_init(Object *obj) @@ -251,6 +253,16 @@ static void mps2_fpgaio_init(Object *obj) sysbus_init_mmio(sbd, &s->iomem); } =20 +static void mps2_fpgaio_realize(DeviceState *dev, Error **errp) +{ + MPS2FPGAIO *s =3D MPS2_FPGAIO(dev); + + s->led[0] =3D led_create_simple(OBJECT(dev), GPIO_POLARITY_ACTIVE_HIGH, + LED_COLOR_GREEN, "USERLED0"); + s->led[1] =3D led_create_simple(OBJECT(dev), GPIO_POLARITY_ACTIVE_HIGH, + LED_COLOR_GREEN, "USERLED1"); +} + static bool mps2_fpgaio_counters_needed(void *opaque) { /* Currently vmstate.c insists all subsections have a 'needed' functio= n */ @@ -299,6 +311,7 @@ static void mps2_fpgaio_class_init(ObjectClass *klass, = void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->vmsd =3D &mps2_fpgaio_vmstate; + dc->realize =3D mps2_fpgaio_realize; dc->reset =3D mps2_fpgaio_reset; device_class_set_props(dc, mps2_fpgaio_properties); } diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig index 5c151fa3a83..0cecad45aad 100644 --- a/hw/misc/Kconfig +++ b/hw/misc/Kconfig @@ -93,6 +93,7 @@ config MIPS_ITU =20 config MPS2_FPGAIO bool + select LED =20 config MPS2_SCC bool diff --git a/hw/misc/trace-events b/hw/misc/trace-events index 5f3f6121bc9..908272e8593 100644 --- a/hw/misc/trace-events +++ b/hw/misc/trace-events @@ -92,7 +92,6 @@ mps2_scc_cfg_read(unsigned function, unsigned device, uin= t32_t value) "MPS2 SCC mps2_fpgaio_read(uint64_t offset, uint64_t data, unsigned size) "MPS2 FPGA= IO read: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" mps2_fpgaio_write(uint64_t offset, uint64_t data, unsigned size) "MPS2 FPG= AIO write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" mps2_fpgaio_reset(void) "MPS2 FPGAIO: reset" -mps2_fpgaio_leds(char led1, char led0) "MPS2 FPGAIO LEDs: %c%c" =20 # msf2-sysreg.c msf2_sysreg_write(uint64_t offset, uint32_t val, uint32_t prev) "msf2-sysr= eg write: addr 0x%08" PRIx64 " data 0x%" PRIx32 " prev 0x%" PRIx32 --=20 2.26.2