From nobody Tue Feb 10 20:49:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.68 as permitted sender) client-ip=209.85.221.68; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f68.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1599910846; cv=none; d=zohomail.com; s=zohoarc; b=ZWQzR4hN7YEK0jyUCmm0XVWQWL3cY5vdqEmadIPjnk13VrcGl216XN2Dz/lk7nFaOjpfHWBPBNlIJSZQ5/dbnxZQplOTy6cc1aRMqImsJBjc0yxG5VWcQkM3MThezvGHFcP4/i+kNuIikUgQTXNW6bODwDb9pkJhH8a7ZsOEnXQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599910846; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=34kk1edcAv9gPx2tbUUFoSPGnc2hB1OEkRGzgkZ3UyM=; b=R7RAFb5lV4DAYRzzp8qyS9NN1gZQ7C8sc0dJPIINx9plj2PquyW1qZgyJyeCss2YRZE/dRTyO4jcnsazH94TKYVzKbUHeH99HunFuawD8nxsbxvQZyRBDiZvghuvkOB/0LyARkSEsHHN6jJSVTr8/MHrzX1rWokb8btVKP8nrIw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.zohomail.com with SMTPS id 1599910845999861.3231943103182; Sat, 12 Sep 2020 04:40:45 -0700 (PDT) Received: by mail-wr1-f68.google.com with SMTP id c18so13890402wrm.9 for ; Sat, 12 Sep 2020 04:40:45 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (65.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.65]) by smtp.gmail.com with ESMTPSA id h6sm9373895wmb.22.2020.09.12.04.40.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Sep 2020 04:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=34kk1edcAv9gPx2tbUUFoSPGnc2hB1OEkRGzgkZ3UyM=; b=qSwHns8pnvRcyHGrA6m6QJYDbIa9MegbKjQShn4pRkdvDWB1rdtPDt3nWzPDQz7OAM PlesndzWMGYz7tGB1k+tKf1s1BLhIq8QfSMcraNH8t1AslRWYKyYsdmW30uJgkd4knmy GHnN4ZG0VN8ToXeo9Gunl9yn7uzIOwBs2d+vf0klmrTwZRnPkK4BtV/Epd468NMjtzpt jMHO3kve/Uwh91YPXVsbTKhXMPPGvqkPf/taolCuj7y4CETBJqdp4i9o9cey1geps/if tGMG5w+XW7geXXR7I0i+v2IlH1Sb7siLWaqpI8hBdvEPfj93UNFc1Fl5pi48uBeuaHWH ZBMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=34kk1edcAv9gPx2tbUUFoSPGnc2hB1OEkRGzgkZ3UyM=; b=o14Lt7dnfkIFDL2jFdc7XszDnClZ6xfzoKOwl0e4H1AaJ890lqFt0JWyq4HLCck9fV j4ShPYD/EOQq9RgKue5op07XonMSzwnG2KF3C4Lea4YN2qDCkzruLNBQvlw4ypoCnctU kk0ArWWNYE7yqsu1snuaxgiGu/tqUTeivJgU1232yTaQW/M8BGRM4IMtLZxP+7JNUQVZ zsfNT2SJFk2SFc8J1Rar1JL0TBsH3YUhYFVrQD+8B81zd4STy6xCS/fKjAi19+5CMX6v w6PwNYO48mZhWD9iDcCJBBPtqORmfprbrgAf1z7V6HGpsVOc5Qy2pOuT62M46fkE5ZLw szdA== X-Gm-Message-State: AOAM532kOcupTbBxdrpR0Zhmf9Hc7r8cmF7MLH0y1gSYJ8Qul3IkFgg3 KPOGlLTPZ/h2Yj+pqkAk+HM= X-Google-Smtp-Source: ABdhPJxBfxV8QkEtvA+iRweVpgQY7yx7umsKtYT8+OouFCiBWv/6XSDMSHJ3MBcxNgztCZRszD7ntQ== X-Received: by 2002:adf:f290:: with SMTP id k16mr6962931wro.124.1599910844047; Sat, 12 Sep 2020 04:40:44 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v2 1/7] hw/char/serial: Assert serial_ioport_read/write offset fits 8 bytes Date: Sat, 12 Sep 2020 13:40:34 +0200 Message-Id: <20200912114040.918464-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200912114040.918464-1-f4bug@amsat.org> References: <20200912114040.918464-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The serial device has 8 registers, each 8-bit. The MemoryRegionOps 'serial_io_ops' is initialized with max_access_size=3D1, and all memory_region_init_io() callers correctly set the region size to 8 bytes: - serial_io_realize - serial_isa_realizefn - serial_pci_realize - multi_serial_pci_realize It is safe to assert the offset argument of serial_ioport_read() and serial_ioport_write() is always less than 8. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/char/serial.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/serial.c b/hw/char/serial.c index 23864794929..a855ef66ea2 100644 --- a/hw/char/serial.c +++ b/hw/char/serial.c @@ -344,7 +344,7 @@ static void serial_ioport_write(void *opaque, hwaddr ad= dr, uint64_t val, { SerialState *s =3D opaque; =20 - addr &=3D 7; + assert(size =3D=3D 1 && addr < 8); trace_serial_ioport_write(addr, val); switch(addr) { default: @@ -485,7 +485,7 @@ static uint64_t serial_ioport_read(void *opaque, hwaddr= addr, unsigned size) SerialState *s =3D opaque; uint32_t ret; =20 - addr &=3D 7; + assert(size =3D=3D 1 && addr < 8); switch(addr) { default: case 0: --=20 2.26.2