From nobody Mon May 6 02:27:41 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599828860; cv=none; d=zohomail.com; s=zohoarc; b=F5vFVblLq4ECHvIqn/6FTitZbPx+fvoQk3kOL7oTSqffJTpg9dxyYD8/HXEo84Os4GRWL4uZzhXXGi8UDBf1Soz+4blnzjgOXw4cPzn0R1ETmHwgRI97zYzb7YgBoaEb7tmczZW39AQkPEyH7ee11TOntAKCws+lrvZmQ5fy2UQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599828860; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=UX9AvpNZYAWYcvuk8HiroWjU3CWS/PepIA7paF1wlAc=; b=lvZPmCwwuYcxQc7A7IEiS57nNJAunZpAJiUuqgjIYktHj1/pFbjOyJIBvtYHtYgGaU/SA3nJH389yQv7fMZt1nelcyUJVRaS45GKNtV3vabpl3hp/TBGAA50djxsCKwe76LpbqjwH6x9n3KvCToYRZMUNixPipopS7LD1rWY+wA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1599828860189373.50551961155986; Fri, 11 Sep 2020 05:54:20 -0700 (PDT) Received: from localhost ([::1]:34026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGiZG-0006l2-M9 for importer@patchew.org; Fri, 11 Sep 2020 08:54:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGiYA-0005lE-Mb for qemu-devel@nongnu.org; Fri, 11 Sep 2020 08:53:10 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:33276 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kGiY9-00043Q-6c for qemu-devel@nongnu.org; Fri, 11 Sep 2020 08:53:10 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-446-lblDRYJeM3inBDOkJTCE8A-1; Fri, 11 Sep 2020 08:53:06 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A6447CD040; Fri, 11 Sep 2020 12:53:05 +0000 (UTC) Received: from thuth.com (ovpn-115-1.ams2.redhat.com [10.36.115.1]) by smtp.corp.redhat.com (Postfix) with ESMTP id C8FEE60C07; Fri, 11 Sep 2020 12:53:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599828788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type; bh=UX9AvpNZYAWYcvuk8HiroWjU3CWS/PepIA7paF1wlAc=; b=QkVLHApafJJGpsin3n7xGCsSEWJYrCA8gbVS7kis+0ws2L8a44lGRG1cPtWcCKtRoQLdqW ixBPBrcj3TePBdEaach6Vcoy4Sug7zlFDD00wqAfvDsXS5qffaWMMNBa8QtyAWEaCYjG6C l/C8/hEuCciA5K1o2NS2LIBHGlZntLg= X-MC-Unique: lblDRYJeM3inBDOkJTCE8A-1 From: Thomas Huth To: qemu-devel@nongnu.org, Paolo Bonzini Subject: [PATCH] target/i386/kvm: Add missing fallthrough comment Date: Fri, 11 Sep 2020 14:53:01 +0200 Message-Id: <20200911125301.413081-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0.0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/11 03:40:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Marcelo Tosatti , Eduardo Habkost , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Let's make this file compilable with -Werror=3Dimplicit-fallthrough : Looking at the code, it seems like the fallthrough is intended here, so we should add the corresponding "/* fallthrough */" comment here. Signed-off-by: Thomas Huth Acked-by: Paolo Bonzini --- target/i386/kvm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 205b68bc0c..283d3305d5 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -1568,6 +1568,7 @@ int kvm_arch_init_vcpu(CPUState *cs) if (env->nr_dies < 2) { break; } + /* fallthrough */ case 4: case 0xb: case 0xd: --=20 2.18.2