[RFC PATCH v5 0/4] util/vfio-helpers: Add support for multiple IRQs

Philippe Mathieu-Daudé posted 4 patches 3 years, 6 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
include/qemu/vfio-helpers.h |  6 ++-
block/nvme.c                |  9 +++-
util/vfio-helpers.c         | 87 ++++++++++++++++++++++++++++++++++++-
3 files changed, 97 insertions(+), 5 deletions(-)
[RFC PATCH v5 0/4] util/vfio-helpers: Add support for multiple IRQs
Posted by Philippe Mathieu-Daudé 3 years, 6 months ago
This series intends to setup the VFIO helper to allow
binding notifiers on different IRQs.

For the NVMe use case, we only care about MSIX interrupts.
To not disrupt other users, introduce the qemu_vfio_pci_init_msix_irqs
function to initialize multiple MSIX IRQs and attach eventfd to
them.

Since RFC v4:
- addressed Alex review comment:
  check ioctl(VFIO_DEVICE_SET_IRQS) return value

Since RFC v3:
- addressed Alex and Stefan review comments

Since RFC v2:
- new patch to report vfio-helpers is not supported on AA64/POWER

(NVMe block driver series will follow).

Based-on: <20200908115322.325832-1-kwolf@redhat.com>
(Block layer pending pull request)

Philippe Mathieu-Daudé (4):
  util/vfio-helpers: Improve reporting unsupported IOMMU type
  util/vfio-helpers: Report error when IOMMU page size is not supported
  util/vfio-helpers: Introduce qemu_vfio_pci_init_msix_irqs()
  block/nvme: Use qemu_vfio_pci_init_msix_irqs() to initialize our IRQ

 include/qemu/vfio-helpers.h |  6 ++-
 block/nvme.c                |  9 +++-
 util/vfio-helpers.c         | 87 ++++++++++++++++++++++++++++++++++++-
 3 files changed, 97 insertions(+), 5 deletions(-)

-- 
2.26.2

Re: [RFC PATCH v5 0/4] util/vfio-helpers: Add support for multiple IRQs
Posted by Fam Zheng 3 years, 6 months ago
On 2020-09-08 20:03, Philippe Mathieu-Daudé wrote:
> This series intends to setup the VFIO helper to allow
> binding notifiers on different IRQs.
> 
> For the NVMe use case, we only care about MSIX interrupts.
> To not disrupt other users, introduce the qemu_vfio_pci_init_msix_irqs
> function to initialize multiple MSIX IRQs and attach eventfd to
> them.
> 
> Since RFC v4:
> - addressed Alex review comment:
>   check ioctl(VFIO_DEVICE_SET_IRQS) return value

Reviewed-by: Fam Zheng <fam@euphon.net>