From nobody Fri May 3 14:00:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599568101; cv=none; d=zohomail.com; s=zohoarc; b=UxaAa9++wQKxFzJvoyGzEFVJvXbqGZiBsnoyH59w18rOZDRlNX0b13CrHOUeVhKEm55Duc5FJugyuO/IPHGL6F7aRCtMHCxAhmLYRGuDdpDVr2d9hlwUwC8LBZgqHME3M4EJzkR8jNVt1Tyvn0onevrzHQKNPOIfqWi01s2IcBc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599568101; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=HLDu887fn+GCLiYEpEIPL/cUfFTSDg8lJgVxiRXalPw=; b=i8Qr2ow6P71gIzUoyU3x7GrCaUgjG495M4P3S1iBcFJ7teCc1ts3qwJO/ZPcH2L61Hyv05zRbP8HGPi85QdBuUk2GWL1PPAyOquA1QuSPz5bdteTRVklcB5wt9OxDm8SJgoy/JZ6Cejxosa6GGIev0uIHixcKFbuB2l3veOqoTw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1599568101355436.3648999690498; Tue, 8 Sep 2020 05:28:21 -0700 (PDT) Received: from localhost ([::1]:55238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFcjT-0002LK-Tj for importer@patchew.org; Tue, 08 Sep 2020 08:28:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFcXa-0008Gn-3I for qemu-devel@nongnu.org; Tue, 08 Sep 2020 08:16:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22709) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kFcXX-0006Mk-On for qemu-devel@nongnu.org; Tue, 08 Sep 2020 08:16:01 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-311-EI9sdtChP8u0-0iVLqEFbg-1; Tue, 08 Sep 2020 08:15:57 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D04BE18C9F53 for ; Tue, 8 Sep 2020 12:15:56 +0000 (UTC) Received: from thuth.com (ovpn-112-131.ams2.redhat.com [10.36.112.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC6D67A3C8; Tue, 8 Sep 2020 12:15:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599567359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HLDu887fn+GCLiYEpEIPL/cUfFTSDg8lJgVxiRXalPw=; b=YeS8W/ESolqsRXYwGT9ooj65fpxOuL/zBzqpAJnbNCWvv5LHPglohx4TlPdJDvV4a0pPGW TLLIM1Fv4vINFJ5kk/LHoR3KnydGpHkLJ2GRQPK5fowk98OHfmXPq7tJF7XJQ/f0HHc/hl 4QErgwp5aflGPhRbYaBJL/dqcSokHbk= X-MC-Unique: EI9sdtChP8u0-0iVLqEFbg-1 From: Thomas Huth To: qemu-devel@nongnu.org, "Daniel P . Berrange" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH] tests/socket-helpers: Treat EAI_NONAME as EADDRNOTAVAIL Date: Tue, 8 Sep 2020 14:15:43 +0200 Message-Id: <20200908121543.222872-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/08 02:10:54 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The tests/test-char test is currently always failing on my system since the getaddrinfo() in socket_can_bind_connect() returns EAI_NONAME when it is called from socket_check_protocol_support() to check for IPv6. socket_check_protocol_support() then returns -1 and thus the tests are not run at all - even though IPv4 is working fine. socket_can_bind_connect() connect should return EADDRNOTAVAIL in this case instead, so that socket_check_protocol_support() does not fail. Suggested-by: Daniel P. Berrang=C3=A9 Signed-off-by: Thomas Huth Reviewed-by: Daniel P. Berrang=C3=A9 --- tests/socket-helpers.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/socket-helpers.c b/tests/socket-helpers.c index 19a51e887e..f704fd1a69 100644 --- a/tests/socket-helpers.c +++ b/tests/socket-helpers.c @@ -59,8 +59,7 @@ static int socket_can_bind_connect(const char *hostname, = int family) /* lookup */ rc =3D getaddrinfo(hostname, NULL, &ai, &res); if (rc !=3D 0) { - if (rc =3D=3D EAI_ADDRFAMILY || - rc =3D=3D EAI_FAMILY) { + if (rc =3D=3D EAI_ADDRFAMILY || rc =3D=3D EAI_FAMILY || rc =3D=3D = EAI_NONAME) { errno =3D EADDRNOTAVAIL; } else { errno =3D EINVAL; --=20 2.18.2