From nobody Fri May 3 12:27:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599548483; cv=none; d=zohomail.com; s=zohoarc; b=O/lufJc8oW3EzM6zZ3MzH/+M0kfIChKlJQEZzQhmycZaGdBa9kT5dgzgfSo0GjSRqxrPbonp3dsrig9cll0EWIuykSYogfpDP0LYsV1uRy7wSt8aRQX6KZlVOxdpsRpBn7RVTd6a2izKqLmBJKJ1yxJ8gFAkXVv+bw8pVcFnxaw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599548483; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=E0ZhXKghmJkvIciPUKHX3hypiskU3eE8ItTAXYZjSKE=; b=igxL+9ggeJRb8pVB1hXl+g1YcpTaYIzt64coWdTV4FMuoxNmzih4Ef6AJj3xaLWiP8AOqsZmrFRmCvWyOfT5R+LC2wLb5TU0sscztgmFqeAl5g2JaaGAHxaWT9UYoDM004tbCO+0NL6NgvuqlJCdYuerHIuRpAUmgWreybe/gpI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1599548483727339.51320616498504; Tue, 8 Sep 2020 00:01:23 -0700 (PDT) Received: from localhost ([::1]:52016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFXd4-0008Cf-9D for importer@patchew.org; Tue, 08 Sep 2020 03:01:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFXcM-0007cF-7g for qemu-devel@nongnu.org; Tue, 08 Sep 2020 03:00:38 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:54994 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kFXcK-0000TJ-Gj for qemu-devel@nongnu.org; Tue, 08 Sep 2020 03:00:37 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-131--6V5g15nNn2ADaJRCOkbgQ-1; Tue, 08 Sep 2020 03:00:32 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BC1DA18B9EDD; Tue, 8 Sep 2020 07:00:31 +0000 (UTC) Received: from thuth.com (ovpn-112-131.ams2.redhat.com [10.36.112.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id 927DC5D9D3; Tue, 8 Sep 2020 07:00:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599548434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=E0ZhXKghmJkvIciPUKHX3hypiskU3eE8ItTAXYZjSKE=; b=A1hiiuDvukAoXBBmMiOAwIf6pgUJGp4GGxjXX3DIItAQkKZuLPJCoaFk9sw1YQkx6dbxQJ tMlHk6OUSnH9U5jJWwN2XtFg55vSktXtwVtfaqbCYxC/OfABsvwaTE5TA2owmczjgWPjjW ThiHwgaUSB4i6odWQurG3HJ6o8ryl6U= X-MC-Unique: -6V5g15nNn2ADaJRCOkbgQ-1 From: Thomas Huth To: qemu-devel@nongnu.org, Kevin Wolf , Max Reitz Subject: [PATCH] block/qcow2-cluster: Add missing "fallthrough" annotation Date: Tue, 8 Sep 2020 09:00:28 +0200 Message-Id: <20200908070028.193298-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=thuth@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/08 00:33:58 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-block@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) When compiling with -Werror=3Dimplicit-fallthrough, the compiler currently complains: ../../devel/qemu/block/qcow2-cluster.c: In function =E2=80=98cluster_needs_= new_alloc=E2=80=99: ../../devel/qemu/block/qcow2-cluster.c:1320:12: error: this statement may f= all through [-Werror=3Dimplicit-fallthrough=3D] if (l2_entry & QCOW_OFLAG_COPIED) { ^ ../../devel/qemu/block/qcow2-cluster.c:1323:5: note: here case QCOW2_CLUSTER_UNALLOCATED: ^~~~ It's quite obvious that the fallthrough is intended here, so let's add a comment to silence the compiler warning. Signed-off-by: Thomas Huth --- block/qcow2-cluster.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 996b3314f4..fcdf7af8e6 100644 --- a/block/qcow2-cluster.c +++ b/block/qcow2-cluster.c @@ -1320,6 +1320,7 @@ static bool cluster_needs_new_alloc(BlockDriverState = *bs, uint64_t l2_entry) if (l2_entry & QCOW_OFLAG_COPIED) { return false; } + /* fallthrough */ case QCOW2_CLUSTER_UNALLOCATED: case QCOW2_CLUSTER_COMPRESSED: case QCOW2_CLUSTER_ZERO_PLAIN: --=20 2.18.2