From nobody Sun Feb 8 21:28:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599503749; cv=none; d=zohomail.com; s=zohoarc; b=EWc2zZlIju5rtbkSMJspWIpBPD20La7A7aA37ZL9xsah55ETf5lZeixiqpq8HRnHyGRf65gA6B+rcLxN5pA544SD2GyjN3NOrlQR4zakzmZJJWtoidH/u6X2Euwfak7iErbfGSyOlsj8++UytAc6LQZdzMzk3tDv5ot0T6Mv67w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599503749; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tECdwUYF+oIp0oxRe5fDNiplM/uofWjCiUmXCFNzxbM=; b=bojvujwg5K7EOUaPqeyAv3z3iX4uG2bsOcVa7S/wUB3OUjl6UJ8cOiqXtUNgllpCI3F88I0/Co1axHZoPHxIu+URrZThWKdq1pcaWjNw/JIZSF91/Rc6sdFTajKmc/EW0X1dtaF4hgzHnw3f6XNM93iZJ4sLrxQZ4NCy0cRuUfQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1599503749504504.77729446768365; Mon, 7 Sep 2020 11:35:49 -0700 (PDT) Received: from localhost ([::1]:43356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFLzY-00004v-86 for importer@patchew.org; Mon, 07 Sep 2020 14:35:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFLlM-0005wj-7p for qemu-devel@nongnu.org; Mon, 07 Sep 2020 14:21:08 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:50315 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kFLlK-0004h3-Do for qemu-devel@nongnu.org; Mon, 07 Sep 2020 14:21:07 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-125-j7KVAvCRPBeQthJ0W7AJ7A-1; Mon, 07 Sep 2020 14:21:03 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 02791801F98; Mon, 7 Sep 2020 18:21:03 +0000 (UTC) Received: from linux.fritz.box.com (ovpn-114-154.ams2.redhat.com [10.36.114.154]) by smtp.corp.redhat.com (Postfix) with ESMTP id DBE2E60BF3; Mon, 7 Sep 2020 18:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599502865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tECdwUYF+oIp0oxRe5fDNiplM/uofWjCiUmXCFNzxbM=; b=Nrlsv+PjG3D+7qvviR5t/oBnT6xuVb3V0NfzHhk/fbAOdZ0+26dlhyuhcQzgSDVcb7smnu Zcvmd0ucc1AkjAUwlP1yPbpP+6O5KcxUUgip9ZDf/AlpdjCSvc/AN/WdRfuWRpLLRLlG0M 54BShhmlpGnRPeD7AU8wZhqy4cv135Y= X-MC-Unique: j7KVAvCRPBeQthJ0W7AJ7A-1 From: Kevin Wolf To: qemu-block@nongnu.org Subject: [PATCH 27/29] nbd: Deprecate nbd-server-add/remove Date: Mon, 7 Sep 2020 20:20:09 +0200 Message-Id: <20200907182011.521007-28-kwolf@redhat.com> In-Reply-To: <20200907182011.521007-1-kwolf@redhat.com> References: <20200907182011.521007-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/06 22:29:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" These QMP commands are replaced by block-export-add/del. Signed-off-by: Kevin Wolf --- qapi/block-export.json | 11 +++++++++-- docs/system/deprecated.rst | 8 ++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/qapi/block-export.json b/qapi/block-export.json index ebdfa978e0..ace0d66e17 100644 --- a/qapi/block-export.json +++ b/qapi/block-export.json @@ -108,13 +108,16 @@ # # The export name will be used as the id for the resulting block export. # +# Features: +# @deprecated: This command is deprecated. Use @block-export-add instead. +# # Returns: error if the server is not running, or export with the same name # already exists. # # Since: 1.3.0 ## { 'command': 'nbd-server-add', - 'data': 'NbdServerAddOptions', 'boxed': true } + 'data': 'NbdServerAddOptions', 'boxed': true, 'features': ['deprecated']= } =20 ## # @BlockExportRemoveMode: @@ -147,6 +150,9 @@ # @mode: Mode of command operation. See @BlockExportRemoveMode description. # Default is 'safe'. # +# Features: +# @deprecated: This command is deprecated. Use @block-export-del instead. +# # Returns: error if # - the server is not running # - export is not found @@ -155,7 +161,8 @@ # Since: 2.12 ## { 'command': 'nbd-server-remove', - 'data': {'name': 'str', '*mode': 'BlockExportRemoveMode'} } + 'data': {'name': 'str', '*mode': 'BlockExportRemoveMode'}, + 'features': ['deprecated'] } =20 ## # @nbd-server-stop: diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 851dbdeb8a..9a2e083f00 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -303,6 +303,14 @@ chardev client socket with ``wait`` option (since 4.0) Character devices creating sockets in client mode should not specify the 'wait' field, which is only applicable to sockets in server mode =20 +``nbd-server-add`` and ``nbd-server-remove`` (since 5.2) +'''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +Use the more generic commands ``block-export-add`` and ``block-export-del`` +instead. + +Use argument value ``null`` instead. + Human Monitor Protocol (HMP) commands ------------------------------------- =20 --=20 2.25.4