From nobody Sun Nov 16 09:01:31 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.68 as permitted sender) client-ip=209.85.128.68; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f68.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1599443748; cv=none; d=zohomail.com; s=zohoarc; b=WrJNXspGUHhGlL4ENH7Kb67yTZ1oRx67g71DmBZ/jw2DmyU1OWs1Ljb23sw0akTBq72aYY0a6HyX4DHeGNH0Owuw9lsEVE3IpKSerroBBa1Qe+bZGaAwcMYXnM0GCNZuFxLdMmQbVqydHXBCte8WwYVanDUok6fGmLawGxtyGKY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599443748; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rOdtOAtfcg70s6XvC95J7b24iDolYSlhUR8qCVqx1mg=; b=LMeGi7NT57TwoHx80gv7xwolaLTrHS04Iq7GKv/Fsph0BIoAmizIFLfNcx+sMIal+bNLLCM+qDfvSsI+nNbv2vuMzWUZjCkd0Y+zNiQmcF9cRXFmZ2FD/QbD9cl51rQTjDRfzk/5Qc9xYnKuthqMJwP6piouhL9HauPBh+Oq1w0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.zohomail.com with SMTPS id 159944374815935.36756609227541; Sun, 6 Sep 2020 18:55:48 -0700 (PDT) Received: by mail-wm1-f68.google.com with SMTP id e17so12876319wme.0 for ; Sun, 06 Sep 2020 18:55:47 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (65.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.65]) by smtp.gmail.com with ESMTPSA id b84sm29377773wmd.0.2020.09.06.18.55.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Sep 2020 18:55:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rOdtOAtfcg70s6XvC95J7b24iDolYSlhUR8qCVqx1mg=; b=TT96a1438TOU1/6XpjJ8jj2zBffaiIoSy0PrPjy/Ye7Lj+J3ZhA8EyX/9nIO75eO27 OspzVsLIAY4GzBsdrgV2/qCgv9hHMiCL/LUUC2fK74JnxksNAh3ZCVqgpYQxt4Q7pOdQ VaHrUjCCooeQSWR3kRfnDbz9K2fn4pOlyBm9xvxUkQ4D0prr0oPhH6JKO6j948TYJuGo 0AENerUpdiidW8eJgYhJF37rXkvjtHmffAQ5EcZLRR+UtOlTfXF0wWN6aRSXB2JTWHPY 1gqSeMlrCUC6nx4HRrXe3SVrdS69w4lWdklPqL0z9rtRUhQ1/zABfaWez8LkqBHlqPNb GA7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=rOdtOAtfcg70s6XvC95J7b24iDolYSlhUR8qCVqx1mg=; b=pG+1Y/txEOvivQCL9QJQL+aDF0E5d3I6uWIsw+WwcSosuy49n7tIwya4gTZ3NdzFSk FfG+FgVJBNRs0MLp59J3u66kedkhkG8KiVMEWBcsNUs8/oDDnfli8JBtTp4crjz6opJi vS7cWWab8Incb6YDNLO4fAmTCUrSyf3TLwMrjdZ9X7Mu8o32MgVvC4BT8XUHth6sGYY6 Gw21zeFuuOpcReFD+gTqiAU5PZtAOyJm0i24FkmsRidC38UU/NFprC8lMTM9BGtemcQc kE9/Od20Gul7AMbGpcX4YhLft1TKGn+5Rhll58ZZYiord4IeZScXJcc5mBtm7vX6rWaM IlSA== X-Gm-Message-State: AOAM533mtnblvblKCxc6QRKswmhL5i3Y9AoxX1voG4zitV1Kg/fFkc+r n5PNNknZOTJ63wxAEh9a6Xw= X-Google-Smtp-Source: ABdhPJyp8VaHrFYgHeJQJsDHWfkSgg16a4KeNBjBfG3vUUMYvh7lgQs1hEDw1k3xQa+VU3SkLTUYAw== X-Received: by 2002:a1c:6145:: with SMTP id v66mr19218611wmb.171.1599443746206; Sun, 06 Sep 2020 18:55:46 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 6/7] hw/char/serial-isa: Alias QDEV properties from generic serial object Date: Mon, 7 Sep 2020 03:55:34 +0200 Message-Id: <20200907015535.827885-7-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200907015535.827885-1-f4bug@amsat.org> References: <20200907015535.827885-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Instead of overwritting the properties of the generic 'state' object, alias them. Note we can now propagate the "baudbase" property. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/char/serial-isa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/serial-isa.c b/hw/char/serial-isa.c index a0c338796d5..0626edda8d1 100644 --- a/hw/char/serial-isa.c +++ b/hw/char/serial-isa.c @@ -115,8 +115,6 @@ static Property serial_isa_properties[] =3D { DEFINE_PROP_UINT32("index", ISASerialState, index, -1), DEFINE_PROP_UINT32("iobase", ISASerialState, iobase, -1), DEFINE_PROP_UINT32("irq", ISASerialState, isairq, -1), - DEFINE_PROP_CHR("chardev", ISASerialState, state.chr), - DEFINE_PROP_BOOL("wakeup", ISASerialState, state.wakeup, false), DEFINE_PROP_END_OF_LIST(), }; =20 @@ -137,6 +135,8 @@ static void serial_isa_initfn(Object *o) ISASerialState *self =3D ISA_SERIAL(o); =20 object_initialize_child(o, "serial", &self->state, TYPE_SERIAL); + + qdev_alias_all_properties(DEVICE(&self->state), o); } =20 static const TypeInfo serial_isa_info =3D { --=20 2.26.2