From nobody Sun Nov 16 09:01:31 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.66 as permitted sender) client-ip=209.85.128.66; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f66.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1599443743; cv=none; d=zohomail.com; s=zohoarc; b=NT2CTJFwkiWuZ6XQMq6yaFhagvhdp18GpmQ1jTUhg325DuUh3xsbRZ6LwUT9twY2I01QNJ41EEH9u9/JaRyggy0uUVSrnd0keuAs1z6u0P6IhkG0tTNNKexHsxh6/YemXniMoFPpL9ad9fzDId/j1imzXtKQL7g4g0vJtlD+MO8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599443743; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ziCw1jrdbRRxzZUuAacPeDfn99gOs6JW3cbKwKy/6Wo=; b=m/gwO4AqkdF+AqNq5URB/ya6gIKktEDCDjkMcOZgAMzB9aZvbX9+li+SO6dkJtlaDtMn+ym9wa8yQzYE2RjQINE89dVv+oZcw8foatI04C+L+C1B1NS7OqmqDT/CLC0Du8f4pl2iWTogAlWIItWGiRSyuxvM9fq2tckZXXYAkBs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.zohomail.com with SMTPS id 1599443743770185.36900389687526; Sun, 6 Sep 2020 18:55:43 -0700 (PDT) Received: by mail-wm1-f66.google.com with SMTP id v4so12655882wmj.5 for ; Sun, 06 Sep 2020 18:55:43 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (65.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.65]) by smtp.gmail.com with ESMTPSA id b84sm29377773wmd.0.2020.09.06.18.55.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Sep 2020 18:55:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ziCw1jrdbRRxzZUuAacPeDfn99gOs6JW3cbKwKy/6Wo=; b=ZAKXwIlcheRQ7uF37G0Dw/DfnyfX5wqZKGp1+82B+xSifzGM6ZyoVOImVmIi4Rpc4q RLKMsl7/hnNTi0WhrtNcucLt0F/WQNWJbD0P4RpyiGFAtGswN2Eya/MBpN59KOZbFN2/ p830v0NIPzfSaniixt1aM6PCSEl/bdp0p9N/ytv2nLHb0qYUmzL+zhwIeh1ru/TPR3t/ yAjXd1MajOZ4DC4q8nFMkMXJQQxsKBzvDVCo1kZCSFaPN+OrqV4yFLX1Y1z4I/+5iWPJ kHsoNK5qP4nW5/nD5ZqzVdzQo6PYSTtyMr5Q/x/L5NrZwEx/coQH+2clx9c3VE2XrMWa v8KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ziCw1jrdbRRxzZUuAacPeDfn99gOs6JW3cbKwKy/6Wo=; b=Q0C71PeujzmOYeo6Tpq8Wc45k3nzEqoLn6LrKhxesH2UPUk2eAKC3yIRwkp5ko/izx RbYSaPc4rbg2CaWpzDeyCqOL2ic/67amNbyAcNVgPRq+ugyNc47BhDd7cXnY40SqqzoZ JLWqDMsQM/ng2boAO9xrv4K6Ee4iFzensJdZipAwItn9ASF9+V+4zSuVtEH1TsHc1VHv sGB+GITbmt8YjJyYaWpRh9MrANjw8cN4v2FWDnvx+yfKhZ+8suhET8JUf4sB/eCd1ZT4 3RxWh/21ZMYOElx3mAXHCgzfTX6G52V/wyb1IAH13avt87WZ9tUsdPczLwLiYvum9F7w CviQ== X-Gm-Message-State: AOAM530EbtHHS8oM/m6uvEY5vb/GuzOwErhhU1rf7dsW4lfKItpGDukO JPYlBChfjH4YophRlGuQJ1U78ODbQqM= X-Google-Smtp-Source: ABdhPJwNPzGEimfV5QOVz6vrgn92szWy9wM++PUUZin7MUiYC/kpwkBNb+m+g9zmFtBocHxJClDB3A== X-Received: by 2002:a05:600c:2317:: with SMTP id 23mr19335637wmo.183.1599443741827; Sun, 06 Sep 2020 18:55:41 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH 3/7] hw/char/serial: Remove old DEBUG_SERIAL commented code Date: Mon, 7 Sep 2020 03:55:31 +0200 Message-Id: <20200907015535.827885-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200907015535.827885-1-f4bug@amsat.org> References: <20200907015535.827885-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) All useful DPRINTF() calls have been converted to trace events. Remove a pointless one in the IOEventHandler, and drop the DEBUG_SERIAL ifdef'ry. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/char/serial.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/hw/char/serial.c b/hw/char/serial.c index fb41337b661..1e70294f28a 100644 --- a/hw/char/serial.c +++ b/hw/char/serial.c @@ -36,8 +36,6 @@ #include "trace.h" #include "hw/qdev-properties.h" =20 -//#define DEBUG_SERIAL - #define UART_LCR_DLAB 0x80 /* Divisor latch access bit */ =20 #define UART_IER_MSI 0x08 /* Enable Modem status interrupt */ @@ -102,14 +100,6 @@ =20 #define MAX_XMIT_RETRY 4 =20 -#ifdef DEBUG_SERIAL -#define DPRINTF(fmt, ...) \ -do { fprintf(stderr, "serial: " fmt , ## __VA_ARGS__); } while (0) -#else -#define DPRINTF(fmt, ...) \ -do {} while (0) -#endif - static void serial_receive1(void *opaque, const uint8_t *buf, int size); static void serial_xmit(SerialState *s); =20 @@ -636,7 +626,6 @@ static void serial_receive1(void *opaque, const uint8_t= *buf, int size) static void serial_event(void *opaque, QEMUChrEvent event) { SerialState *s =3D opaque; - DPRINTF("event %x\n", event); if (event =3D=3D CHR_EVENT_BREAK) serial_receive_break(s); } --=20 2.26.2