From nobody Sun Nov 16 09:03:08 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.65 as permitted sender) client-ip=209.85.221.65; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f65.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1599443742; cv=none; d=zohomail.com; s=zohoarc; b=VAzs/YnDl43U5nddqNvCdX8qy2Dhos2hfWO15TTRuJU3qs59KvlpJzLVAvyjN1FDmIjmKTvYAMLZalmvFlICJLEZij029Zfi3iFA+zpvszc8+WaffVY91lJXho4CRFgNudMjBxCiZZIR0nWXX5uKkMDohdXRtjvFBr5W677d8O8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599443742; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JF7kT9Jakz5MXZ7s85w029ixb/+6fikTUFTZrRv4yoU=; b=CT7CyeKDPOlCrAMFd9QTROmftQ3NZVFLQVLIlBvDcWtW/sU3c1wH+uSrkXDD63+MDsheqm9iQMH/73GlCHLjh+wd1XUPa09IrB3xY7yPcRTbxQQzLVcibDKgdlXq/Qh3vWiBqo0Qn0/OMxPvM2l06FkqVaSCJ58jKyMM1KoIXP0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.zohomail.com with SMTPS id 1599443742603337.6543381533751; Sun, 6 Sep 2020 18:55:42 -0700 (PDT) Received: by mail-wr1-f65.google.com with SMTP id c15so14039353wrs.11 for ; Sun, 06 Sep 2020 18:55:41 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (65.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.65]) by smtp.gmail.com with ESMTPSA id b84sm29377773wmd.0.2020.09.06.18.55.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Sep 2020 18:55:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JF7kT9Jakz5MXZ7s85w029ixb/+6fikTUFTZrRv4yoU=; b=ATpKEDrJ7K9awH1N2zYTl4yBM9vwgdywoDL8jJwFb0map4kJ1wW5Z6SzgmkBLz6Di1 4+J89Zkp0QYSl/r/M91ckYgeDfnshUAdYUAwDZ3jkVqeaC5CbtrEPPKLwoHihsv1pcmG /tyiLuSpV9SCW9XFjVC1ifDvER1j9gedYUd1vK1QWQQd4onN5NYyUXPI2KEj/go04Yhp Zr4ScnsbSukE3j4I63uUQDzIW1OJlr7uwAlYA0kUv7ChD/LtZbe1m1F/jpYDX6ESedGO IOu21GsUwvi4leEM8WIe359yXNL2rInLotpGuyvnwuKHnGyQ7xGMCL0gsnLrsUJsCRX9 EmEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=JF7kT9Jakz5MXZ7s85w029ixb/+6fikTUFTZrRv4yoU=; b=bxpodEshLjvcOrUonef2Un1EEWWsRU2/lZloXfJxxn/pKz9Gfhcoy5tmlh6JGDjG8e JBRcZf2zhBv7OrL9ybIz6JAQ7GGHaAZAGrkHlt4porvAeezXHnsRjHghGgxLezs8Eo9R L4cePAikN6wY01kE+s3W0kZUg1Wk8Jepv1yaxciaL9JC/vm5Aog311jdNQX3am59cssG H4YIuM/vD1Z6Lt6h/a9tckDnsy5hHo0a1iwqFtDN29ns43yjJ3cXGP/htI+mrjHUEvSG wBFxHMp+azYjEi2Ykl+gZ5YFjfZFTbngVwvGuruZovLBW1lkmGa3jpfphqZ7yUPA48+F X3KQ== X-Gm-Message-State: AOAM532hPKISfND0jdgRSRXIGtuvr3hJLqiM/UJI6NjzGNHkKvIeutXp CH7Ug0wWUVnYd18ezjqcFDYb5dZZSQE= X-Google-Smtp-Source: ABdhPJxdbJIbUhDSxyWa3OoBkrlsOphRHXMZU37nN6v0gCouNh4gRK5/N8Tw4mT/s7687uE4t+h37Q== X-Received: by 2002:adf:dfd1:: with SMTP id q17mr21031760wrn.347.1599443740620; Sun, 06 Sep 2020 18:55:40 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH 2/7] hw/char/serial: Replace commented DPRINTF() by trace event Date: Mon, 7 Sep 2020 03:55:30 +0200 Message-Id: <20200907015535.827885-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200907015535.827885-1-f4bug@amsat.org> References: <20200907015535.827885-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Convert the old debug PRINTF() call to display the UART baudrate to a trace event. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/char/serial.c | 4 +--- hw/char/trace-events | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/char/serial.c b/hw/char/serial.c index a855ef66ea2..fb41337b661 100644 --- a/hw/char/serial.c +++ b/hw/char/serial.c @@ -187,9 +187,7 @@ static void serial_update_parameters(SerialState *s) ssp.stop_bits =3D stop_bits; s->char_transmit_time =3D (NANOSECONDS_PER_SECOND / speed) * frame_si= ze; qemu_chr_fe_ioctl(&s->chr, CHR_IOCTL_SERIAL_SET_PARAMS, &ssp); - - DPRINTF("speed=3D%.2f parity=3D%c data=3D%d stop=3D%d\n", - speed, parity, data_bits, stop_bits); + trace_serial_update_parameters(speed, parity, data_bits, stop_bits); } =20 static void serial_update_msl(SerialState *s) diff --git a/hw/char/trace-events b/hw/char/trace-events index d20eafd56f8..85e39d9d62b 100644 --- a/hw/char/trace-events +++ b/hw/char/trace-events @@ -7,6 +7,7 @@ parallel_ioport_write(const char *desc, uint16_t addr, uint= 8_t value) "write [%s # serial.c serial_ioport_read(uint16_t addr, uint8_t value) "read addr 0x%02x val 0x%= 02x" serial_ioport_write(uint16_t addr, uint8_t value) "write addr 0x%02x val 0= x%02x" +serial_update_parameters(uint64_t baudrate, char parity, int data_bits, in= t stop_bits) "baudrate=3D%"PRIu64" parity=3D'%c' data=3D%d stop=3D%d" =20 # virtio-serial-bus.c virtio_serial_send_control_event(unsigned int port, uint16_t event, uint16= _t value) "port %u, event %u, value %u" --=20 2.26.2