From nobody Sun Nov 16 09:01:32 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.68 as permitted sender) client-ip=209.85.128.68; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f68.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1599443741; cv=none; d=zohomail.com; s=zohoarc; b=Z+btkaXid1eLY4k5NsoafuIvi0Sle9Pq9tfnj7acjMAQM0EvDAHT7R/vEue1tOBL5FBgNAWLJTeuf3QyNqcyKGZ8MUedMgi829UCpOykGSwaHdtRdTWHIBRW0+oWn2cQxb9E4BbHVnt4lzFPnC2NpFP6xcYB8twSaPWwPT5dOvY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599443741; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xNSWRDcvmAyUx6UsL/JgHCLjynBWkV6qzS6fjCc2u/4=; b=j6u0el/QDXP6eRQ5vs2T6baI2Zns33jCpRH/uKSQtpIWYjD1EFiai4/L0yJ537J++X5g9zEmYztv7Q1P7uG64Hg+bZ3GiU4cIdKGxbCF0rYdplNk56r3xcy21N6AlgUlVGO1qSMpdxvzuxSd+AKHzkds46IBXwv1HQhOVqPvEFc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.zohomail.com with SMTPS id 1599443741318733.5604709798974; Sun, 6 Sep 2020 18:55:41 -0700 (PDT) Received: by mail-wm1-f68.google.com with SMTP id a65so12845168wme.5 for ; Sun, 06 Sep 2020 18:55:40 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (65.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.65]) by smtp.gmail.com with ESMTPSA id b84sm29377773wmd.0.2020.09.06.18.55.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Sep 2020 18:55:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xNSWRDcvmAyUx6UsL/JgHCLjynBWkV6qzS6fjCc2u/4=; b=Ub12186lydpQdjQDobPDaDVAcemBEmB5K40dMvKJkSB4NPwZe+ePaSCTfAtLdNC6FI bPKAbNK2I1GZdMocOGUEF2FmGJ+Q3UxXfYMtixrAhgaQyVzopbKZmw49NoxW+YqAZBBU hcMRo07l0cTCY+sSYslnlDHhfMkcI+j71dS+KfYkb36Nn8sTXQAZfUjIJNMGPZUMcvU3 nH67StjksCps87QX2UiWtnwqvQtwPPPplnVekeRLaGnF/eauSn5Cz8pHlLPUjLLu7XIW L254QH11I365LiZyXqtLL10amJCV9NfsB6laJDf3NHG9gOcaXwTDKTFpy+r0M7B4qh7o 5mXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=xNSWRDcvmAyUx6UsL/JgHCLjynBWkV6qzS6fjCc2u/4=; b=lF8B8OV6wISS56KVFKE/Jujfb1xvQ/K9uKEjdjhlDgL+ZcHqGJiotPX2M35LCWcbak rXDqsBz70C++LEqewZek0PsNpTV70f40Ucq8K+aEftsN9bXgDwX8+fuEHCE7mWRAPcjk e759I7PTxQaKH0tjXIYx0ldzZaakpMJwissSO2htb+fRGCUlR9L77kkNI4LIpttlwftV 8u71wgpCpjfve5x5diBxNySb3bn58qVSl1FuuVOpd2cPGmm5WMdSjqlKSUg/ig1RzSNx buPF5DON7DmhwNoHMxdVgkj1PEGUoYos6jmbDRNeny79JyY7tGz1oaBYADPPcWRPA9KW wypA== X-Gm-Message-State: AOAM533RX6vZlSIJhrlH/ds5riRGEINVdiH81j/oUKl09P1uH+2UzzZX a4VAYEFOmX/mAPpuLjukm49d9kjHUaw= X-Google-Smtp-Source: ABdhPJyEeJ8ovfrWSFuAWleTJVWWUnUmlW/AmXhxIIay8RbNE7WPmBWQfXBf3cMkU1RSw28/co5dWA== X-Received: by 2002:a1c:40a:: with SMTP id 10mr18965790wme.61.1599443739377; Sun, 06 Sep 2020 18:55:39 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/7] hw/char/serial: Assert serial_ioport_read/write offset fits 8 bytes Date: Mon, 7 Sep 2020 03:55:29 +0200 Message-Id: <20200907015535.827885-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200907015535.827885-1-f4bug@amsat.org> References: <20200907015535.827885-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The serial device has 8 registers, each 8-bit. The MemoryRegionOps 'serial_io_ops' is initialized with max_access_size=3D1, and all memory_region_init_io() callers correctly set the region size to 8 bytes: - serial_io_realize - serial_isa_realizefn - serial_pci_realize - multi_serial_pci_realize It is safe to assert the offset argument of serial_ioport_read() and serial_ioport_write() is always less than 8. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/char/serial.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/serial.c b/hw/char/serial.c index 23864794929..a855ef66ea2 100644 --- a/hw/char/serial.c +++ b/hw/char/serial.c @@ -344,7 +344,7 @@ static void serial_ioport_write(void *opaque, hwaddr ad= dr, uint64_t val, { SerialState *s =3D opaque; =20 - addr &=3D 7; + assert(size =3D=3D 1 && addr < 8); trace_serial_ioport_write(addr, val); switch(addr) { default: @@ -485,7 +485,7 @@ static uint64_t serial_ioport_read(void *opaque, hwaddr= addr, unsigned size) SerialState *s =3D opaque; uint32_t ret; =20 - addr &=3D 7; + assert(size =3D=3D 1 && addr < 8); switch(addr) { default: case 0: --=20 2.26.2