From nobody Mon Apr 29 00:20:58 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599236844; cv=none; d=zohomail.com; s=zohoarc; b=e6W2fy0gd6G3Nd0QiaK8xVE5Oju2BV+Q0ugnva37jEkK/f+xn0+TjYOoyu/lbXgRy0HBKMbd9O6krA1+et0lhDk9B3VQ7Xm4BnyLb4zGReHzrct5TFE9ZREqeXsv3Mc4CIiuU9REBUZluufcZsxW8mvbH+0TEGsGY8smsbRU4XM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599236844; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wXvwYiip7p7tr6VahU3IzlJqr2MIhqKzvAFhb09t7Wc=; b=BCoEdxvX04HD67b54W89w6Bzaq2SwlTA2odD3afRAI4mo/1LMpAzAiLKh25yFSiAmeQj7BkdLEBIBy4pp3z72lmY3JKQyfB9eWdYQzKr6199r/n6Etf5LQD08B7NM3yHeQZFnEF0RmFwW88Ayc0Q5qh8VwziT3JiF6qb6YMyTik= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159923684409253.16678300367391; Fri, 4 Sep 2020 09:27:24 -0700 (PDT) Received: from localhost ([::1]:57588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEEYc-0007Xy-70 for importer@patchew.org; Fri, 04 Sep 2020 12:27:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEEXo-0006TW-W2 for qemu-devel@nongnu.org; Fri, 04 Sep 2020 12:26:33 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:35032 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kEEXn-000699-DU for qemu-devel@nongnu.org; Fri, 04 Sep 2020 12:26:32 -0400 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-379-4OPIJM8qNEy0AEx2SmMTzA-1; Fri, 04 Sep 2020 12:26:28 -0400 Received: by mail-wm1-f71.google.com with SMTP id k12so3542771wmj.1 for ; Fri, 04 Sep 2020 09:26:28 -0700 (PDT) Received: from localhost.localdomain (50.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.50]) by smtp.gmail.com with ESMTPSA id d6sm12157101wrq.67.2020.09.04.09.26.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2020 09:26:26 -0700 (PDT) X-MC-Unique: 4OPIJM8qNEy0AEx2SmMTzA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wXvwYiip7p7tr6VahU3IzlJqr2MIhqKzvAFhb09t7Wc=; b=g+rMUnwQfaHsY17Lcg5NSk/+gAwJUR63f85QgjSL4p4yTeoA3sJr5Quubr7+qJ7X+h 5PbWYyMjU+kzf4ghYthTDS0/fNgqPiMwlEQfSiF7UOk0Y/Owr3r7qKSUlu0RIO00LsVm uOmVyyQtj7HXyjm2rlEuigtM+H16dQV1WVhkuUm0wMWKw1JIOg+mgWxJE7dIFXOiaHtj tCWHR9r2kQV5j7zu+8FIxwAExv16lFtQQeg+zWHYMMlDWNXcf4KCzeLO1RRaiSFK4qf5 OPVcYNApQOlnY4ntApENeaNVqP+FejkwgfBS08dxAcIG0Xa4KF4oQSnBrkm/jqxO7WLo F27A== X-Gm-Message-State: AOAM531uzWXxbl2RV1JMZoXbqwus84oQqF/zplLDB3CEcDfT9XeBKLO3 1QEnqbGh1jRioJ01lObXoNXYrQKb0HGVOj1dSLsKqH4LhxZTDq28fCJ33ttT4UaNFdU3sT/iRsD 7RM+5Q9WMWDDTuNg= X-Received: by 2002:a1c:2781:: with SMTP id n123mr8263695wmn.27.1599236787558; Fri, 04 Sep 2020 09:26:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUsp0xJqmCy006SprbsF9JgUATGpxhSGRLPQa/+NYA5r3qfG6M5mpK4u3M+q/ff54XBgFZxg== X-Received: by 2002:a1c:2781:: with SMTP id n123mr8263670wmn.27.1599236787342; Fri, 04 Sep 2020 09:26:27 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/3] pci: Let pci_dma_rw() propagate MemTxResult Date: Fri, 4 Sep 2020 18:26:18 +0200 Message-Id: <20200904162620.657726-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200904162620.657726-1-philmd@redhat.com> References: <20200904162620.657726-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/04 03:57:33 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" dma_memory_rw() returns a MemTxResult type. Do not discard it, return it to the caller. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Li Qiang Reviewed-by: Richard Henderson --- include/hw/pci/pci.h | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index a221dfb3b08..a85b0bc3c44 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -785,8 +785,22 @@ static inline AddressSpace *pci_get_address_space(PCID= evice *dev) return &dev->bus_master_as; } =20 -static inline int pci_dma_rw(PCIDevice *dev, dma_addr_t addr, - void *buf, dma_addr_t len, DMADirection dir) +/** + * pci_dma_rw: Read from or write to an address space from PCI device. + * + * Return a MemTxResult indicating whether the operation succeeded + * or failed (eg unassigned memory, device rejected the transaction, + * IOMMU fault). + * + * @dev: #PCIDevice doing the memory access + * @addr: address within the #PCIDevice address space + * @buf: buffer with the data transferred + * @len: the number of bytes to read or write + * @dir: indicates the transfer direction + */ +static inline MemTxResult pci_dma_rw(PCIDevice *dev, dma_addr_t addr, + void *buf, dma_addr_t len, + DMADirection dir) { return dma_memory_rw(pci_get_address_space(dev), addr, buf, len, dir, MEMTXATTRS_UNSPECIFIED); --=20 2.26.2 From nobody Mon Apr 29 00:20:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599236795; cv=none; d=zohomail.com; s=zohoarc; b=WvT0fvvxHHXJ8e8Mvir53we3QvsaLR5cWd8d6XqWtCFfpPavPEL7C1yrxaDpbjDxa83EhIDDmnILuhfZHVD7IXgl/uM81qsen7VWaIk/pn5lDN+B6Rc2+NSurIaK7XYhSIFMNc2TZqLGMElPJ39/h1i5mGxwmp5SzxYVZ5yaPTY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599236795; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=7MorJJURQDaDxlrOa/frWqZVpJ+3nafUOrcrW8fCBG4=; b=giGlqvtagnhCV4VLnevx+mRcovIVYehfiNeKWwB3iWXUHFyQndIufBVSlukrmZlbO5AGmzDG+BXp8nVMgIv+bT9LfuI/27YqCMvtwUpPLhKublGvc5Fh5cjxYeSujtT8OCxVqpoKWiRZdXdN5SKCbaYgwx8GdKn/WKGD696M9uc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1599236795768173.86293006932374; Fri, 4 Sep 2020 09:26:35 -0700 (PDT) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-410-6b9BtvyjNtibFB2VbO_R-w-1; Fri, 04 Sep 2020 12:26:33 -0400 Received: by mail-wr1-f71.google.com with SMTP id 3so2508209wrm.4 for ; Fri, 04 Sep 2020 09:26:33 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (50.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.50]) by smtp.gmail.com with ESMTPSA id q18sm12412399wre.78.2020.09.04.09.26.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2020 09:26:31 -0700 (PDT) X-MC-Unique: 6b9BtvyjNtibFB2VbO_R-w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7MorJJURQDaDxlrOa/frWqZVpJ+3nafUOrcrW8fCBG4=; b=Ak4dZxuvUvqLf/igXOfUfmIF+FSjV4ZymJcXJ/2KmTfEBDNp5Nm0fSLp/YC3jVs9qq I8pLP2kd+w21rS2aAdkOyetjLNOTtHiDPtlvJndHDr8jINTD9RCEPgajArpkDCKUU00z C6wsVqWw7HztLoxHCLUnn9mrFixrh/af3xI3zPDMDqA/7Zed6E6FpUBiULCU5oj0Xkh3 WCsJdQEVI/VMasmVsdVY1ENeJlFrNLpQosmpzXK26DHcPqWeeQ55JFI5TwXk05LBwqx3 EMAdou91UYhfLXUc51qkxyGXJiRcsXwE7MeaG/c7U96BEqN6OII4OCeOtM/4IJtjWeQR UlVg== X-Gm-Message-State: AOAM532PGMOgQPGjj7yCg77pFClqZl28C4kf6X1iClcLqKZVN1Kd84nL UMvra/PoGJXiZVjp37hpLGv00flXQHhWTyMb0rJ4NXNh2eferAx2GGjMmTfEmMe5cU7mJWuG/BD TUx98fg1iZXbfHA== X-Received: by 2002:adf:e481:: with SMTP id i1mr8266609wrm.391.1599236792192; Fri, 04 Sep 2020 09:26:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEmzW5SG4fPJA2/5E/8QGbSX+oqPle12+QfopfydhbnVfctVEgyenq+cJq2upGf1MgIzQ0Mw== X-Received: by 2002:adf:e481:: with SMTP id i1mr8266589wrm.391.1599236792006; Fri, 04 Sep 2020 09:26:32 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Marcel Apfelbaum , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/3] pci: Let pci_dma_read() propagate MemTxResult Date: Fri, 4 Sep 2020 18:26:19 +0200 Message-Id: <20200904162620.657726-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200904162620.657726-1-philmd@redhat.com> References: <20200904162620.657726-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable pci_dma_rw() returns a MemTxResult type. Do not discard it, return it to the caller. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Li Qiang Reviewed-by: Richard Henderson --- include/hw/pci/pci.h | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index a85b0bc3c44..bb57525dffd 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -806,8 +806,20 @@ static inline MemTxResult pci_dma_rw(PCIDevice *dev, d= ma_addr_t addr, dir, MEMTXATTRS_UNSPECIFIED); } =20 -static inline int pci_dma_read(PCIDevice *dev, dma_addr_t addr, - void *buf, dma_addr_t len) +/** + * pci_dma_read: Read from an address space from PCI device. + * + * Return a MemTxResult indicating whether the operation succeeded + * or failed (eg unassigned memory, device rejected the transaction, + * IOMMU fault). Called within RCU critical section. + * + * @dev: #PCIDevice doing the memory access + * @addr: address within the #PCIDevice address space + * @buf: buffer with the data transferred + * @len: length of the data transferred + */ +static inline MemTxResult pci_dma_read(PCIDevice *dev, dma_addr_t addr, + void *buf, dma_addr_t len) { return pci_dma_rw(dev, addr, buf, len, DMA_DIRECTION_TO_DEVICE); } --=20 2.26.2 From nobody Mon Apr 29 00:20:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599236800; cv=none; d=zohomail.com; s=zohoarc; b=oGWwei5UbWnChDjrXjXKbpbtAfT0YjF7aZyFOxqXRfvVLx1HhEj92lxKuN88ikRSYiCLpIcx2N3+vhm29QJJjoq4xeeibxPZr5K2y5PmUw3tb0wjTROBzUaH6iARUVK0zat7UVIoZXYIuqai/bLODmZnWyirPX0GXMKAgyHC4Qc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599236800; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=GdvdfUi8dGdv0X8iaMX8T8wTAWC4cqEFs01+jCQjKC4=; b=FmOT4yKO8J8/V+Iyo2oMVSye+MVu212bK6eOSVaMD+zbOxMQAIH4t3Vlr6Ffb233ZeHDPBkMJP58Smc0eFZ41++8+YuXH9E1XlNav/LNVPJdp6C6Zwod0jeFyyWNSUs3ZKPgE7IH45Y+S8AD1ERgSLDG7Na6FEsQzs7SA4PBW8I= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1599236800525282.87352770699397; Fri, 4 Sep 2020 09:26:40 -0700 (PDT) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-528-Z_7LoMHsM-yY930UuZ_zgA-1; Fri, 04 Sep 2020 12:26:38 -0400 Received: by mail-wr1-f70.google.com with SMTP id i10so2487239wrq.5 for ; Fri, 04 Sep 2020 09:26:37 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (50.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.50]) by smtp.gmail.com with ESMTPSA id 189sm12479473wmb.3.2020.09.04.09.26.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2020 09:26:36 -0700 (PDT) X-MC-Unique: Z_7LoMHsM-yY930UuZ_zgA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GdvdfUi8dGdv0X8iaMX8T8wTAWC4cqEFs01+jCQjKC4=; b=IfZuLRcCzPuDnUt0QZakhYCaly5UZpiH70GZctkrc8Se5c16GJDE5HiYYSBz1lYUMr 0Q3PuKf7XD/nl6SsUo6RJcv5aWxMErWexdFlE18zb9rVMfWy/f+LPdhda+bG5PAst1Qv PB1kC8q9aXachG3vvPahHQgVY8NwB/wQ77WNgZXB6EtjlPa/XqiZyMAvmakVhGyAE4ku Z6KpbNr9nDR11Ln4PcXDCx65UHq1E0oPYnUg2gSGWEfnLXQXcXINpsi7gWgu+zM/3cKe fFSpr2A1Ov2zbb2+QqvI/If/PTGLqWsYOhImRp1O63C7KaTj9wvzF1UKzGXoSq4LL9zi xjhw== X-Gm-Message-State: AOAM531HsLDrzZ6bngrnY6ogH1DHbY0vbObWi8tkQmKDd7GBpNvqj7fb 7216kMue3fq2yYmtM/W6AYCjaZ+5MzZr5FHTPLKw9raBmkdH5uaqfnD+Cj4LVFB3vuVNTIbxfVF dPSezhiMFRwvwbA== X-Received: by 2002:a1c:7215:: with SMTP id n21mr5323038wmc.154.1599236796732; Fri, 04 Sep 2020 09:26:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9Qj9qQ2RsQJL+8y+3agMRElI17bTJ7XjUIbySjwHTCX/9+uTnZDOkfoFuyP6BiiHl1SuKXQ== X-Received: by 2002:a1c:7215:: with SMTP id n21mr5323027wmc.154.1599236796567; Fri, 04 Sep 2020 09:26:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Marcel Apfelbaum , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/3] pci: Let pci_dma_write() propagate MemTxResult Date: Fri, 4 Sep 2020 18:26:20 +0200 Message-Id: <20200904162620.657726-4-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200904162620.657726-1-philmd@redhat.com> References: <20200904162620.657726-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable pci_dma_rw() returns a MemTxResult type. Do not discard it, return it to the caller. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Li Qiang Reviewed-by: Richard Henderson --- include/hw/pci/pci.h | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index bb57525dffd..76826e240a9 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -824,8 +824,20 @@ static inline MemTxResult pci_dma_read(PCIDevice *dev,= dma_addr_t addr, return pci_dma_rw(dev, addr, buf, len, DMA_DIRECTION_TO_DEVICE); } =20 -static inline int pci_dma_write(PCIDevice *dev, dma_addr_t addr, - const void *buf, dma_addr_t len) +/** + * pci_dma_write: Write to address space from PCI device. + * + * Return a MemTxResult indicating whether the operation succeeded + * or failed (eg unassigned memory, device rejected the transaction, + * IOMMU fault). + * + * @dev: #PCIDevice doing the memory access + * @addr: address within the #PCIDevice address space + * @buf: buffer with the data transferred + * @len: the number of bytes to write + */ +static inline MemTxResult pci_dma_write(PCIDevice *dev, dma_addr_t addr, + const void *buf, dma_addr_t len) { return pci_dma_rw(dev, addr, (void *) buf, len, DMA_DIRECTION_FROM_DEV= ICE); } --=20 2.26.2