From nobody Mon Feb 9 13:59:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599234315; cv=none; d=zohomail.com; s=zohoarc; b=dZ9HEdmBJMwEewhEqvDgQtnyRMg0VPcWN3EiKUDUikVy7QC58VB1E3dywxsZRb2yOprWgMgBP8zgJXfDslBYQIiCnxKSJIRGFxtCg9k3VrtCULsRaPTlDPqmKVeEaRMfKsFKEnxoTPFgNlK2z6m6Hx+SiSOcpkA57VvbuXFLFYA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599234315; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=i7iJC1mwPlkCljaia40Coq6k2ckspF1fbeJzPRIKgYw=; b=II2eXzvE7RMnPehSW08wrg/7pxRRARHDcLjiXeh6yG+HdEdhwBswKhT2/xSPpMTudB2v+CpxiT8VfmHjSIyZ7E1Twopc+CN2PNGhx2mMGVuShl/akFfI9kYdou/Bgv7XuJukYVuryEA8R1lGcYoTCSe1QOWKK/owKAS9+1BhfOA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1599234315192585.5344936292524; Fri, 4 Sep 2020 08:45:15 -0700 (PDT) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-319-HhRvhlTzOvG-4xvY2UKQfw-1; Fri, 04 Sep 2020 11:45:12 -0400 Received: by mail-wm1-f72.google.com with SMTP id a144so1829714wme.9 for ; Fri, 04 Sep 2020 08:45:12 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (50.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.50]) by smtp.gmail.com with ESMTPSA id 92sm13343137wra.19.2020.09.04.08.45.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2020 08:45:10 -0700 (PDT) X-MC-Unique: HhRvhlTzOvG-4xvY2UKQfw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i7iJC1mwPlkCljaia40Coq6k2ckspF1fbeJzPRIKgYw=; b=tuQ++QeFD+CSARMiROkPmwm0SRQJ3rZAI2XRbkjRPDng9Tm7hm3kQvLykVdC9Py611 pOenOUSg9JCV72PGXQM3AtIU3UczhhJQge3Ovp1TOJP/WaJPVkpvivc5EtmzyROH11TB kOGWvYrxb2wt2O9RZ1FALyHkbBjCq2yWxJO9w0vMy6w43+rHxiz1d0gGjRUIpYqeN1Oa sFIh5n6it3I5Uc3J3QknnL4NKd2IGrh6vc8kMwZ59RP+niVp0FYtd9NPo+FkYykloUWz mUYeX3R18W8o0KL0X9rz8u8ttbpYnkA2FtuMO6T6HiaY477pL0mGVxZP0afGObBdzxun +//A== X-Gm-Message-State: AOAM530fnVnWe5DzmICalpjPw5d6d6buu3Lcd++bp3QGl0huxxFgex3t dahqfwe0j25AQl8pC/xViEnHob8DFEom+bfLzocaAUiB8OBJTPwudKD+p3+o+p7YwcUVEUIfkU/ rPx70dFATYR4KFQ== X-Received: by 2002:a7b:cc8f:: with SMTP id p15mr8238152wma.18.1599234311160; Fri, 04 Sep 2020 08:45:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzT7Q4ncElC0kjC3GurLgpimQG2OqwITFLYV5TGQlNp3mFO4DrTejodazSeRw+YYLQQ5xC/Cg== X-Received: by 2002:a7b:cc8f:: with SMTP id p15mr8238120wma.18.1599234310985; Fri, 04 Sep 2020 08:45:10 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Paolo Bonzini Cc: Laszlo Ersek , Marcel Apfelbaum , "Edgar E. Iglesias" , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , Mark Cave-Ayland , Jason Wang , Peter Xu , "Michael S. Tsirkin" , Jan Kiszka , Eric Auger , David Gibson , Beniamino Galvani , Andrew Jeffery , Richard Henderson , Joel Stanley , Eduardo Habkost , Alistair Francis , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , qemu-ppc@nongnu.org, qemu-arm@nongnu.org, Peter Maydell , Andrew Baumann , Peter Chubb , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 05/13] dma: Let dma_memory_rw() propagate MemTxResult Date: Fri, 4 Sep 2020 17:44:31 +0200 Message-Id: <20200904154439.643272-6-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200904154439.643272-1-philmd@redhat.com> References: <20200904154439.643272-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable address_space_rw() returns a MemTxResult type. Do not discard it, return it to the caller. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Li Qiang Reviewed-by: Richard Henderson --- include/sysemu/dma.h | 30 ++++++++++++++++++++++-------- 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/include/sysemu/dma.h b/include/sysemu/dma.h index ad8a3f82f47..661d7d0ca88 100644 --- a/include/sysemu/dma.h +++ b/include/sysemu/dma.h @@ -80,12 +80,13 @@ static inline bool dma_memory_valid(AddressSpace *as, MEMTXATTRS_UNSPECIFIED); } =20 -static inline int dma_memory_rw_relaxed(AddressSpace *as, dma_addr_t addr, - void *buf, dma_addr_t len, - DMADirection dir) +static inline MemTxResult dma_memory_rw_relaxed(AddressSpace *as, + dma_addr_t addr, + void *buf, dma_addr_t len, + DMADirection dir) { - return (bool)address_space_rw(as, addr, MEMTXATTRS_UNSPECIFIED, - buf, len, dir =3D=3D DMA_DIRECTION_FROM_= DEVICE); + return address_space_rw(as, addr, MEMTXATTRS_UNSPECIFIED, + buf, len, dir =3D=3D DMA_DIRECTION_FROM_DEVICE= ); } =20 static inline int dma_memory_read_relaxed(AddressSpace *as, dma_addr_t add= r, @@ -101,9 +102,22 @@ static inline int dma_memory_write_relaxed(AddressSpac= e *as, dma_addr_t addr, DMA_DIRECTION_FROM_DEVICE); } =20 -static inline int dma_memory_rw(AddressSpace *as, dma_addr_t addr, - void *buf, dma_addr_t len, - DMADirection dir) +/** + * dma_memory_rw: Read from or write to an address space from DMA controll= er. + * + * Return a MemTxResult indicating whether the operation succeeded + * or failed (eg unassigned memory, device rejected the transaction, + * IOMMU fault). + * + * @as: #AddressSpace to be accessed + * @addr: address within that address space + * @buf: buffer with the data transferred + * @len: the number of bytes to read or write + * @dir: indicates the transfer direction + */ +static inline MemTxResult dma_memory_rw(AddressSpace *as, dma_addr_t addr, + void *buf, dma_addr_t len, + DMADirection dir) { dma_barrier(as, dir); =20 --=20 2.26.2