From nobody Tue Feb 10 05:41:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1599191918; cv=none; d=zohomail.com; s=zohoarc; b=N5I4ZMUWqjMigGP4n1VAlPj8uD1K//BskFWpVdKpcMYCuhApT5BdEipDQX9WtWG/+y9+aj28byZBOiLcaHInn7PolkXgTUNKYvO1BTR+VvBNd7lDVIlomMkRtGy6qGQZeJ5HS7WUeSor5qSHuJwc51DMmYMUiEhW8W9HSJ7JCSk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599191918; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=o0tU18fMExzu7qA7VWBNeZXlI9dJN9oGrqpqV294rGI=; b=GIZsEfizEQBCKULLlYoqhmvSCiUwKQhJWBdDQmRdXrHuZSDx1vDT2cMVM2jA/MsSmcHCf+sC+UdjTerOsRJEBqiiYYFagowhIWryKNPPUiVxL0Y6kT/Nh6zsDRSWB5IsXLOsgdpxsjakp0IcdCWKvU4aw5NN5i+J/JNSoL+55LI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1599191918599452.683096421978; Thu, 3 Sep 2020 20:58:38 -0700 (PDT) Received: from localhost ([::1]:48546 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kE2s1-00051r-QO for importer@patchew.org; Thu, 03 Sep 2020 23:58:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kE2i0-0003X7-3S; Thu, 03 Sep 2020 23:48:16 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:53953) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kE2hy-0004yU-6N; Thu, 03 Sep 2020 23:48:15 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4BjNst1VwTz9sWC; Fri, 4 Sep 2020 13:47:30 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1599191250; bh=cdhL0/jPVxK+ALKqIw6+psSZs6LOfD1nDBLYAnFnOOQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AHR5vy8qJNwCG7k1bKuf5iwDEnD7H1tLUdoCHkVZWxPHHfKsDKj61WJPi+OPLVWDu Fa8ohDPEr9SXZCWgjyCFSr11Y90ZQMHYLW4qcJvR/q0dssrwVBCYY2TgECsxT/NJnt VakL+gVQz51fVfqKkwGckOIyEWrXe1RLoRXufxLw= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 24/30] hw/ppc/ppc4xx_pci: Replace pointless warning by assert() Date: Fri, 4 Sep 2020 13:47:13 +1000 Message-Id: <20200904034719.673626-25-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200904034719.673626-1-david@gibson.dropbear.id.au> References: <20200904034719.673626-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: danielhb413@gmail.com, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, bauerman@linux.ibm.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Philippe Mathieu-Daud=C3=A9 We call pci_register_root_bus() to register 4 IRQs with the ppc4xx_pci_set_irq() handler. As it can only be called with values in the [0-4[ range, replace the pointless warning by an assert(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200901104043.91383-5-f4bug@amsat.org> Reviewed-by: Richard Henderson Signed-off-by: David Gibson --- hw/ppc/ppc4xx_pci.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/ppc/ppc4xx_pci.c b/hw/ppc/ppc4xx_pci.c index cd3f192a13..503ef46b39 100644 --- a/hw/ppc/ppc4xx_pci.c +++ b/hw/ppc/ppc4xx_pci.c @@ -256,10 +256,7 @@ static void ppc4xx_pci_set_irq(void *opaque, int irq_n= um, int level) qemu_irq *pci_irqs =3D opaque; =20 trace_ppc4xx_pci_set_irq(irq_num); - if (irq_num < 0) { - fprintf(stderr, "%s: PCI irq %d\n", __func__, irq_num); - return; - } + assert(irq_num >=3D 0); qemu_set_irq(pci_irqs[irq_num], level); } =20 --=20 2.26.2