From nobody Mon Feb 9 07:55:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599131324; cv=none; d=zohomail.com; s=zohoarc; b=Yk7Q3QeiG53O5s5mZF44SJFKIgUZpTpCLIaGfwnay/od1ElD5uw72pi9O/4fjGAueycUz3lCosEIc1TlC7iMPI9kdhFT8BKY+PNS0/Xm7ZKdYHJht6FSC3i+AbU3kC9Byp4O2xeUI5K2IESS8DbHnv/BAoCFTjKFqZtTtWyxSu0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599131324; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=TrCc5tJ7tNpb4UHqNYewv5YRJY1ciA4UDwcY4eIZ444=; b=faiCB7QY8vhuaZhWEoDkZaT5xi4aPqZWklHLQiSVyVX4dIG/Gj/9h+9VlgIBjoVrq7+KdgG6CTgqm6BqRFqcSFL8ai3KrV/3PGxkGcL0kVw/pdv6Q9/drQESsSpI336XbXJ/uRdYdoPzuarsOR+OPrM8K4JIzS0Z6JGBtH3XR1s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1599131324668770.6221390391224; Thu, 3 Sep 2020 04:08:44 -0700 (PDT) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-426-IIAxf2CXP_a96LPTxpzCFQ-1; Thu, 03 Sep 2020 07:08:42 -0400 Received: by mail-wm1-f72.google.com with SMTP id q7so840599wmc.6 for ; Thu, 03 Sep 2020 04:08:42 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (50.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.50]) by smtp.gmail.com with ESMTPSA id t203sm3782107wmg.43.2020.09.03.04.08.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 04:08:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599131323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TrCc5tJ7tNpb4UHqNYewv5YRJY1ciA4UDwcY4eIZ444=; b=PiU8lLn+Ky+hTxYXbezYrZfMrNWeDp3Amtt4HQI+5fWpHKfnS6UF/nDRrjMxNFkWeR3AA0 2bhlaYUUOcNUVwE/J+ZZyl6apxE9uQTqAvYgUWFEje+yiVF/hTgO42w/MFo+6/uHVYLgF4 aBCjdgni69I3NsKAjDljfW8YOrchIN8= X-MC-Unique: IIAxf2CXP_a96LPTxpzCFQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TrCc5tJ7tNpb4UHqNYewv5YRJY1ciA4UDwcY4eIZ444=; b=YX4Je2qhPt5H2qEZFgiF44MKejN/VdxICaNOYfHel4CpW/g1tRExUoN5wHEWHbLUxQ M+PFY32GQHMUbbSSar2wex2hRyEaiGia/yAEW5CN/CbLUPP0LPh3n6hVJcvSGuXiiFMv TMsIe3Gp8EdOps9w/dch0Kme0YOZ0S1hPASwzfNP6LlN0UfeOHTgL1JUO3bPmC41Iyzp NP9Ab7mX2ZjLevrIEbzJnxBDjZy6SAcvP4ORCo7BD6N6lS9IUfjeCTuGWugk+1GHAq50 Yd5ZjXN2tdOWWPbBAcPyKWl54OmKJZJac0ekDNREd82kCvu8XTriJPkmgUOj5DrkUNfa cZpQ== X-Gm-Message-State: AOAM532VaHYruIvx5aGphMygW+qGnsy2o6IaSMUvvWcrdEAzBNHYnFBU j1UCF476xF0e+tEJ/it/Y38hA3Y9v0WWasIGb6vb7hrYreHM6kpOdU+G2oerwe+NsC3JZgsGuFw fUa7ev/m6Brg7lQ== X-Received: by 2002:adf:ef45:: with SMTP id c5mr1787484wrp.37.1599131321244; Thu, 03 Sep 2020 04:08:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1nDVtyj2C5ereY9H7VxhNf1/u/J+QL0uGJVVe99wm6AacViHBWUkekx13e+NQGBdcWUEh9g== X-Received: by 2002:adf:ef45:: with SMTP id c5mr1787437wrp.37.1599131321081; Thu, 03 Sep 2020 04:08:41 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: John Snow , Gerd Hoffmann , Li Qiang , "Michael S. Tsirkin" , "Edgar E. Iglesias" , Eduardo Habkost , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jan Kiszka , Emanuele Giuseppe Esposito , Eric Auger , Peter Chubb , Beniamino Galvani , Robert Foley , Paolo Bonzini , "Emilio G . Cota" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jason Wang , Andrew Baumann , Laszlo Ersek , Klaus Jensen , Stefan Hajnoczi , Tony Nguyen , Peter Xu , qemu-arm@nongnu.org, Prasad J Pandit , qemu-block@nongnu.org, Alistair Francis , Andrew Jeffery , Alexander Bulekov , Marcel Apfelbaum , "Edgar E . Iglesias" , Joel Stanley , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , qemu-ppc@nongnu.org, Mark Cave-Ayland , David Gibson , Richard Henderson , Keith Busch Subject: [PATCH 01/12] pci: pass along the return value of dma_memory_rw Date: Thu, 3 Sep 2020 13:08:20 +0200 Message-Id: <20200903110831.353476-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200903110831.353476-1-philmd@redhat.com> References: <20200903110831.353476-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) From: Klaus Jensen Some might actually care about the return value of dma_memory_rw. So let us pass it along instead of ignoring it. There are no existing users of the return value, so this patch should be safe. Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Michael S. Tsirkin Acked-by: Keith Busch Message-Id: <20191011070141.188713-2-its@irrelevant.dk> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/pci/pci.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 4ca7258b5b7..896cef9ad47 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -788,8 +788,7 @@ static inline AddressSpace *pci_get_address_space(PCIDe= vice *dev) static inline int pci_dma_rw(PCIDevice *dev, dma_addr_t addr, void *buf, dma_addr_t len, DMADirection dir) { - dma_memory_rw(pci_get_address_space(dev), addr, buf, len, dir); - return 0; + return dma_memory_rw(pci_get_address_space(dev), addr, buf, len, dir); } =20 static inline int pci_dma_read(PCIDevice *dev, dma_addr_t addr, --=20 2.26.2