From nobody Sun Nov 16 07:41:28 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599121592; cv=none; d=zohomail.com; s=zohoarc; b=hmFvPEGcEgrbGPpmSSncUTZfmrreAJ6dqHugI0sv6mPrNXzFXat+p/y7sdrHIdD8qQl1ETJ6MCnXJHR9OeQ1JWDumbcOUgVyylUjRTiQVx89ZXGtw0FBD6RuAeEPFu3+4ZYLLsjRqJ9ZDJdoN/7mCQDrk+rtLlmMuWnWHSIEXhk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599121592; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RQH1cJbYM7RTOn2N/nvb7r0JrpvVSjb4iYelSRnoVzQ=; b=CAROcuh9nv+C3iYBq0uhv1iQ4LQad/STPbJyvaMXYXwi6nv/ruc3Kg+2syGJzOyEMzg4/F2ypblyAX3vPeFSIskQYLLr4lnb6cmXKkt+JGEC7DSHcn40lxjUp2vnlUHjJgYKr3CVrR9AVRG11ICt1cxNXaF9bnjDXUAdKEdnSVU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1599121592876155.47317655622373; Thu, 3 Sep 2020 01:26:32 -0700 (PDT) Received: from localhost ([::1]:39014 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDkZk-0008Uu-27 for importer@patchew.org; Thu, 03 Sep 2020 04:26:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDkXD-00039V-8G for qemu-devel@nongnu.org; Thu, 03 Sep 2020 04:23:55 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:35453 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kDkXB-0008Sq-L8 for qemu-devel@nongnu.org; Thu, 03 Sep 2020 04:23:54 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-329-kUx-KGHzPiGQjISWzpIapg-1; Thu, 03 Sep 2020 04:23:48 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0525D107B2AD; Thu, 3 Sep 2020 08:23:48 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-113-68.ams2.redhat.com [10.36.113.68]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C8F7A672CF; Thu, 3 Sep 2020 08:23:47 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C2EF31189F45; Thu, 3 Sep 2020 10:23:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599121432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RQH1cJbYM7RTOn2N/nvb7r0JrpvVSjb4iYelSRnoVzQ=; b=GHIGOcIoiUA69/W9A8dLjHyhUWKUMDT1g++zmzZBUSzra3i4QssHEwctii+ZR2jym4vSKf VyRX/jCcLqFMNUCR61lqZi3zzwu+AqgLdht+VkKwFu7vLUYAfRLDO+8YT1UZEa8YZa04Lz fgvvDKdzI86c7KNFqzohN50IfLvgia0= X-MC-Unique: kUx-KGHzPiGQjISWzpIapg-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 5/8] scripts/qmp/qom-fuse: Fix getattr(), read() for files in / Date: Thu, 3 Sep 2020 10:23:41 +0200 Message-Id: <20200903082344.1877175-6-armbru@redhat.com> In-Reply-To: <20200903082344.1877175-1-armbru@redhat.com> References: <20200903082344.1877175-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/03 04:23:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , peter.maydell@linaro.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) path, prop =3D "type".rsplit('/', 1) sets path to "", which doesn't work. Correct to "/". Signed-off-by: Markus Armbruster Message-Id: <20200723142738.1868568-4-armbru@redhat.com> Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: John Snow --- scripts/qmp/qom-fuse | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/scripts/qmp/qom-fuse b/scripts/qmp/qom-fuse index 405e6ebd67..7c7cff8edf 100755 --- a/scripts/qmp/qom-fuse +++ b/scripts/qmp/qom-fuse @@ -45,8 +45,10 @@ class QOMFS(Operations): return False =20 def is_property(self, path): + path, prop =3D path.rsplit('/', 1) + if path =3D=3D '': + path =3D '/' try: - path, prop =3D path.rsplit('/', 1) for item in self.qmp.command('qom-list', path=3Dpath): if item['name'] =3D=3D prop: return True @@ -55,8 +57,10 @@ class QOMFS(Operations): return False =20 def is_link(self, path): + path, prop =3D path.rsplit('/', 1) + if path =3D=3D '': + path =3D '/' try: - path, prop =3D path.rsplit('/', 1) for item in self.qmp.command('qom-list', path=3Dpath): if item['name'] =3D=3D prop: if item['type'].startswith('link<'): @@ -71,6 +75,8 @@ class QOMFS(Operations): return -ENOENT =20 path, prop =3D path.rsplit('/', 1) + if path =3D=3D '': + path =3D '/' try: data =3D self.qmp.command('qom-get', path=3Dpath, property=3Dp= rop) data +=3D '\n' # make values shell friendly --=20 2.26.2